From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5F69C433E2 for ; Tue, 23 Mar 2021 08:45:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F16D86198C for ; Tue, 23 Mar 2021 08:45:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F16D86198C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49336 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOceu-0005Rf-Dv for qemu-devel@archiver.kernel.org; Tue, 23 Mar 2021 04:45:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOcdv-00050T-Fq for qemu-devel@nongnu.org; Tue, 23 Mar 2021 04:44:03 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:34306) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lOcdt-0002Qp-Uu for qemu-devel@nongnu.org; Tue, 23 Mar 2021 04:44:03 -0400 Received: by mail-wr1-x430.google.com with SMTP id j7so19880201wrd.1 for ; Tue, 23 Mar 2021 01:44:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TRJwqkDM+7N5us8jhk/gQEaEManjMc6HzNEZ67aJWfo=; b=su0F+gBHvjv8EyxMzUXLwD/gm/68PdKDjfHjbRsbGT4iPPs9+nCJstmAyfIDilW855 1keXiAFvYSoa1iukjnovXDTfl6T7cjgc6NqzBBBwWeJy4XPlw18NPajX59olVE52yO3x 8cEuWPyn7VHg4QXHuuTDSxV9F9rDczGj8KqTcVcZGw2ByLX6hKV0Dq86aIzTy+wYhOWV JBXHPZlDtj/KkPv2Q8yAXi4VfL8SKqXIoNme60KDEboeqpODnzJMhnfhwe/OKuvqD71S JsAHXDf61ixQXXqKBHnnhVNaf7NUtMucs/L3ajuQ3+CBQm4+hzmnF+5eyxHfLQfm2HXI d8JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TRJwqkDM+7N5us8jhk/gQEaEManjMc6HzNEZ67aJWfo=; b=XU5ENkpb2IHgDJp4b5nqxlzKtsvy0ZlWLDZGLLBQ6M/6aESZ3ugarYJOypJsBaTNYb pqgjVARKDSch35bfFRRgn2LDyIDDcGskzLk6wqBm69IYNrBLB4ZsB/gS1tdfCOuDtwDB 6JpFYyV68Ze7dChbAzH+aTbeOV0cyjMLPGsvuRtJtWP4kTtb7KyCAc8MTLHlITG9KnQe sPP0QFA7UC8LuZ9y66AF47jfO9LRFvDusrmuH1TZ4XA4nxt0Fwp3bfJbZ84qqgLYvBHI jYSIx6jfB6EBmZRTF1OUd4Gt9gCEjn7Djx0XmUn2r8elVNIRq9kXVGahW9AzQB9r6OjA E32g== X-Gm-Message-State: AOAM5308DbXzsxLaq5He0bSwwDTdkR2caJmps+SO6vabgay4HOsmyVyb QcoaVSwq0NglXoFR26/e2/lTLC+d6Lmbcw== X-Google-Smtp-Source: ABdhPJx01a+FFCS28I+SyL8o+ebpTqFWXajb2OCw8BWSMx9ZwNjXoZkL7uG1/LZBwuH7avbmSocPAg== X-Received: by 2002:a5d:534b:: with SMTP id t11mr2744004wrv.186.1616489039989; Tue, 23 Mar 2021 01:43:59 -0700 (PDT) Received: from [192.168.1.36] (17.red-88-21-201.staticip.rima-tde.net. [88.21.201.17]) by smtp.gmail.com with ESMTPSA id w6sm22160281wrl.49.2021.03.23.01.43.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Mar 2021 01:43:58 -0700 (PDT) Subject: Re: [RFC] accel: add cpu_reset To: Claudio Fontana , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Peter Maydell , =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20210322132800.7470-1-cfontana@suse.de> <20210322132800.7470-2-cfontana@suse.de> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <5969c241-4f1f-7013-3765-0a3ee0a054cf@amsat.org> Date: Tue, 23 Mar 2021 09:43:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x430.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Roman Bolshakov , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/22/21 2:54 PM, Claudio Fontana wrote: > On 3/22/21 2:42 PM, Philippe Mathieu-Daudé wrote: >> On 3/22/21 2:27 PM, Claudio Fontana wrote: >>> XXX >>> --- >>> accel/accel-common.c | 9 +++++++++ >>> hw/core/cpu.c | 3 ++- >>> include/hw/core/accel-cpu.h | 2 ++ >>> include/qemu/accel.h | 6 ++++++ >>> target/i386/cpu.c | 4 ---- >>> target/i386/kvm/kvm-cpu.c | 6 ++++++ >>> 6 files changed, 25 insertions(+), 5 deletions(-) >>> >>> >>> This surprisingly works without moving cpu_reset() to a >>> specific_ss module, even though >>> >>> accel-common.c is specific_ss, >>> hw/core/cpu.c is common_ss. >>> >>> How come the call to accel_reset_cpu works? >> >> Each CPU optionally calls cpu_reset() manually? > > Hi Philippe, are you concerned about these calls? > Or what are you highlighting here? > > They in turn call cpu_reset() so we should be good right? I guess I simply misunderstood your question :)