From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andre Przywara Subject: Re: kvm_read_guest_page() missing kvm->srcu read lock? Date: Fri, 11 May 2018 14:25:43 +0100 Message-ID: <59750e07-2c69-a63e-bad4-25f7c21febbf@arm.com> References: <32913bee-6ccc-cab7-65fb-fb6896c3d19c@arm.com> <6a60301f-1fb7-a60a-d47a-85f7ea79b1a7@redhat.com> <7a24f679-142b-9283-b7dc-f3d8e70c420a@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: James Hogan , Marc Zyngier , Jan Glauber , Paul Mackerras , "kvmarm@lists.cs.columbia.edu" , David Gibson To: Paolo Bonzini , "kvm@vger.kernel.org" Return-path: In-Reply-To: <7a24f679-142b-9283-b7dc-f3d8e70c420a@redhat.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu List-Id: kvm.vger.kernel.org SGksCgpPbiAxMS8wNS8xOCAxMjo0MywgUGFvbG8gQm9uemluaSB3cm90ZToKPiBPbiAxMS8wNS8y MDE4IDEzOjAyLCBBbmRyZSBQcnp5d2FyYSB3cm90ZToKPj4gSGkgUGFvbG8sCj4+Cj4+IHRoYW5r cyBmb3IgdGhlIGFuc3dlciEKPj4gVG9vayBtZSBhIGJpdCwgYnV0IEkgdGhpbmsgeW91IGFyZSBy aWdodCAoc2VlIGJlbG93KS4KPj4KPj4gT24gMTAvMDUvMTggMTg6NDMsIFBhb2xvIEJvbnppbmkg d3JvdGU6Cj4+PiBPbiAxMC8wNS8yMDE4IDE5OjQxLCBBbmRyZSBQcnp5d2FyYSB3cm90ZToKPj4+ PiBIaSwKPj4+Pgo+Pj4+IEphbiBwb3N0ZWQgYW4gbG9ja2RlcCBzcGxhdCBjb21wbGFpbmluZyBh Ym91dCBhIHN1c3BpY2lvdXMKPj4+PiByY3VfZGVyZWZlcmVuY2VfY2hlY2s6Cj4+Pj4gaHR0cHM6 Ly9saXN0cy5jcy5jb2x1bWJpYS5lZHUvcGlwZXJtYWlsL2t2bWFybS8yMDE4LU1heS8wMzExMTYu aHRtbAo+Pj4+Cj4+Pj4gVGhlIGdpc3Qgb2YgdGhhdCBpczoKPj4+PiAuLi4KPj4+PiBbIDEwMjUu Njk1NTE3XSAgZHVtcF9zdGFjaysweDljLzB4ZDQKPj4+PiBbIDEwMjUuNjk1NTI0XSAgbG9ja2Rl cF9yY3Vfc3VzcGljaW91cysweGNjLzB4MTE4Cj4+Pj4gWyAxMDI1LjY5NTUzN10gIGdmbl90b19t ZW1zbG90KzB4MTc0LzB4MTkwCj4+Pj4gWyAxMDI1LjY5NTU0Nl0gIGt2bV9yZWFkX2d1ZXN0KzB4 NTAvMHhiMAo+Pj4+IFsgMTAyNS42OTU1NTNdICB2Z2ljX2l0c19jaGVja19pZC5pc3JhLjArMHgx MTQvMHgxNDgKPj4+PiAuLi4KPj4+PiBJIGNoYXNlZCB0aGF0IGRvd24gYW5kIHdvbmRlciBpZiBr dm1fcmVhZF9ndWVzdHssX3BhZ2V9IGlzIHN1cHBvc2VkIHRvCj4+Pj4gYmUgY2FsbGVkIGluc2lk ZSBhIGt2bS0+c3JjdSBjcml0aWNhbCBzZWN0aW9uPwo+Pj4+Cj4+Pj4gV2UgaGF2ZSBhIGNoZWNr IHRoYXQgc3VnZ2VzdHMgdGhhdCBldmVudHVhbGx5IHNvbWVvbmUgbmVlZHMgdG8gZW50ZXIgdGhl Cj4+Pj4gU1JDVSBjcml0aWNpYWwgc2VjdGlvbjoKPj4+PiBzdGF0aWMgaW5saW5lIHN0cnVjdCBr dm1fbWVtc2xvdHMgKl9fa3ZtX21lbXNsb3RzKHN0cnVjdCBrdm0gKmt2bSwKPj4+PiAJCQkJCQkg IGludCBhc19pZCkKPj4+PiB7Cj4+Pj4gICAgICAgICByZXR1cm4gc3JjdV9kZXJlZmVyZW5jZV9j aGVjayhrdm0tPm1lbXNsb3RzW2FzX2lkXSwgJmt2bS0+c3JjdSwKPj4+PiAgICAgICAgICAgICAg ICAgICAgICAgICBsb2NrZGVwX2lzX2hlbGQoJmt2bS0+c2xvdHNfbG9jaykgfHwKPj4+PiAgICAg ICAgICAgICAgICAgICAgICAgICAhcmVmY291bnRfcmVhZCgma3ZtLT51c2Vyc19jb3VudCkpOwo+ Pj4+IH0KPj4+Pgo+Pj4+IElmIEkgZ2V0IHRoaXMgY29ycmVjdGx5IHRoaXMgbWVhbiBmb3IgYWNj ZXNzaW5nIGt2bS0+bWVtc2xvdHMgd2UgZWl0aGVyCj4+Pj4gbmVlZCB0byBiZSBpbnNpZGUgYW4g c3JjdSBjcml0aWNhbCBzZWN0aW9uIG9yIGhvbGQgdGhlIGt2bS0+c2xvdHNfbG9jawo+Pj4+IChm b3IgdXBkYXRlcyBvbmx5KS4KPj4+Pgo+Pj4+IElmIEkgYW0gbm90IG1pc3Rha2VuLCBpdCBpcyBu b3QgbmVjZXNzYXJ5IGZvciAqY2FsbGVycyogb2YKPj4+PiBrdm1fcmVhZF9ndWVzdF9wYWdlKCkg dG8gZG8gdGhpcywgYXMgdGhpcyBjb3VsZCBiZSBlbnRpcmVseSBjb250YWluZWQKPj4+PiBpbnNp ZGUgdGhpcyBmdW5jdGlvbiAtIHNpbmNlIHdlIG9ubHkgdXNlIHRoZSByZWZlcmVuY2UgdG8gdGhl IG1lbXNsb3QKPj4+PiBlbnRyeSB3aGlsZSBkb2luZyB0aGUgY29weV9mcm9tX3VzZXIoKSwgYW5k IHRoZSBkYXRhIGlzIHNhZmUgYWZ0ZXJ3YXJkcwo+Pj4+IGZyb20gYW4gUkNVIHBvaW50IG9mIHZp ZXcgYmVjYXVzZSBpdCBoYXMgYmVlbiAqY29waWVkKi4KPj4+Cj4+PiBZZXMsIGl0J3MgdGhlIGNh bGxlcidzIHJlc3BvbnNpYmlsaXR5LiAgc3JjdV9yZWFkX2xvY2svdW5sb2NrIGlzIHByZXR0eQo+ Pj4gZXhwZW5zaXZlCj4+Cj4+IElzIHRoYXQgc28/IEkgd2FzIHVuZGVyIHRoZSBpbXByZXNzaW9u IHRoYXQgZGVjbGFyaW5nIFJDVSBjcml0aWNhbAo+PiBzZWN0aW9ucyBpcyB2ZXJ5IGNoZWFwLCBp cyB0aGF0IGRpZmZlcmVudCB3aXRoIFNSQ1U/Cj4gCj4gWWVzLCBiZWNhdXNlIFJDVSBlZmZlY3Rp dmVseSBsZXRzIHRoZSBzY2hlZHVsZXIgZG8gdGhlIGV4cGVuc2l2ZSBwYXJ0cy4KPiBXaXRoIFNS Q1UgeW91IGhhdmUgdG8gZG8gdGhlbSB5b3Vyc2VsZiB3aXRoIHRoZSBhZHZhbnRhZ2UgdGhhdDog MSkgeW91Cj4gY2FuIHNsZWVwIGR1cmluZyBSQ1UgY3JpdGljYWwgc2VjdGlvbnM7IDIpIHN5bmNo cm9uaXplX3NyY3UgaXMgbXVjaAo+IGNoZWFwZXIgdGhhbiBzeW5jaHJvbml6ZV9yY3UgYW5kIHN5 bmNocm9uaXplX3NjaGVkLgo+IAo+IEl0IGlzIHN0aWxsIHJlbGF0aXZlbHkgY2hlYXAsIGFuZCBp dCBkb2Vzbid0IHNlcmlhbGl6ZSBhZ2FpbnN0IHdyaXRlcnMsCj4gYnV0IHRoZSBvcmRlciBvZiBt YWduaXR1ZGUgaXMgMTAwIGNsb2NrIGN5Y2xlcyBmb3IgZWFjaCBvZiBsb2NrIGFuZAo+IHVubG9j ay4gIENvbXBhcmVkIHdpdGggcmN1X3JlYWRfbG9jay91bmxvY2ssIHdoaWNoIGFyZSBub3BzIG9u IGFueQo+IGtlcm5lbCBidXQgUFJFRU1QVF9SVCwgdGhhdCBjb3VudHMgYXMgZXhwZW5zaXZlLiA6 KQo+IAo+Pj4gc28gS1ZNIGFzc3VtZXMgdGhhdCB0aGUgdG9wbW9zdCBjYWxsZXJzIGRvIGl0Lgo+ Pgo+PiBPSywgZmFpciBlbm91Z2guIEFuZCB3aXRoIHNvbWUgaGludHMgZnJvbSBKw7ZyZyBJIHVu ZGVyc3RhbmQgbm93IHRoYXQgeDg2Cj4+IGFuZCBzMzkwIGRvIGEgInNyY3VfcmVhZF9sb2NrKCZr dm0tPnNyY3UpOyIgcmlnaHQgYWZ0ZXIgbGVhdmluZyB0aGUKPiA6PiBndWVzdCBhbmQgdW5sb2Nr IGl0IG9ubHkgc2hvcnRseSBiZWZvcmUgZW50ZXJpbmcgYWdhaW4sIHNvIHRoYXQgYW55Cj4+IGlu dGVybWVkaWF0ZSBjYWxscyBhcmUgcHJvdGVjdGVkLiBUaGF0IGxlYXZlcyB0aGUgbG9ja2luZyBk dXR5IG9ubHkgdXAKPj4gdG8gY2FsbHMgb3JpZ2luYXRpbmcgZnJvbSB1c2Vyc3BhY2UuCj4+IEJ1 dCBBRkFJQ1QgbmVpdGhlciBtaXBzLCBwb3dlcnBjIG9yIGFybS9hcm02NCBhcmUgZG9pbmcgdGhp cy4gSSBhbQo+PiBjaGVja2luZyBub3cgd2hldGhlciB0aGlzIGlzIGFuIG9taXNzaW9uIG9yIHdo ZXRoZXIgdGhleSBhcmUgcmVhbGx5Cj4+IGRvaW5nIGZpbmUgZ3JhaW5lZCBsb2NraW5nIGZvciBh bGwgbWVtc2xvdHMgYWNjZXNzZXMuCj4gCj4gT2ssIGxldCBtZSBDYyB0aGUgbWFpbnRhaW5lcnMu ICBJIHN1cHBvc2UgYXQgbGVhc3Qgc29tZSBvZiB0aGVtIGRvIHVzZQo+IGxvY2tkZXAgZnJvbSB0 aW1lIHRvIHRpbWUsIGJ1dCBpdCBpcyBjZXJ0YWlubHkgcG9zc2libGUgdGhhdCBzb21lIGNhc2Vz Cj4gaGF2ZSBiZWVuIG1pc3NlZC4KClRoYW5rcyBmb3IgdGhhdC4gQXMgZmFyIGFzIEkgY2FuIHNl ZSwgbWlwcyBzZWVtcyB0byBiZSBzYWZlLCBiZWNhdXNlCnRoZXkgZG9uJ3QgdXNlIGt2bV9yZWFk X2d1ZXN0KCkgYW5kIHRoZSBvdGhlciBtZW1zbG90IHJlZmVyZW5jZXMgc2VlbSB0bwpiZSBwcm9w ZXJseSBwcm90ZWN0ZWQuIFNvIEphbWVzIGNhbiBlbmpveSB0aGlzIHdlZWtlbmQgOy0pCgpGb3Ig cG93ZXJwYyBpdCdzIGEgYml0IG1vcmUgY29tcGxleCwgSSB0cmllZCB0byBjaGFzZSBkb3duIGF0 IGxlYXN0IHRoZQpmb3VyIHVzZXJzIG9mIGt2bV9yZWFkX2d1ZXN0KCk6Ci0gVGhlIG9uZSBpbiBh cmNoL3Bvd2VycGMva3ZtL2Jvb2szc19ydGFzLmMgaXMgc2FmZS4KLSBUaGUgdHdvIHVzZXJzIGlu IGFyY2gvcG93ZXJwYy9rdm0vYm9vazNzXzY0X21tdV9yYWRpeC5jIGRvbid0IHNlZW0gdG8KdGFr ZSBhbnkgbG9ja3MsIGJ1dCBhcmUgb25seSBjYWxsZWQgd2hlbiBjcmVhdGluZyB0aGUgVk0sIHNv IHRoYXQncwpzdXBwb3NlZGx5IHNvbWV3aGF0IHNhZmUgKD8pCi0gSSBjb3VsZG4ndCBmaW5kIGFu eSBwcm90ZWN0aW9uIGZvciB0aGUgdXNhZ2UgaW4KYXJjaC9wb3dlcnBjL2t2bS9wb3dlcnBjLmMs IGJ1dCB0aGUgY2FsbCBjaGFpbiBpcyBxdWl0ZSBjb252b2x1dGVkCnRoZXJlLCBzbyBJIG1pZ2h0 IGhhdmUgbWlzc2VkIHNvbWV0aGluZy4gSXQgd291bGQgYmUgZ29vZCBpZiBzb21lb25lCm1vcmUg ZmFtaWxpYXIgd2l0aCB0aGlzIGNvZGUgd291bGQgdGFrZSBhIGxvb2suCgo+IEFkZGluZyB0aGUg c3JjdV9yZWFkX2xvY2svdW5sb2NrIGRpcmVjdGx5IGluIGt2bV9hcmNoX3ZjcHVfaW9jdGxfcnVu IGFuZAo+IGFueSBvdGhlciBpb2N0bHMgdGhhdCBuZWVkIGl0IGlzIGJlc3QsIGJ1dCBpbiBhbnkg Y2FzZSBhZGRpbmcgbW9yZSBwYWlycwo+IGlzIHNhZmUgYmVjYXVzZSB0aGV5IGNhbiBiZSBuZXN0 ZWQuCgpTbyBJIGFkZGVkIGEgc21hbGwgd3JhcHBlciBhcm91bmQga3ZtX3JlYWRfZ3Vlc3QoKSwg d2hpY2ggdGFrZXMgYW5kCmRyb3BzIHRoZSBsb2NrLiBXaWxsIHNlbmQgb3V0IHRoZSBwYXRjaCBz aG9ydGx5LiBJZiBwb3dlcnBjIG5lZWRzIGl0LCBJCmFtIGhhcHB5IHRvIHByb3ZpZGUgdGhpcyB3 cmFwcGVyIGluIGt2bV9tYWluLmMgaW5zdGVhZCBvZiBzb21lIGFybQpoZWFkZXIgZmlsZSBpbnN0 ZWFkLgoKQ2hlZXJzLApBbmRyZS4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18Ka3ZtYXJtIG1haWxpbmcgbGlzdAprdm1hcm1AbGlzdHMuY3MuY29sdW1iaWEu ZWR1Cmh0dHBzOi8vbGlzdHMuY3MuY29sdW1iaWEuZWR1L21haWxtYW4vbGlzdGluZm8va3ZtYXJt Cg==