All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Wang <wei.w.wang@intel.com>
To: linux-kernel@vger.kernel.org, qemu-devel@nongnu.org,
	virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
	linux-mm@kvack.org, mst@redhat.com, david@redhat.com,
	cornelia.huck@de.ibm.com, akpm@linux-foundation.org,
	mgorman@techsingularity.net, aarcange@redhat.com,
	amit.shah@redhat.com, pbonzini@redhat.com,
	liliang.opensource@gmail.com, mhocko@kernel.org,
	willy@infradead.org
Cc: yang.zhang.wz@gmail.com, virtio-dev@lists.oasis-open.org,
	quan.xu@aliyun.com
Subject: Re: [PATCH v12 5/8] virtio-balloon: VIRTIO_BALLOON_F_SG
Date: Fri, 28 Jul 2017 16:25:19 +0800	[thread overview]
Message-ID: <597AF4EF.4020705__18931.7300254062$1501230174$gmane$org@intel.com> (raw)
In-Reply-To: <1499863221-16206-6-git-send-email-wei.w.wang@intel.com>

On 07/12/2017 08:40 PM, Wei Wang wrote:
> Add a new feature, VIRTIO_BALLOON_F_SG, which enables to
> transfer a chunk of ballooned (i.e. inflated/deflated) pages using
> scatter-gather lists to the host.
>
> The implementation of the previous virtio-balloon is not very
> efficient, because the balloon pages are transferred to the
> host one by one. Here is the breakdown of the time in percentage
> spent on each step of the balloon inflating process (inflating
> 7GB of an 8GB idle guest).
>
> 1) allocating pages (6.5%)
> 2) sending PFNs to host (68.3%)
> 3) address translation (6.1%)
> 4) madvise (19%)
>
> It takes about 4126ms for the inflating process to complete.
> The above profiling shows that the bottlenecks are stage 2)
> and stage 4).
>
> This patch optimizes step 2) by transferring pages to the host in
> sgs. An sg describes a chunk of guest physically continuous pages.
> With this mechanism, step 4) can also be optimized by doing address
> translation and madvise() in chunks rather than page by page.
>
> With this new feature, the above ballooning process takes ~491ms
> resulting in an improvement of ~88%.
>


I found a recent mm patch, bb01b64cfab7c22f3848cb73dc0c2b46b8d38499
, zeros all the ballooned pages, which is very time consuming.

Tests show that the time to balloon 7G pages is increased from ~491 ms to
2.8 seconds with the above patch.

How about moving the zero operation to the hypervisor? In this way, we
will have a much faster balloon process.


Best,
Wei

  parent reply	other threads:[~2017-07-28  8:25 UTC|newest]

Thread overview: 290+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-12 12:40 [PATCH v12 0/8] Virtio-balloon Enhancement Wei Wang
2017-07-12 12:40 ` [virtio-dev] " Wei Wang
2017-07-12 12:40 ` [Qemu-devel] " Wei Wang
2017-07-12 12:40 ` Wei Wang
2017-07-12 12:40 ` [PATCH v12 1/8] virtio-balloon: deflate via a page list Wei Wang
2017-07-12 12:40 ` Wei Wang
2017-07-12 12:40   ` [virtio-dev] " Wei Wang
2017-07-12 12:40   ` [Qemu-devel] " Wei Wang
2017-07-12 12:40   ` Wei Wang
2017-07-12 12:40 ` [PATCH v12 2/8] virtio-balloon: coding format cleanup Wei Wang
2017-07-12 12:40   ` [virtio-dev] " Wei Wang
2017-07-12 12:40   ` [Qemu-devel] " Wei Wang
2017-07-12 12:40   ` Wei Wang
2017-07-12 12:40 ` Wei Wang
2017-07-12 12:40 ` [PATCH v12 3/8] Introduce xbitmap Wei Wang
2017-07-12 12:40   ` [virtio-dev] " Wei Wang
2017-07-12 12:40   ` [Qemu-devel] " Wei Wang
2017-07-12 12:40   ` Wei Wang
2017-07-12 12:40 ` Wei Wang
2017-07-12 12:40 ` [PATCH v12 4/8] xbitmap: add xb_find_next_bit() and xb_zero() Wei Wang
2017-07-12 12:40   ` [virtio-dev] " Wei Wang
2017-07-12 12:40   ` [Qemu-devel] " Wei Wang
2017-07-12 12:40   ` Wei Wang
2017-07-12 12:40 ` Wei Wang
2017-07-12 12:40 ` [PATCH v12 5/8] virtio-balloon: VIRTIO_BALLOON_F_SG Wei Wang
2017-07-12 12:40 ` Wei Wang
2017-07-12 12:40   ` [virtio-dev] " Wei Wang
2017-07-12 12:40   ` [Qemu-devel] " Wei Wang
2017-07-12 12:40   ` Wei Wang
2017-07-12 13:06   ` Michael S. Tsirkin
2017-07-12 13:06     ` [virtio-dev] " Michael S. Tsirkin
2017-07-12 13:06     ` [Qemu-devel] " Michael S. Tsirkin
2017-07-12 13:06     ` Michael S. Tsirkin
2017-07-12 13:29     ` Wei Wang
2017-07-12 13:29     ` Wei Wang
2017-07-12 13:29       ` [virtio-dev] " Wei Wang
2017-07-12 13:29       ` [Qemu-devel] " Wei Wang
2017-07-12 13:29       ` Wei Wang
2017-07-12 13:56       ` Michael S. Tsirkin
2017-07-12 13:56         ` [virtio-dev] " Michael S. Tsirkin
2017-07-12 13:56         ` [Qemu-devel] " Michael S. Tsirkin
2017-07-12 13:56         ` Michael S. Tsirkin
2017-07-13  7:42         ` Wei Wang
2017-07-13  7:42           ` [virtio-dev] " Wei Wang
2017-07-13  7:42           ` [Qemu-devel] " Wei Wang
2017-07-13  7:42           ` Wei Wang
2017-07-13 20:19           ` Michael S. Tsirkin
2017-07-13 20:19             ` [virtio-dev] " Michael S. Tsirkin
2017-07-13 20:19             ` [Qemu-devel] " Michael S. Tsirkin
2017-07-13 20:19             ` Michael S. Tsirkin
2017-07-14  7:12             ` Wei Wang
2017-07-14  7:12             ` Wei Wang
2017-07-14  7:12               ` [virtio-dev] " Wei Wang
2017-07-14  7:12               ` [Qemu-devel] " Wei Wang
2017-07-14  7:12               ` Wei Wang
2017-07-23  1:45               ` Michael S. Tsirkin
2017-07-23  1:45                 ` [virtio-dev] " Michael S. Tsirkin
2017-07-23  1:45                 ` [Qemu-devel] " Michael S. Tsirkin
2017-07-23  1:45                 ` Michael S. Tsirkin
2017-07-26  3:48                 ` Wei Wang
2017-07-26  3:48                 ` Wei Wang
2017-07-26  3:48                   ` [virtio-dev] " Wei Wang
2017-07-26  3:48                   ` [Qemu-devel] " Wei Wang
2017-07-26  3:48                   ` Wei Wang
2017-07-26 17:02                   ` Michael S. Tsirkin
2017-07-26 17:02                   ` Michael S. Tsirkin
2017-07-26 17:02                     ` [virtio-dev] " Michael S. Tsirkin
2017-07-26 17:02                     ` [Qemu-devel] " Michael S. Tsirkin
2017-07-26 17:02                     ` Michael S. Tsirkin
2017-07-27  2:50                     ` Wei Wang
2017-07-27  2:50                     ` Wei Wang
2017-07-27  2:50                       ` [virtio-dev] " Wei Wang
2017-07-27  2:50                       ` [Qemu-devel] " Wei Wang
2017-07-27  2:50                       ` Wei Wang
2017-07-28 23:08                       ` Michael S. Tsirkin
2017-07-28 23:08                         ` [virtio-dev] " Michael S. Tsirkin
2017-07-28 23:08                         ` [Qemu-devel] " Michael S. Tsirkin
2017-07-28 23:08                         ` Michael S. Tsirkin
2017-07-29 12:47                         ` Wei Wang
2017-07-29 12:47                           ` [virtio-dev] " Wei Wang
2017-07-29 12:47                           ` [Qemu-devel] " Wei Wang
2017-07-29 12:47                           ` Wei Wang
2017-07-29 12:47                           ` Wei Wang
2017-07-30  4:22                           ` Michael S. Tsirkin
2017-07-30  4:22                           ` Michael S. Tsirkin
2017-07-30  4:22                             ` [virtio-dev] " Michael S. Tsirkin
2017-07-30  4:22                             ` [Qemu-devel] " Michael S. Tsirkin
2017-07-30  4:22                             ` Michael S. Tsirkin
2017-07-30  5:59                             ` Wang, Wei W
2017-07-30  5:59                               ` [Qemu-devel] " Wang, Wei W
2017-07-30  5:59                               ` Wang, Wei W
2017-07-30 16:18                               ` Michael S. Tsirkin
2017-07-30 16:18                                 ` [Qemu-devel] " Michael S. Tsirkin
2017-07-30 16:18                                 ` Michael S. Tsirkin
2017-07-30 16:18                                 ` Michael S. Tsirkin
2017-07-30 16:20                                 ` Michael S. Tsirkin
2017-07-30 16:20                                 ` Michael S. Tsirkin
2017-07-30 16:20                                   ` [Qemu-devel] " Michael S. Tsirkin
2017-07-30 16:20                                   ` Michael S. Tsirkin
2017-07-30 16:20                                   ` Michael S. Tsirkin
2017-07-31 12:36                                   ` Wei Wang
2017-07-31 12:36                                   ` Wei Wang
2017-07-31 12:36                                     ` [virtio-dev] " Wei Wang
2017-07-31 12:36                                     ` [Qemu-devel] " Wei Wang
2017-07-31 12:36                                     ` Wei Wang
2017-07-30 16:18                               ` Michael S. Tsirkin
2017-07-30  5:59                             ` Wang, Wei W
2017-07-28 23:08                       ` Michael S. Tsirkin
2017-07-23  1:45               ` Michael S. Tsirkin
2017-07-13 20:19           ` Michael S. Tsirkin
2017-07-13  7:42         ` Wei Wang
2017-07-12 13:56       ` Michael S. Tsirkin
2017-07-12 13:06   ` Michael S. Tsirkin
2017-07-13  0:44   ` Michael S. Tsirkin
2017-07-13  0:44   ` Michael S. Tsirkin
2017-07-13  0:44     ` [virtio-dev] " Michael S. Tsirkin
2017-07-13  0:44     ` [Qemu-devel] " Michael S. Tsirkin
2017-07-13  0:44     ` Michael S. Tsirkin
2017-07-13  1:16   ` kbuild test robot
2017-07-13  1:16     ` [Qemu-devel] " kbuild test robot
2017-07-13  1:16     ` kbuild test robot
2017-07-13  1:16   ` kbuild test robot
2017-07-13  4:21   ` kbuild test robot
2017-07-13  4:21     ` [Qemu-devel] " kbuild test robot
2017-07-13  4:21     ` kbuild test robot
2017-07-13  4:21   ` kbuild test robot
2017-07-28  8:25   ` Wei Wang
2017-07-28  8:25     ` [virtio-dev] " Wei Wang
2017-07-28  8:25     ` [Qemu-devel] " Wei Wang
2017-07-28  8:25     ` Wei Wang
2017-07-28 23:01     ` Michael S. Tsirkin
2017-07-28 23:01     ` Michael S. Tsirkin
2017-07-28 23:01       ` [virtio-dev] " Michael S. Tsirkin
2017-07-28 23:01       ` [Qemu-devel] " Michael S. Tsirkin
2017-07-28 23:01       ` Michael S. Tsirkin
2017-07-28  8:25   ` Wei Wang [this message]
2017-07-12 12:40 ` [PATCH v12 6/8] mm: support reporting free page blocks Wei Wang
2017-07-12 12:40   ` [virtio-dev] " Wei Wang
2017-07-12 12:40   ` [Qemu-devel] " Wei Wang
2017-07-12 12:40   ` Wei Wang
2017-07-13  0:33   ` Michael S. Tsirkin
2017-07-13  0:33   ` Michael S. Tsirkin
2017-07-13  0:33     ` [virtio-dev] " Michael S. Tsirkin
2017-07-13  0:33     ` [Qemu-devel] " Michael S. Tsirkin
2017-07-13  0:33     ` Michael S. Tsirkin
2017-07-13  8:25     ` Wei Wang
2017-07-13  8:25       ` [virtio-dev] " Wei Wang
2017-07-13  8:25       ` [Qemu-devel] " Wei Wang
2017-07-13  8:25       ` Wei Wang
2017-07-13  8:25     ` Wei Wang
2017-07-14 12:30   ` Michal Hocko
2017-07-14 12:30     ` [Qemu-devel] " Michal Hocko
2017-07-14 12:30     ` Michal Hocko
2017-07-14 12:54     ` Michal Hocko
2017-07-14 12:54       ` [Qemu-devel] " Michal Hocko
2017-07-14 12:54       ` Michal Hocko
2017-07-14 15:46       ` Michael S. Tsirkin
2017-07-14 15:46       ` Michael S. Tsirkin
2017-07-14 15:46         ` [virtio-dev] " Michael S. Tsirkin
2017-07-14 15:46         ` [Qemu-devel] " Michael S. Tsirkin
2017-07-14 15:46         ` Michael S. Tsirkin
2017-07-14 12:54     ` Michal Hocko
2017-07-14 19:17     ` Michael S. Tsirkin
2017-07-14 19:17       ` [virtio-dev] " Michael S. Tsirkin
2017-07-14 19:17       ` [Qemu-devel] " Michael S. Tsirkin
2017-07-14 19:17       ` Michael S. Tsirkin
2017-07-17 15:24       ` Michal Hocko
2017-07-17 15:24       ` Michal Hocko
2017-07-17 15:24         ` [Qemu-devel] " Michal Hocko
2017-07-17 15:24         ` Michal Hocko
2017-07-18  2:12         ` Wei Wang
2017-07-18  2:12           ` [virtio-dev] " Wei Wang
2017-07-18  2:12           ` [Qemu-devel] " Wei Wang
2017-07-18  2:12           ` Wei Wang
2017-07-18  2:12           ` Wei Wang
2017-07-19  8:13           ` Michal Hocko
2017-07-19  8:13             ` [Qemu-devel] " Michal Hocko
2017-07-19  8:13             ` Michal Hocko
2017-07-19 12:01             ` Wei Wang
2017-07-19 12:01             ` Wei Wang
2017-07-19 12:01               ` [virtio-dev] " Wei Wang
2017-07-19 12:01               ` [Qemu-devel] " Wei Wang
2017-07-19 12:01               ` Wei Wang
2017-07-24  9:00               ` Michal Hocko
2017-07-24  9:00                 ` [Qemu-devel] " Michal Hocko
2017-07-24  9:00                 ` Michal Hocko
2017-07-25  9:32                 ` Wei Wang
2017-07-25  9:32                 ` Wei Wang
2017-07-25  9:32                   ` [virtio-dev] " Wei Wang
2017-07-25  9:32                   ` [Qemu-devel] " Wei Wang
2017-07-25  9:32                   ` Wei Wang
2017-07-25 11:25                   ` Michal Hocko
2017-07-25 11:25                   ` Michal Hocko
2017-07-25 11:25                     ` [Qemu-devel] " Michal Hocko
2017-07-25 11:25                     ` Michal Hocko
2017-07-25 11:56                     ` Wei Wang
2017-07-25 11:56                       ` [virtio-dev] " Wei Wang
2017-07-25 11:56                       ` [Qemu-devel] " Wei Wang
2017-07-25 11:56                       ` Wei Wang
2017-07-25 12:41                       ` Michal Hocko
2017-07-25 12:41                         ` [Qemu-devel] " Michal Hocko
2017-07-25 12:41                         ` Michal Hocko
2017-07-25 12:41                         ` Michal Hocko
2017-07-25 14:47                         ` Wang, Wei W
2017-07-25 14:47                         ` Wang, Wei W
2017-07-25 14:47                           ` [virtio-dev] " Wang, Wei W
2017-07-25 14:47                           ` [Qemu-devel] " Wang, Wei W
2017-07-25 14:47                           ` Wang, Wei W
2017-07-25 14:47                           ` Wang, Wei W
2017-07-25 14:53                           ` Michal Hocko
2017-07-25 14:53                             ` [Qemu-devel] " Michal Hocko
2017-07-25 14:53                             ` Michal Hocko
2017-07-25 14:53                             ` Michal Hocko
2017-07-26  2:22                             ` Wei Wang
2017-07-26  2:22                             ` Wei Wang
2017-07-26  2:22                               ` [virtio-dev] " Wei Wang
2017-07-26  2:22                               ` [Qemu-devel] " Wei Wang
2017-07-26  2:22                               ` Wei Wang
2017-07-26  2:22                               ` Wei Wang
2017-07-26 10:24                               ` Michal Hocko
2017-07-26 10:24                                 ` [Qemu-devel] " Michal Hocko
2017-07-26 10:24                                 ` Michal Hocko
2017-07-26 10:24                                 ` Michal Hocko
2017-07-26 11:44                                 ` Wei Wang
2017-07-26 11:44                                   ` [virtio-dev] " Wei Wang
2017-07-26 11:44                                   ` [Qemu-devel] " Wei Wang
2017-07-26 11:44                                   ` Wei Wang
2017-07-26 11:44                                   ` Wei Wang
2017-07-26 11:55                                   ` Michal Hocko
2017-07-26 11:55                                   ` Michal Hocko
2017-07-26 11:55                                     ` [Qemu-devel] " Michal Hocko
2017-07-26 11:55                                     ` Michal Hocko
2017-07-26 11:55                                     ` Michal Hocko
2017-07-26 12:47                                     ` Wang, Wei W
2017-07-26 12:47                                     ` Wang, Wei W
2017-07-26 12:47                                       ` [virtio-dev] " Wang, Wei W
2017-07-26 12:47                                       ` [Qemu-devel] " Wang, Wei W
2017-07-26 12:47                                       ` Wang, Wei W
2017-07-26 12:47                                       ` Wang, Wei W
2017-07-26 10:24                               ` Michal Hocko
2017-07-25 11:56                     ` Wei Wang
2017-07-24  9:00               ` Michal Hocko
2017-07-19  8:13           ` Michal Hocko
2017-07-14 19:17     ` Michael S. Tsirkin
2017-07-14 12:30   ` Michal Hocko
2017-07-12 12:40 ` Wei Wang
2017-07-12 12:40 ` [PATCH v12 7/8] mm: export symbol of next_zone and first_online_pgdat Wei Wang
2017-07-12 12:40 ` Wei Wang
2017-07-12 12:40   ` [virtio-dev] " Wei Wang
2017-07-12 12:40   ` [Qemu-devel] " Wei Wang
2017-07-12 12:40   ` Wei Wang
2017-07-13  0:16   ` Michael S. Tsirkin
2017-07-13  0:16     ` [virtio-dev] " Michael S. Tsirkin
2017-07-13  0:16     ` [Qemu-devel] " Michael S. Tsirkin
2017-07-13  0:16     ` Michael S. Tsirkin
2017-07-13  8:41     ` [virtio-dev] " Wei Wang
2017-07-13  8:41       ` Wei Wang
2017-07-13  8:41       ` [Qemu-devel] " Wei Wang
2017-07-13  8:41       ` Wei Wang
2017-07-13  8:41     ` Wei Wang
2017-07-13  0:16   ` Michael S. Tsirkin
2017-07-14 12:31   ` Michal Hocko
2017-07-14 12:31   ` Michal Hocko
2017-07-14 12:31     ` [Qemu-devel] " Michal Hocko
2017-07-14 12:31     ` Michal Hocko
2017-07-12 12:40 ` [PATCH v12 8/8] virtio-balloon: VIRTIO_BALLOON_F_CMD_VQ Wei Wang
2017-07-12 12:40   ` [virtio-dev] " Wei Wang
2017-07-12 12:40   ` [Qemu-devel] " Wei Wang
2017-07-12 12:40   ` Wei Wang
2017-07-13  0:22   ` Michael S. Tsirkin
2017-07-13  0:22   ` Michael S. Tsirkin
2017-07-13  0:22     ` [virtio-dev] " Michael S. Tsirkin
2017-07-13  0:22     ` [Qemu-devel] " Michael S. Tsirkin
2017-07-13  0:22     ` Michael S. Tsirkin
2017-07-13  8:46     ` Wei Wang
2017-07-13  8:46     ` Wei Wang
2017-07-13  8:46       ` [virtio-dev] " Wei Wang
2017-07-13  8:46       ` [Qemu-devel] " Wei Wang
2017-07-13  8:46       ` Wei Wang
2017-07-13 17:59       ` Michael S. Tsirkin
2017-07-13 17:59       ` Michael S. Tsirkin
2017-07-13 17:59         ` [virtio-dev] " Michael S. Tsirkin
2017-07-13 17:59         ` [Qemu-devel] " Michael S. Tsirkin
2017-07-13 17:59         ` Michael S. Tsirkin
2017-07-12 12:40 ` Wei Wang
2017-07-13  0:14 ` [PATCH v12 0/8] Virtio-balloon Enhancement Michael S. Tsirkin
2017-07-13  0:14 ` Michael S. Tsirkin
2017-07-13  0:14   ` [virtio-dev] " Michael S. Tsirkin
2017-07-13  0:14   ` [Qemu-devel] " Michael S. Tsirkin
2017-07-13  0:14   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='597AF4EF.4020705__18931.7300254062$1501230174$gmane$org@intel.com' \
    --to=wei.w.wang@intel.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=amit.shah@redhat.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=david@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=liliang.opensource@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@kernel.org \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quan.xu@aliyun.com \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=willy@infradead.org \
    --cc=yang.zhang.wz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.