From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] netcat: add forced dependence on BusyBox
Date: Sun, 1 Apr 2018 00:25:02 +0200 [thread overview]
Message-ID: <598357b1-0a95-a38d-9704-bfe7adae0f20@mind.be> (raw)
In-Reply-To: <00cfde34-7006-40de-ecb5-307418aa97b8@smile.fr>
On 31-03-18 12:34, Romain Naour wrote:
> Hi Carlos,
>
> Le 12/10/2017 ? 17:14, Carlos Santos a ?crit?:
>> It may be necessary if packages become built in parallel, leading to a
>> race condition on the creation of the "nc" link. Moreover, netcat is as
>> shy as BusyBox and would not override an existing file/link, so we must
>> remove $(TARGET_DIR)/usr/bin/nc in advance.
>>
>> Of course this still leaves a race conditon if other netcat competitors
>> but we must assume thet the user is a grown-up person who knows what is
>> doing.
>
> It seems you are using a custom busybox config file because the netcat applet is
> disabled by default.
>
> I'm agree, the dependency on busybox is missing but the TARGET_HOOKS doesn't
> seems necessary. I removed it and netcat package is able to override the busybox
> symlink.
>
> /usr/bin/install -c netcat output/target/usr/bin/netcat
I've applied, after removing the unneeded removal of nc.
If it turns out to be needed after all, please submit a follow-up patch.
Regards,
Arnout
>
> Maybe we should check if other packages depending on
> BR2_PACKAGE_BUSYBOX_SHOW_OTHERS have a dependency on busybox.
[snip]
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
next prev parent reply other threads:[~2018-03-31 22:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 15:14 [Buildroot] [PATCH v4] nmap: add option to build/install ncat Carlos Santos
2017-10-12 15:14 ` [Buildroot] [PATCH] netcat: add forced dependence on BusyBox Carlos Santos
2018-03-31 10:34 ` Romain Naour
2018-03-31 13:03 ` Arnout Vandecappelle
2018-03-31 13:17 ` Yann E. MORIN
2018-03-31 22:25 ` Arnout Vandecappelle [this message]
2018-03-31 22:31 ` Arnout Vandecappelle
2018-04-02 13:32 ` [Buildroot] [PATCH v4] nmap: add option to build/install ncat Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=598357b1-0a95-a38d-9704-bfe7adae0f20@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.