From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932508AbbJMOds (ORCPT ); Tue, 13 Oct 2015 10:33:48 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:51766 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932419AbbJMOdo (ORCPT ); Tue, 13 Oct 2015 10:33:44 -0400 From: Arnd Bergmann To: Murali Karicheri Cc: corbet@lwn.net, ssantosh@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, devicetree@vger.kernel.org Subject: Re: [PATCH v2 2/4] soc: ti: add firmware file name as part of the driver Date: Tue, 13 Oct 2015 16:32:43 +0200 Message-ID: <5984319.ffuyRPpBNk@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1444679211-823-3-git-send-email-m-karicheri2@ti.com> References: <1444679211-823-1-git-send-email-m-karicheri2@ti.com> <1444679211-823-3-git-send-email-m-karicheri2@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:rZb8G049HVcjD0RtdkChFS2bS6dFQscvIKcz+nJLRm9DnWJ6adn uYUCwXb52sVojR7TwTN67CBVb/wODRBf/HBvt9Zj9x/AVZwrSkQlcPECRiwNddtUdOmWm65 5l2Zg9hhqymG+uovYvQdYxc6BC1k2kucMr0U3kYa4pjuUC/RiNBCJUUPMld5LDqqoJt8EQ9 uU3bUj5uJSg/wIQtADtjw== X-UI-Out-Filterresults: notjunk:1;V01:K0:jtwCyPPjh64=:FDllsX/5K17GkpCtGjNIm8 +c7WdGnTotZ4DsspqjtP+/ReKUn3LWIHLJfT5KHtIpH+7bozXs+YyFJ9Jc43nZ4mm1kyT1yJM +uPP0kqlR4PmSyjl8z+721UCn2zlH+T0EsQxk5oOYgfAEyNeTVMABEOE7QVcRsL1FuahfACzg Tah0Q9evFxMuv4rJrwpcSF1+TmDEq6bsPXx4TKVqjMolx/WNvz7QJzM8HQGZxzdsafr4bNySU f6IsU/hJvTB5x6ghsciykGZn8ZOsPHqCrNIarx96S+0o6jqJFuFyB1JKrIXPa9MCo0LxEtVtU P1jABe5teHsf5PH3XdoiW1anFn/FaVXAVb5vvthzrG1ddNfUfjOkHSD6KOsS87CKw9ClNTiRp fMMWG1Rf9rztOez9+k/TLTBA3+MboYdCBd3zXEwKp+0cfWTBI28gQq2VQfDsSh98WXEGdFGBj ZZI/wu8/qxTtEkmpvcVjYIoNoTIBEynh4g3xWGTMidnBizQI47BtXyhoagrMlX4wU+Wk22T4s 9SI0pzrUorxC+8jJgBkC2nKaz6/h71B/fxlOMNIBrT1L8omie/cTBQhyspRnKacMM7MZgc2no 9ixofY9/hgvV3ZouZzNez0SZ3MWuhvPEhJ0G7AEosRNaHcOZ4+YXw+YeUv6G/2C6Yjygf+pl2 xhGyIr7bj2/psOZE6CgdUhZTc1EiBb5ZBYHTq/evAjSHCZnBKwwC34nYSqParSoBN8QTyMYZi SoUPGus9R1vui8t/ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 12 October 2015 15:46:49 Murali Karicheri wrote: > Currently firmware file name is included in the DTS. This is not scalable > as user has to change the DTS if they need upgrade to a new firmware. > Instead, add the firmware file name in the driver itself. As long as there > is no API change, new firmware upgrade is easy and require no driver > change. User is expected to copy the firmware image to the file system > and add a sym link to the new firmware for doing an upgrade. Driver add > a array of firmware file names to search for the available firmware blobs. > This scheme also prepare the driver for future changes to API if ever > happens. In such case it is assumed that driver needs to change to > accommodate the new firmware and new firmware file name will get added to > the array. > > Also update the DT document to remove the firmware attribute and add > description about firmware in the driver documentation. > > Signed-off-by: Murali Karicheri > Acked-by: Arnd Bergmann Looks good. From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 13 Oct 2015 16:32:43 +0200 Subject: [PATCH v2 2/4] soc: ti: add firmware file name as part of the driver In-Reply-To: <1444679211-823-3-git-send-email-m-karicheri2@ti.com> References: <1444679211-823-1-git-send-email-m-karicheri2@ti.com> <1444679211-823-3-git-send-email-m-karicheri2@ti.com> Message-ID: <5984319.ffuyRPpBNk@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 12 October 2015 15:46:49 Murali Karicheri wrote: > Currently firmware file name is included in the DTS. This is not scalable > as user has to change the DTS if they need upgrade to a new firmware. > Instead, add the firmware file name in the driver itself. As long as there > is no API change, new firmware upgrade is easy and require no driver > change. User is expected to copy the firmware image to the file system > and add a sym link to the new firmware for doing an upgrade. Driver add > a array of firmware file names to search for the available firmware blobs. > This scheme also prepare the driver for future changes to API if ever > happens. In such case it is assumed that driver needs to change to > accommodate the new firmware and new firmware file name will get added to > the array. > > Also update the DT document to remove the firmware attribute and add > description about firmware in the driver documentation. > > Signed-off-by: Murali Karicheri > Acked-by: Arnd Bergmann Looks good.