From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ajay Bhargav <ajay.bhargav@einfochips.com>
Date: Fri, 2 Sep 2011 11:25:43 +0530 (IST)
Subject: [U-Boot] [PATCH v5 2/3] Armada100: Enable Ethernet support for
	GplugD
In-Reply-To: <201109020758.21326.marek.vasut@gmail.com>
Message-ID: <598579349.20494.1314942943430.JavaMail.root@ahm.einfochips.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de


----- "Marek Vasut" <marek.vasut@gmail.com> wrote:

> On Friday, September 02, 2011 07:18:40 AM Ajay Bhargav wrote:
> > This patch enables ethernet support for Marvell GplugD board.
> Network
> > related commands works.
> > 
> > Signed-off-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
> > ---
> > Changes for v2:
> > 	- armada100_fec_initialize changed to armada100_fec_register
> > Changes for v3:
> > 	- fec base address as argument to armada100_fec_register
> > Changes for v4:
> > 	- Not changed
> > Changes for v5:
> > 	- Coding style cleanup
> > 
[...]
> > +/* DHCP Support */
> > +#define CONFIG_CMD_DHCP
> > +#define CONFIG_BOOTP_DHCP_REQUEST_DELAY		50000
> > +#define CONFIG_BOOTP_SERVERIP
> 
> Why is this empty?
> 

oops!? missed? :/ Prafulla, can You remove this?
> #define CONFIG_BOOTP_SERVERIP

or should I email again? I donno how I missed this.

> Other than that,
> 
> Acked-by: Marek Vasut <marek.vasut@gmail.com>
> > +
> > +/* Default Boot Parameters */
> > +#define CONFIG_ROOTPATH				"/tftpboot"
> > +#define CONFIG_SYS_IMG_NAME			"uImage"
> > 
> >  /*
> >   * mv-common.h should be defined after CMD configs since it used
> them
> 

Thanks,
Ajay Bhargav