All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Steigerwald <Martin@lichtvoll.de>
To: Chris Mason <clm@fb.com>
Cc: Liu Bo <bo.li.liu@oracle.com>, linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v3] Btrfs: fix task hang under heavy compressed write
Date: Sun, 31 Aug 2014 13:48:36 +0200	[thread overview]
Message-ID: <5987063.Et4MtoWL1c@merkaba> (raw)
In-Reply-To: <6660868.gHr8BxRfi4@merkaba>

Am Dienstag, 26. August 2014, 15:20:21 schrieb Martin Steigerwald:
> Am Dienstag, 26. August 2014, 09:02:23 schrieb Chris Mason:
> > On 08/26/2014 06:20 AM, Martin Steigerwald wrote:
> > > Am Montag, 25. August 2014, 10:58:13 schrieb Chris Mason:
> > >> On 08/15/2014 11:36 AM, Liu Bo wrote:
> > >>> This has been reported and discussed for a long time, and this hang
> > >>> occurs
> > >>> in both 3.15 and 3.16.
> > >> 
> > >> [ great description ]
> > >> 
> > >> I ran this through tests last week, and an overnight test over the
> > >> weekend.  It's in my for-linus branch now, along with everything else I
> > >> plan on sending for rc3.
> > >> 
> > >> Please double check my merge, I had to undo your rebase onto Miao's
> > >> patches.>
> > > 
> > > I would like to test this on 3.17-rc2, what do I need to do to make it
> > > apply cleanly? That function in disk-io.c looks quite different from
> > > what
> > > the patch assumes at the beginning, so I am not sure how to merge this.
> > 
> > You can just pull my for-linus branch, Liu Bo's fix is on top.
> 
> Thanks, I put the commit on top of your for-linus branch on top of 3.17-rc2.
> Lets see how it goes.

So far this appears to work well.

I have experienced no hangs.

Tested-By: Martin Steigerwald <martin@lichtvoll.de>

But I bet Linus took it already anyways :). Looking forward to rc3.

Thanks for digging into and fixing this long standing annoying bug.

Thanks,
-- 
Martin 'Helios' Steigerwald - http://www.Lichtvoll.de
GPG: 03B0 0D6C 0040 0710 4AFA  B82F 991B EAAC A599 84C7

  reply	other threads:[~2014-08-31 11:48 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-12  7:44 [PATCH] Btrfs: fix task hang under heavy compressed write Liu Bo
2014-08-12 14:35 ` [PATCH v2] " Liu Bo
2014-08-12 14:57 ` [PATCH] " Chris Mason
2014-08-13  0:53   ` Qu Wenruo
2014-08-13 11:54 ` Martin Steigerwald
2014-08-13 13:27   ` Rich Freeman
2014-08-13 15:20   ` Liu Bo
2014-08-14  9:27     ` Martin Steigerwald
2014-08-15 17:51       ` Martin Steigerwald
2014-08-15 15:36 ` [PATCH v3] " Liu Bo
2014-08-15 16:05   ` Chris Mason
2014-08-16  7:28   ` Miao Xie
2014-08-18  7:32     ` Liu Bo
2014-08-25 14:58   ` Chris Mason
2014-08-25 15:19     ` Liu Bo
2014-08-26 10:20     ` Martin Steigerwald
2014-08-26 10:38       ` Liu Bo
2014-08-26 12:04         ` Martin Steigerwald
2014-08-26 13:02       ` Chris Mason
2014-08-26 13:20         ` Martin Steigerwald
2014-08-31 11:48           ` Martin Steigerwald [this message]
2014-08-31 15:40             ` Liu Bo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5987063.Et4MtoWL1c@merkaba \
    --to=martin@lichtvoll.de \
    --cc=bo.li.liu@oracle.com \
    --cc=clm@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.