From: Wei Wang <wei.w.wang@intel.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: aarcange@redhat.com, virtio-dev@lists.oasis-open.org,
kvm@vger.kernel.org, mawilcox@microsoft.com,
amit.shah@redhat.com, liliang.opensource@gmail.com,
mst@redhat.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
yang.zhang.wz@gmail.com, quan.xu@aliyun.com,
cornelia.huck@de.ibm.com, pbonzini@redhat.com,
akpm@linux-foundation.org, mgorman@techsingularity.net
Subject: Re: [virtio-dev] Re: [PATCH v13 4/5] mm: support reporting free page blocks
Date: Thu, 10 Aug 2017 15:38:34 +0800 [thread overview]
Message-ID: <598C0D7A.9060909__41446.9303250828$1502350592$gmane$org@intel.com> (raw)
In-Reply-To: <20170810070517.GB23863@dhcp22.suse.cz>
On 08/10/2017 03:05 PM, Michal Hocko wrote:
> On Tue 08-08-17 14:34:25, Wei Wang wrote:
>> On 08/08/2017 02:12 PM, Wei Wang wrote:
>>> On 08/03/2017 05:11 PM, Michal Hocko wrote:
>>>> On Thu 03-08-17 14:38:18, Wei Wang wrote:
>>>> This is just too ugly and wrong actually. Never provide struct page
>>>> pointers outside of the zone->lock. What I've had in mind was to simply
>>>> walk free lists of the suitable order and call the callback for each
>>>> one.
>>>> Something as simple as
>>>>
>>>> for (i = 0; i < MAX_NR_ZONES; i++) {
>>>> struct zone *zone = &pgdat->node_zones[i];
>>>>
>>>> if (!populated_zone(zone))
>>>> continue;
>>> Can we directly use for_each_populated_zone(zone) here?
> yes, my example couldn't because I was still assuming per-node API
>
>>>> spin_lock_irqsave(&zone->lock, flags);
>>>> for (order = min_order; order < MAX_ORDER; ++order) {
>>>
>>> This appears to be covered by for_each_migratetype_order(order, mt) below.
> yes but
> #define for_each_migratetype_order(order, type) \
> for (order = 0; order < MAX_ORDER; order++) \
> for (type = 0; type < MIGRATE_TYPES; type++)
>
> so you would have to skip orders < min_order
Yes, that's why we have a new macro
#define for_each_migratetype_order_decend(min_order, order, type) \
for (order = MAX_ORDER - 1; order < MAX_ORDER && order >= min_order; \
order--) \
for (type = 0; type < MIGRATE_TYPES; type++)
If you don't like the macro, we can also directly use it in the code.
I think it would be better to report the larger free page block first, since
the callback has an opportunity (though just a theoretical possibility,
good to
take that into consideration if possible) to skip reporting the given
free page
block to the hypervisor as the ring gets full. Losing the small block is
better
than losing the larger one, in terms of the optimization work.
Best,
Wei
next prev parent reply other threads:[~2017-08-10 7:38 UTC|newest]
Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 6:38 [PATCH v13 0/5] Virtio-balloon Enhancement Wei Wang
2017-08-03 6:38 ` [virtio-dev] " Wei Wang
2017-08-03 6:38 ` Wei Wang
2017-08-03 6:38 ` [PATCH v13 1/5] Introduce xbitmap Wei Wang
2017-08-03 6:38 ` [virtio-dev] " Wei Wang
2017-08-03 6:38 ` Wei Wang
2017-08-07 6:58 ` Wei Wang
2017-08-07 6:58 ` [virtio-dev] " Wei Wang
2017-08-07 6:58 ` Wei Wang
2017-08-07 6:58 ` Wei Wang
2017-08-09 21:36 ` Andrew Morton
2017-08-09 21:36 ` Andrew Morton
2017-08-09 21:36 ` Andrew Morton
2017-08-10 5:59 ` Wei Wang
2017-08-10 5:59 ` [virtio-dev] " Wei Wang
2017-08-10 5:59 ` Wei Wang
2017-08-10 5:59 ` Wei Wang
2017-08-03 6:38 ` [PATCH v13 2/5] xbitmap: add xb_find_next_bit() and xb_zero() Wei Wang
2017-08-03 6:38 ` [virtio-dev] " Wei Wang
2017-08-03 6:38 ` Wei Wang
2017-08-03 6:38 ` [PATCH v13 3/5] virtio-balloon: VIRTIO_BALLOON_F_SG Wei Wang
2017-08-03 6:38 ` [virtio-dev] " Wei Wang
2017-08-03 6:38 ` Wei Wang
2017-08-03 14:22 ` Michael S. Tsirkin
2017-08-03 14:22 ` Michael S. Tsirkin
2017-08-03 14:22 ` [virtio-dev] " Michael S. Tsirkin
2017-08-03 14:22 ` Michael S. Tsirkin
2017-08-03 15:17 ` Wang, Wei W
2017-08-03 15:17 ` [virtio-dev] " Wang, Wei W
2017-08-03 15:17 ` Wang, Wei W
2017-08-03 15:17 ` Wang, Wei W
2017-08-03 15:55 ` Michael S. Tsirkin
2017-08-03 15:55 ` Michael S. Tsirkin
2017-08-03 15:55 ` [virtio-dev] " Michael S. Tsirkin
2017-08-03 15:55 ` Michael S. Tsirkin
2017-08-03 15:55 ` Michael S. Tsirkin
2017-08-03 15:17 ` Wang, Wei W
2017-08-03 6:38 ` [PATCH v13 4/5] mm: support reporting free page blocks Wei Wang
2017-08-03 6:38 ` [virtio-dev] " Wei Wang
2017-08-03 6:38 ` Wei Wang
2017-08-03 9:11 ` Michal Hocko
2017-08-03 9:11 ` Michal Hocko
2017-08-03 10:42 ` Wei Wang
2017-08-03 10:42 ` [virtio-dev] " Wei Wang
2017-08-03 10:42 ` Wei Wang
2017-08-03 10:44 ` Michal Hocko
2017-08-03 10:44 ` Michal Hocko
2017-08-03 11:27 ` Wei Wang
2017-08-03 11:27 ` [virtio-dev] " Wei Wang
2017-08-03 11:27 ` Wei Wang
2017-08-03 11:28 ` Michal Hocko
2017-08-03 11:28 ` Michal Hocko
2017-08-03 12:11 ` Wei Wang
2017-08-03 12:11 ` [virtio-dev] " Wei Wang
2017-08-03 12:11 ` Wei Wang
2017-08-03 12:41 ` Michal Hocko
2017-08-03 12:41 ` Michal Hocko
2017-08-03 13:17 ` Wei Wang
2017-08-03 13:17 ` [virtio-dev] " Wei Wang
2017-08-03 13:17 ` Wei Wang
2017-08-03 13:50 ` Michal Hocko
2017-08-03 13:50 ` Michal Hocko
2017-08-03 15:20 ` Wang, Wei W
2017-08-03 15:20 ` Wang, Wei W
2017-08-03 15:20 ` [virtio-dev] " Wang, Wei W
2017-08-03 15:20 ` Wang, Wei W
2017-08-03 15:20 ` Wang, Wei W
2017-08-03 21:02 ` Michael S. Tsirkin
2017-08-03 21:02 ` Michael S. Tsirkin
2017-08-03 21:02 ` [virtio-dev] " Michael S. Tsirkin
2017-08-03 21:02 ` Michael S. Tsirkin
2017-08-03 21:02 ` Michael S. Tsirkin
2017-08-04 7:53 ` Michal Hocko
2017-08-04 7:53 ` Michal Hocko
2017-08-04 7:53 ` Michal Hocko
2017-08-04 7:53 ` Michal Hocko
2017-08-04 8:15 ` Wei Wang
2017-08-04 8:15 ` Wei Wang
2017-08-04 8:15 ` [virtio-dev] " Wei Wang
2017-08-04 8:15 ` Wei Wang
2017-08-04 8:15 ` Wei Wang
2017-08-04 8:24 ` Michal Hocko
2017-08-04 8:24 ` Michal Hocko
2017-08-04 8:24 ` Michal Hocko
2017-08-04 8:24 ` Michal Hocko
2017-08-04 8:55 ` Wei Wang
2017-08-04 8:55 ` [virtio-dev] " Wei Wang
2017-08-04 8:55 ` Wei Wang
2017-08-04 8:55 ` Wei Wang
2017-08-04 8:55 ` Wei Wang
2017-08-08 6:12 ` Wei Wang
2017-08-08 6:12 ` [virtio-dev] " Wei Wang
2017-08-08 6:12 ` Wei Wang
2017-08-08 6:34 ` [virtio-dev] " Wei Wang
2017-08-08 6:34 ` Wei Wang
2017-08-08 6:34 ` Wei Wang
2017-08-08 6:34 ` Wei Wang
2017-08-08 6:34 ` Wei Wang
2017-08-10 7:05 ` [virtio-dev] " Michal Hocko
2017-08-10 7:05 ` Michal Hocko
2017-08-10 7:38 ` Wei Wang [this message]
2017-08-10 7:38 ` Wei Wang
2017-08-10 7:38 ` Wei Wang
2017-08-10 7:38 ` Wei Wang
2017-08-10 7:38 ` Wei Wang
2017-08-10 7:53 ` [virtio-dev] " Michal Hocko
2017-08-10 7:53 ` Michal Hocko
2017-08-10 7:53 ` Michal Hocko
2017-08-10 7:05 ` Michal Hocko
2017-08-08 6:12 ` Wei Wang
2017-08-03 6:38 ` [PATCH v13 5/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ Wei Wang
2017-08-03 6:38 ` [virtio-dev] " Wei Wang
2017-08-03 6:38 ` Wei Wang
2017-08-03 8:13 ` Pankaj Gupta
2017-08-03 8:13 ` Pankaj Gupta
2017-08-03 12:28 ` Wei Wang
2017-08-03 12:28 ` [virtio-dev] " Wei Wang
2017-08-03 12:28 ` Wei Wang
2017-08-03 13:05 ` Pankaj Gupta
2017-08-03 13:05 ` Pankaj Gupta
2017-08-03 13:21 ` Wei Wang
2017-08-03 13:21 ` [virtio-dev] " Wei Wang
2017-08-03 13:21 ` Wei Wang
2017-08-03 12:33 ` Michael S. Tsirkin
2017-08-03 12:33 ` [virtio-dev] " Michael S. Tsirkin
2017-08-03 12:33 ` Michael S. Tsirkin
2017-08-03 16:11 ` kbuild test robot
2017-08-03 16:11 ` kbuild test robot
2017-08-16 5:57 ` [virtio-dev] [PATCH v13 0/5] Virtio-balloon Enhancement Adam Tao
2017-08-16 5:57 ` Adam Tao
2017-08-16 5:57 ` Adam Tao
2017-08-16 9:33 ` Wei Wang
2017-08-16 9:33 ` Wei Wang
2017-08-16 9:33 ` Wei Wang
2017-08-16 9:33 ` Wei Wang
2017-08-16 5:57 ` Adam Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='598C0D7A.9060909__41446.9303250828$1502350592$gmane$org@intel.com' \
--to=wei.w.wang@intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=amit.shah@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=liliang.opensource@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mawilcox@microsoft.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=quan.xu@aliyun.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.