From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH v2 39/52] xen: check parameter validity when
 parsing command line
Date: Mon, 14 Aug 2017 06:46:16 -0600
Message-ID: <5991B7B8020000780016F5D0@prv-mh.provo.novell.com>
References: <20170814070849.20986-1-jgross@suse.com>
 <20170814070849.20986-40-jgross@suse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta6.messagelabs.com ([193.109.254.103])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <JBeulich@suse.com>) id 1dhElY-0007GS-0c
 for xen-devel@lists.xenproject.org; Mon, 14 Aug 2017 12:46:44 +0000
In-Reply-To: <20170814070849.20986-40-jgross@suse.com>
Content-Disposition: inline
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wei.liu2@citrix.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

Pj4+IE9uIDE0LjA4LjE3IGF0IDA5OjA4LCA8amdyb3NzQHN1c2UuY29tPiB3cm90ZToKPiAtLS0g
YS94ZW4vY29tbW9uL2tlcm5lbC5jCj4gKysrIGIveGVuL2NvbW1vbi9rZXJuZWwuYwo+IEBAIC0y
Myw5ICsyMywxMSBAQCBlbnVtIHN5c3RlbV9zdGF0ZSBzeXN0ZW1fc3RhdGUgPSBTWVNfU1RBVEVf
ZWFybHlfYm9vdDsKPiAgeGVuX2NvbW1hbmRsaW5lX3Qgc2F2ZWRfY21kbGluZTsKPiAgc3RhdGlj
IGNvbnN0IGNoYXIgX19pbml0Y29uc3Qgb3B0X2J1aWx0aW5fY21kbGluZVtdID0gQ09ORklHX0NN
RExJTkU7Cj4gIAo+IC1zdGF0aWMgdm9pZCBfX2luaXQgYXNzaWduX2ludGVnZXJfcGFyYW0oCj4g
K3N0YXRpYyBpbnQgX19pbml0IGFzc2lnbl9pbnRlZ2VyX3BhcmFtKAo+ICAgICAgY29uc3Qgc3Ry
dWN0IGtlcm5lbF9wYXJhbSAqcGFyYW0sIHVpbnQ2NF90IHZhbCkKPiAgewo+ICsgICAgdW5zaWdu
ZWQgaW50IGJpdHMgPSBwYXJhbS0+bGVuICogQklUU19QRVJfQllURTsKPiArCj4gICAgICBzd2l0
Y2ggKCBwYXJhbS0+bGVuICkKPiAgICAgIHsKPiAgICAgIGNhc2Ugc2l6ZW9mKHVpbnQ4X3QpOgo+
IEBAIC00MywxNCArNDUsMTcgQEAgc3RhdGljIHZvaWQgX19pbml0IGFzc2lnbl9pbnRlZ2VyX3Bh
cmFtKAo+ICAgICAgZGVmYXVsdDoKPiAgICAgICAgICBCVUcoKTsKPiAgICAgIH0KPiArCj4gKyAg
ICByZXR1cm4gKCAodmFsICYgKH4wVUxMIDw8IGJpdHMpKSAmJiB+KHZhbCB8ICh+MFVMTCA+PiAo
NjUgLSBiaXRzKSkpICkgPwoKVGhlIGxlZnQgcGFydCBoYXMgdW5kZWZpbmVkIGJlaGF2aW9yIHdo
ZW4gcGFyYW0tPmxlbiA9PSA4CihhbmQgb24geDg2IEknZCBleHBlY3QgaXQgdG8gcHJvZHVjZSBq
dXN0ICJ2YWwiKS4gVGhlIHJpZ2h0IHBhcnQKSSBndWVzcyBpcyBtZWFudCB0byBiZSBhIHNpZ24g
Y2hlY2ssIGJ1dCB0aGF0J3MgcmF0aGVyIG9ic2N1cmUuCkFzIGlpcmMgaXQgaXMgc2lnbmVkLXRv
LXVuc2lnbmVkIGNvbnZlcnNpb24gd2hpY2ggaGFzIHVuaWZvcm1seQpkZWZpbmVkIGJlaGF2aW9y
IGl0IG1heSBlbmQgdXAgYmVpbmcgYmV0dGVyIGZvciB0aGUgcGFyYW1ldGVyCnRvIGJlIG9mIHNp
Z25lZCB0eXBlIGFuZCB0byBhbGxvdyB2YWx1ZXMgaW4gdGhlIHJhbmdlCls8dHlwZT5fTUlOLFU8
dHlwZT5fTUFYXS4gQW55dGhpbmcgbW9yZSBwcmVjaXNlIHdvdWxkCnJlcXVpcmUgc2lnbmVkbmVz
cyB0byBiZSBjb21tdW5pY2F0ZWQgZnJvbSB0aGUgKl9wYXJhbSgpCnVzZXJzLgoKQWxzbyAtIHN0
cmF5IGJsYW5rcyBpbnNpZGUgdGhlIG91dGVybW9zdCBwYXJlbnRoZXNlcy4KCkFuZCBmaW5hbGx5
LCB3b3VsZG4ndCBpdCBiZSBiZXR0ZXIgdG8gY2hlY2sgZm9yIG92ZXJmbG93IF9iZWZvcmVfCmFz
c2lnbmluZyB0byAqcGFyYW0tPnZhcj8KCj4gQEAgLTk3LDggKzEwMiw5IEBAIHN0YXRpYyB2b2lk
IF9faW5pdCBfY21kbGluZV9wYXJzZShjb25zdCBjaGFyICpjbWRsaW5lKQo+ICAgICAgICAgICAg
ICAgICAgICAgICAhc3RybmNtcChwYXJhbS0+bmFtZSwgb3B0LCBxICsgMSAtIG9wdCkgKQo+ICAg
ICAgICAgICAgICAgICAgewo+ICAgICAgICAgICAgICAgICAgICAgIG9wdHZhbFstMV0gPSAnPSc7
Cj4gLSAgICAgICAgICAgICAgICAgICAgKCh2b2lkICgqKShjb25zdCBjaGFyICopKXBhcmFtLT52
YXIpKHEpOwo+ICsgICAgICAgICAgICAgICAgICAgIHJjID0gKChpbnQgKCopKGNvbnN0IGNoYXIg
KikpcGFyYW0tPnZhcikocSk7CgpOZWl0aGVyIGhlcmUgbm9yIGluIHRoZSBlYXJsaWVyICJsZXQg
Y3VzdG9tIHBhcmFtZXRlciBwYXJzaW5nCnJvdXRpbmVzIHJldHVybiBlcnJubyIgbm9yIGluIHRo
ZSBvdmVydmlldyB5b3UgbWVudGlvbiB3aHkgdGhpcwppcyBzYWZlIC0gaXQgaXMgbm90IGEgZ2l2
ZW4gdGhhdCBjYWxsZXIgYW5kIGNhbGxlZSBkaXNhZ3JlZWluZyBvbgpyZXR1cm4gdHlwZSBpcyBn
b2luZyB0byB3b3JrLiBKdXN0IHRoaW5rIG9mIGZ1bmN0aW9ucyByZXR1cm5pbmcKYWdncmVnYXRl
cyBvciAob24gaXg4Nikgb25lcyByZXR1cm5pbmcgZmxvYXRpbmcgcG9pbnQgdmFsdWVzIGluCnN0
KDApLgoKPiAgICAgICAgICAgICAgICAgICAgICBvcHR2YWxbLTFdID0gJ1wwJzsKPiArICAgICAg
ICAgICAgICAgICAgICBicmVhazsKCldoeT8gQXBwbGllcyB0byBmdXJ0aGVyIGJyZWFrLXMgeW91
IGFkZDogQXQgbGVhc3QgaW4gdGhlIHBhc3Qgd2UKaGFkIGNvbW1hbmQgbGluZSBvcHRpb25zIHdp
dGggdHdvIGhhbmRsZXJzLCB3aGVyZSBlYWNoIG9mIHRoZW0KbmVlZGVkIHRvIGJlIGludm9rZWQu
IEkgZG9uJ3QgdGhpbmsgd2Ugc2hvdWxkIG1ha2Ugc3VjaCBpbXBvc3NpYmxlCmV2ZW4gaWYgcmln
aHQgbm93IHRoZXJlIGFyZW4ndCBhbnkgc3VjaCBleGFtcGxlcy4gWWV0IGlmIHlvdSByZWFsbHkK
bWVhbiB0bywgdGhlbiB0aGUgYmVoYXZpb3JhbCBjaGFuZ2UgbmVlZHMgdG8gYmUgY2FsbGVkIG91
dCBpbiB0aGUKZGVzY3JpcHRpb24uCgo+IEBAIC0xMDYsMjQgKzExMiwzNCBAQCBzdGF0aWMgdm9p
ZCBfX2luaXQgX2NtZGxpbmVfcGFyc2UoY29uc3QgY2hhciAqY21kbGluZSkKPiAgICAgICAgICAg
ICAgc3dpdGNoICggcGFyYW0tPnR5cGUgKQo+ICAgICAgICAgICAgICB7Cj4gICAgICAgICAgICAg
IGNhc2UgT1BUX1NUUjoKPiArICAgICAgICAgICAgICAgIHJjID0gMDsKPiAgICAgICAgICAgICAg
ICAgIHN0cmxjcHkocGFyYW0tPnZhciwgb3B0dmFsLCBwYXJhbS0+bGVuKTsKPiAgICAgICAgICAg
ICAgICAgIGJyZWFrOwo+ICAgICAgICAgICAgICBjYXNlIE9QVF9VSU5UOgo+IC0gICAgICAgICAg
ICAgICAgYXNzaWduX2ludGVnZXJfcGFyYW0oCj4gKyAgICAgICAgICAgICAgICByYyA9IGFzc2ln
bl9pbnRlZ2VyX3BhcmFtKAo+ICAgICAgICAgICAgICAgICAgICAgIHBhcmFtLAo+IC0gICAgICAg
ICAgICAgICAgICAgIHNpbXBsZV9zdHJ0b2xsKG9wdHZhbCwgTlVMTCwgMCkpOwo+ICsgICAgICAg
ICAgICAgICAgICAgIHNpbXBsZV9zdHJ0b2xsKG9wdHZhbCwgJnMsIDApKTsKPiArICAgICAgICAg
ICAgICAgIGlmICggKnMgKQo+ICsgICAgICAgICAgICAgICAgICAgIHJjID0gLUVJTlZBTDsKPiAg
ICAgICAgICAgICAgICAgIGJyZWFrOwo+ICAgICAgICAgICAgICBjYXNlIE9QVF9CT09MOgo+IC0g
ICAgICAgICAgICAgICAgaWYgKCAhcGFyc2VfYm9vbChvcHR2YWwpICkKPiArICAgICAgICAgICAg
ICAgIHJjID0gcGFyc2VfYm9vbChvcHR2YWwpOwo+ICsgICAgICAgICAgICAgICAgaWYgKCByYyA9
PSAtMSApCgpNYXliZSAicmMgPCAwIj8KCj4gQEAgLTEzMSwxMyArMTQ3LDIxIEBAIHN0YXRpYyB2
b2lkIF9faW5pdCBfY21kbGluZV9wYXJzZShjb25zdCBjaGFyICpjbWRsaW5lKQo+ICAgICAgICAg
ICAgICAgICAgICAgIHNhZmVfc3RyY3B5KG9wdCwgIm5vIik7Cj4gICAgICAgICAgICAgICAgICAg
ICAgb3B0dmFsID0gb3B0Owo+ICAgICAgICAgICAgICAgICAgfQo+IC0gICAgICAgICAgICAgICAg
KCh2b2lkICgqKShjb25zdCBjaGFyICopKXBhcmFtLT52YXIpKG9wdHZhbCk7Cj4gKyAgICAgICAg
ICAgICAgICByYyA9ICgoaW50ICgqKShjb25zdCBjaGFyICopKXBhcmFtLT52YXIpKG9wdHZhbCk7
Cj4gICAgICAgICAgICAgICAgICBicmVhazsKPiAgICAgICAgICAgICAgZGVmYXVsdDoKPiAgICAg
ICAgICAgICAgICAgIEJVRygpOwo+ICAgICAgICAgICAgICAgICAgYnJlYWs7Cj4gICAgICAgICAg
ICAgIH0KPiArCj4gKyAgICAgICAgICAgIGJyZWFrOwo+ICAgICAgICAgIH0KPiArCj4gKyAgICAg
ICAgaWYgKCByYyApCj4gKyAgICAgICAgICAgIHByaW50aygicGFyYW1ldGVyIFwiJXNcIiBoYXMg
aW52YWxpZCB2YWx1ZSBcIiVzXCIhXG4iLCBvcHRrZXksCj4gKyAgICAgICAgICAgICAgICAgICBv
cHR2YWwpOwoKV2l0aCB0aGUgY2hhbmdlcyBtYWRlIHRvIG9wdHZhbCBpbiBPUFRfQ1VTVE9NIGhh
bmRsaW5nIHRoaXMKbWF5IGVuZCB1cCBiZWluZyBjb25mdXNpbmcuCgpKYW4KCgpfX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBs
aXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2
ZWwK