From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 1/3] mem: fix hugepage mapping error messages Date: Wed, 05 Oct 2016 11:51:48 +0200 Message-ID: <5999446.HPKiItx4sF@xps13> References: <20160921211049.GA27472@labs.hpe.com> <20161004171703.GA3053@labs.hpe.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Sergio Gonzalez Monroy , dev@dpdk.org To: jean.tourrilhes@hpe.com Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id C1A3E7F00 for ; Wed, 5 Oct 2016 11:51:51 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id f193so218222369wmg.0 for ; Wed, 05 Oct 2016 02:51:51 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-10-04 20:07, Sergio Gonzalez Monroy: > On 04/10/2016 18:17, Jean Tourrilhes wrote: > > Running secondary is tricky due to the need to map the memory region > > at the right place in VM, which is whatever primary has chosen. If the > > base address for primary happens to by already mapped in the > > secondary, we will hit precisely these error messages (depending if we > > fail on the config region or the hugepages). This is why there is > > already a comment about ASLR. > > > > The issue is that in most cases, remapping does not happen and "errno" > > is not changed and therefore stale. In our case, we got a "permission > > denied", which sent us down the wrong track. It's such a common error > > for secondary that I feel this error message should be unambiguous and > > helpful. > > The call to close was also moved because close() may override errno. > > > > Signed-off-by: Jean Tourrilhes > > --- > > lib/librte_eal/linuxapp/eal/eal.c | 14 +++++++++++--- > > lib/librte_eal/linuxapp/eal/eal_memory.c | 16 ++++++++++++---- > > 2 files changed, 23 insertions(+), 7 deletions(-) > > Acked-by: Sergio Gonzalez Monroy Applied, thanks A rebase was necessary because of this patch: http://dpdk.org/commit/c00ae961 Please check everything is OK.