All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wols Lists <antlists@youngman.org.uk>
To: Mikael Abrahamsson <swmike@swm.pp.se>,
	Gionatan Danti <g.danti@assyoma.it>
Cc: Linux RAID <linux-raid@vger.kernel.org>
Subject: Re: Filesystem corruption on RAID1
Date: Sun, 20 Aug 2017 14:07:00 +0100	[thread overview]
Message-ID: <59998974.60103@youngman.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.20.1708201241400.3655@uplift.swm.pp.se>

On 20/08/17 11:43, Mikael Abrahamsson wrote:
> On Sun, 20 Aug 2017, Gionatan Danti wrote:
> 
>> It can be even worse: if fsck reads from the disks with corrupted data
>> and tries to repair based on these corrupted information, it can blow
>> up the filesystem completely.
> 
> Indeed, but as far as I know there is nothing md can do about this. What
> md could do about it is at least present a consistent view of data to
> fsck (which for raid1 would be read all stripes and issue "repair" if
> they don't match). Yes, this might indeed cause corruption but at least
> it would be consistent and visible.
> 
Which is exactly what my "force integrity check on read" proposal would
have achieved, but that generated so much heat and argument IN FAVOUR of
returning possibly corrupt data that I'll probably get flamed to high
heaven if I bring it back up again. Yes, the performance hit is probably
awful, yes it can only fix things if it's got raid-6 or a 3-disk-or-more
raid-1 array, but the idea was that if you knew or suspected something
was wrong, this would force a read error somewhere in the stack if the
raid wasn't consistent.

Switching it on then running your fsck might trash chunks of the
filesystem, but at least (a) it would be known to be consistent
afterwards, and (b) you'd know what had been trashed!

Cheers,
Wol

  reply	other threads:[~2017-08-20 13:07 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-13 15:35 Filesystem corruption on RAID1 Gionatan Danti
2017-07-13 16:48 ` Roman Mamedov
2017-07-13 21:28   ` Gionatan Danti
2017-07-13 21:34     ` Reindl Harald
2017-07-13 22:34       ` Gionatan Danti
2017-07-14  0:32         ` Reindl Harald
2017-07-14  0:52           ` Anthony Youngman
2017-07-14  1:10             ` Reindl Harald
2017-07-14 10:46           ` Gionatan Danti
2017-07-14 10:58             ` Reindl Harald
2017-08-17  8:23             ` Gionatan Danti
2017-08-17 12:41               ` Roger Heflin
2017-08-17 14:31                 ` Gionatan Danti
2017-08-17 17:33                   ` Wols Lists
2017-08-17 20:50                     ` Gionatan Danti
2017-08-17 21:01                       ` Roger Heflin
2017-08-17 21:21                         ` Gionatan Danti
2017-08-17 21:23                           ` Gionatan Danti
2017-08-17 22:51                       ` Wols Lists
2017-08-18 12:26                         ` Gionatan Danti
2017-08-18 12:54                           ` Roger Heflin
2017-08-18 19:42                             ` Gionatan Danti
2017-08-20  7:14                               ` Mikael Abrahamsson
2017-08-20  7:24                                 ` Gionatan Danti
2017-08-20 10:43                                   ` Mikael Abrahamsson
2017-08-20 13:07                                     ` Wols Lists [this message]
2017-08-20 15:38                                       ` Adam Goryachev
2017-08-20 15:48                                         ` Mikael Abrahamsson
2017-08-20 16:10                                           ` Wols Lists
2017-08-20 23:11                                             ` Adam Goryachev
2017-08-21 14:03                                               ` Anthony Youngman
2017-08-20 19:11                                           ` Gionatan Danti
2017-08-20 19:03                                         ` Gionatan Danti
2017-08-20 19:01                                       ` Gionatan Danti
2017-08-31 22:55                                     ` Robert L Mathews
2017-09-01  5:39                                       ` Reindl Harald
2017-09-01 23:14                                         ` Robert L Mathews
2017-08-20 23:22                                 ` Chris Murphy
2017-08-21  5:57                                   ` Gionatan Danti
2017-08-21  8:37                                   ` Mikael Abrahamsson
2017-08-21 12:28                                     ` Gionatan Danti
2017-08-21 14:09                                       ` Anthony Youngman
2017-08-21 17:33                                     ` Chris Murphy
2017-08-21 17:52                                       ` Reindl Harald
2017-07-14  1:48         ` Chris Murphy
2017-07-14  7:22           ` Roman Mamedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59998974.60103@youngman.org.uk \
    --to=antlists@youngman.org.uk \
    --cc=g.danti@assyoma.it \
    --cc=linux-raid@vger.kernel.org \
    --cc=swmike@swm.pp.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.