All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>,
	"Lan Tianyu" <tianyu.lan@intel.com>
Cc: kevin.tian@intel.com, wei.liu2@citrix.com,
	andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com,
	xen-devel@lists.xen.org, chao.gao@intel.com
Subject: Re: [RFC PATCH 3/5] Tool/ACPI: DSDT extension to support more vcpus
Date: Fri, 25 Aug 2017 06:01:36 -0600	[thread overview]
Message-ID: <59A02DC00200007800173BD7@prv-mh.provo.novell.com> (raw)
In-Reply-To: <20170825103633.d34u2vscrme4uypx@MacBook-Pro-de-Roger.local>

>>> On 25.08.17 at 12:36, <roger.pau@citrix.com> wrote:
> On Thu, Aug 24, 2017 at 10:52:18PM -0400, Lan Tianyu wrote:
>> This patch is to change DSDT table for processor object to support >255 
> vcpus.
> 
> The note in ACPI 6.1A spec section 5.2.12.12 contains the following:
> 
> [Compatibility note] On some legacy OSes, Logical processors with APIC
> ID values less than 255 (whether in XAPIC or X2APIC mode) must use the
> Processor Local APIC structure to convey their APIC information to
> OSPM, and those processors must be declared in the DSDT using the
> Processor() keyword. Logical processors with APIC ID values 255 and
> greater must use the Processor Local x2APIC structure and be declared
> using the Device() keyword. See Section 19.6.102 "Processor (Declare
> Processor)" for more information.
> 
> So you cannot unconditionally switch to using the Device for all
> processors.
> 
> vCPUs <= 128 need to use the Processor keyword, while vCPUs > 128 need
> to use the Device keyword.

While changing this code, may I suggest to stop referring to the
128 vCPU boundary? The decision should be solely based on
LAPIC ID, such that the only place to change later on will end up
being the one where it gets set to double the vCPU number.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-08-25 12:01 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-25  2:52 [RFC PATCH 0/5] Extend resources to support more vcpus in single VM Lan Tianyu
2017-08-25  2:52 ` [RFC PATCH 1/5] xen/hap: Increase hap size for more vcpus support Lan Tianyu
2017-08-25  9:14   ` Wei Liu
2017-08-28  8:53     ` Lan, Tianyu
2017-08-25  2:52 ` [RFC PATCH 2/5] XL: Increase event channels to support more vcpus Lan Tianyu
2017-08-25  9:18   ` Wei Liu
2017-08-25  9:57     ` Roger Pau Monné
2017-08-25 10:04       ` Wei Liu
2017-08-28  9:11         ` Lan, Tianyu
2017-08-28  9:21           ` Wei Liu
2017-08-28  9:22           ` Jan Beulich
2017-08-25  2:52 ` [RFC PATCH 3/5] Tool/ACPI: DSDT extension " Lan Tianyu
2017-08-25  9:25   ` Wei Liu
2017-08-28  9:12     ` Lan, Tianyu
2017-08-25 10:36   ` Roger Pau Monné
2017-08-25 12:01     ` Jan Beulich [this message]
2017-08-29  4:58       ` Lan Tianyu
2017-08-29  5:01     ` Lan Tianyu
2017-08-25  2:52 ` [RFC PATCH 4/5] hvmload: Add x2apic entry support in the MADT build Lan Tianyu
2017-08-25  9:26   ` Wei Liu
2017-08-25  9:43     ` Jan Beulich
2017-08-25 10:11   ` Roger Pau Monné
2017-08-29  3:14     ` Lan Tianyu
2017-08-25  2:52 ` [RFC PATCH 5/5] xl/libacpi: extend lapic_id() to uint32_t Lan Tianyu
2017-08-25  9:22   ` Wei Liu
2017-08-25 14:10 ` [RFC PATCH 0/5] Extend resources to support more vcpus in single VM Meng Xu
2017-08-29  4:38   ` Lan Tianyu
2017-08-29  8:49     ` Jan Beulich
2017-08-30  5:33       ` Lan Tianyu
2017-08-30  7:12         ` Jan Beulich
2017-08-30  9:18           ` George Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59A02DC00200007800173BD7@prv-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=chao.gao@intel.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=kevin.tian@intel.com \
    --cc=roger.pau@citrix.com \
    --cc=tianyu.lan@intel.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.