From: David Hildenbrand <david@redhat.com>
To: Oscar Salvador <osalvador@suse.de>
Cc: David Hildenbrand <david@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@kernel.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Pavel Tatashin <pasha.tatashin@soleen.com>,
Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/8] mm,memory_hotplug: Relax fully spanned sections check
Date: Tue, 6 Apr 2021 22:43:01 +0200 [thread overview]
Message-ID: <59A04B1D-08D6-4E71-A382-F5503A6E0AF7@redhat.com> (raw)
In-Reply-To: <df9bdb5157d6ad2f4a922d396ddf0c07@suse.de>
> Am 06.04.2021 um 18:34 schrieb Oscar Salvador <osalvador@suse.de>:
>
> On 2021-04-06 17:32, David Hildenbrand wrote:
>> I'd only relax start_pfn. That way the function is pretty much
>> impossible to abuse for sub-section onlining/offlining.
>> if (WARN_ON_ONCE(!nr_pages ||
>> !IS_ALIGNED(start_pfn, pageblock_nr_pages))
>> !IS_ALIGNED(start_pfn + nr_pages, PAGES_PER_SECTION)))
>
> But this is not going to work.
> When using memmap_on_memory, the nr of pages that online_pages() and offline_pages() get might be less than PAGES_PER_SECTION, so this check will always blow us up.
But not end_pfn as given in my version or what am I missing?
> --
> Oscar Salvador
> SUSE L3
>
next prev parent reply other threads:[~2021-04-06 20:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 11:11 [PATCH v6 0/8] Allocate memmap from hotadded memory (per device) Oscar Salvador
2021-04-06 11:11 ` [PATCH v6 1/8] drivers/base/memory: Introduce memory_block_{online,offline} Oscar Salvador
2021-04-06 11:11 ` [PATCH v6 2/8] mm,memory_hotplug: Relax fully spanned sections check Oscar Salvador
2021-04-06 15:32 ` David Hildenbrand
2021-04-06 16:33 ` Oscar Salvador
2021-04-06 20:43 ` David Hildenbrand [this message]
2021-04-07 7:42 ` Oscar Salvador
2021-04-07 7:43 ` David Hildenbrand
2021-04-06 11:11 ` [PATCH v6 3/8] mm,memory_hotplug: Factor out adjusting present pages into adjust_present_page_count() Oscar Salvador
2021-04-06 15:33 ` David Hildenbrand
2021-04-07 7:11 ` Oscar Salvador
2021-04-06 11:11 ` [PATCH v6 4/8] mm,memory_hotplug: Allocate memmap from the added memory range Oscar Salvador
2021-04-06 17:10 ` kernel test robot
2021-04-06 17:10 ` [PATCH v6 4/8] mm, memory_hotplug: " kernel test robot
2021-04-06 20:28 ` [PATCH v6 4/8] mm,memory_hotplug: " Oscar Salvador
2021-04-07 20:38 ` Oscar Salvador
2021-04-09 5:05 ` Andrew Morton
2021-04-09 5:10 ` Oscar Salvador
2021-04-09 8:10 ` David Hildenbrand
2021-04-06 11:11 ` [PATCH v6 5/8] acpi,memhotplug: Enable MHP_MEMMAP_ON_MEMORY when supported Oscar Salvador
2021-04-06 11:11 ` [PATCH v6 6/8] mm,memory_hotplug: Add kernel boot option to enable memmap_on_memory Oscar Salvador
2021-04-06 11:11 ` [PATCH v6 7/8] x86/Kconfig: Introduce ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE Oscar Salvador
2021-04-06 11:11 ` [PATCH v6 8/8] arm64/Kconfig: " Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59A04B1D-08D6-4E71-A382-F5503A6E0AF7@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@soleen.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.