From: "Jan Beulich" <JBeulich@suse.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
IanJackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Daniel de Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH v3] passthrough: give XEN_DOMCTL_test_assign_device more sane semantics
Date: Fri, 25 Aug 2017 10:00:14 -0600 [thread overview]
Message-ID: <59A065AE0200007800173F4C@prv-mh.provo.novell.com> (raw)
In-Reply-To: <59A0644A0200007800173F2D@prv-mh.provo.novell.com>
>>> On 25.08.17 at 17:54, <JBeulich@suse.com> wrote:
>>>> On 25.08.17 at 17:25, <wei.liu2@citrix.com> wrote:
>> On Wed, Aug 16, 2017 at 06:20:01AM -0600, Jan Beulich wrote:
>>> So far callers of the libxc interface passed in a domain ID which was
>>> then ignored in the hypervisor. Instead, make the hypervisor honor it
>>> (accepting DOMID_INVALID to obtain original behavior), allowing to
>>> query whether a device can be assigned to a particular domain.
>>>
>>> Drop XSM's test_assign_{,dt}device hooks as no longer being
>>> individually useful.
>>
>> Can you also say in the commit message that you consolidate some code as
>> well?
>
> Am I consolidating code beyond what is reasonable to achieve
> the intended effect? I don't view the merging of the two case
> blocks
Oops, didn't finish here: "... as anything going beyond the main
purpose of the patch. In fact if someone submitted a patch
without doing that folding, I'd ask for it to be done."
>> Assuming the disagreement on the semantics of the call is settled:
>>
>> Reviewed-by: Wei Liu <wei.liu2@citrix.com>
And didn't say "thanks" here.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-08-25 16:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 12:20 [PATCH v3] passthrough: give XEN_DOMCTL_test_assign_device more sane semantics Jan Beulich
2017-08-16 14:22 ` Daniel De Graaf
2017-08-25 14:58 ` Ping: " Jan Beulich
2017-08-25 15:25 ` Wei Liu
2017-08-25 15:54 ` Jan Beulich
2017-08-25 16:00 ` Jan Beulich [this message]
2017-08-25 16:05 ` [PATCH v3] passthrough: give XEN_DOMCTL_test_assign_device more sane semantics (and 1 more message) Wei Liu
2017-08-28 7:27 ` Jan Beulich
2017-08-28 15:39 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59A065AE0200007800173F4C@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.