From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751811AbdH1KKo (ORCPT ); Mon, 28 Aug 2017 06:10:44 -0400 Received: from mga06.intel.com ([134.134.136.31]:8814 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751456AbdH1KKm (ORCPT ); Mon, 28 Aug 2017 06:10:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,441,1498546800"; d="scan'208";a="1166761156" Subject: Re: [PATCH] Revert "xhci: Limit USB2 port wake support for AMD Promontory hosts" To: Greg KH , Kai-Heng Feng References: <20170822091447.19126-1-kai.heng.feng@canonical.com> <20170828092959.GA24193@kroah.com> Cc: mathias.nyman@intel.com, Lars_Chang@asmedia.com.tw, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Tsai, Nicholas" , Nehal Shah , Ramkumar Subramaniyan From: Mathias Nyman Message-ID: <59A3ECF2.8050406@linux.intel.com> Date: Mon, 28 Aug 2017 13:14:10 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20170828092959.GA24193@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.08.2017 12:29, Greg KH wrote: > On Tue, Aug 22, 2017 at 05:14:47PM +0800, Kai-Heng Feng wrote: >> This reverts commit dec08194ffeccfa1cf085906b53d301930eae18f. >> >> Commit dec08194ffec ("xhci: Limit USB2 port wake support for AMD Promontory >> hosts") makes all high speed USB ports on ASUS PRIME B350M-A cease to >> function after enabling runtime PM. >> >> All boards with this chipsets will be affected, so revert the commit. >> >> Conflicts: >> drivers/usb/host/xhci-pci.c >> drivers/usb/host/xhci.h > > Why are these "Conflicts:" lines here, you did fix up the issues, so > there shouldn't be any more conflicts. > > And if you revert this, don't we still have the original problem here? > Adding more people who were involved in the original patch. Users are now seeing the unresponsive USB2 ports with Promontory hosts. Is there any update on a better way to solve the original issue. To me a "dead" USB2 port seems like a much worse issue for a user than a BIOS disabled port waking up on plug/unplug (wake on connect/disconnect), so I'm myself in favor of doing this revert. But there was a strong push from Promontory developers to get the original fix in, and I would like to get some comment from them before I do anything about it. Thanks -Mathias