From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH 5/5] mm: Don't hold heap lock in alloc_heap_pages() longer than necessary Date: Wed, 30 Aug 2017 04:22:41 -0600 Message-ID: <59A6AE11020000780017576B@prv-mh.provo.novell.com> References: <1504026557-11365-1-git-send-email-boris.ostrovsky@oracle.com> <1504026557-11365-6-git-send-email-boris.ostrovsky@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Andrew Cooper , Boris Ostrovsky Cc: sstabellini@kernel.org, wei.liu2@citrix.com, George.Dunlap@eu.citrix.com, tim@xen.org, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Pj4+IE9uIDMwLjA4LjE3IGF0IDExOjI3LCA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3Jv dGU6Cj4gT24gMjkvMDgvMTcgMTg6MDksIEJvcmlzIE9zdHJvdnNreSB3cm90ZToKPj4gT25jZSBw YWdlcyBhcmUgcmVtb3ZlZCBmcm9tIHRoZSBoZWFwIHdlIGRvbid0IG5lZWQgdG8gaG9sZCB0aGUg aGVhcAo+PiBsb2NrLiBJdCBpcyBlc3BlY2lhbGx5IHVzZWZ1bCB0byBkcm9wIGl0IGZvciBhbiB1 bnNjcnViYmVkIGJ1ZGR5IHNpbmNlCj4+IHdlIHdpbGwgYmUgc2NydWJiaW5nIGl0Lgo+Pgo+PiBT aWduZWQtb2ZmLWJ5OiBCb3JpcyBPc3Ryb3Zza3kgPGJvcmlzLm9zdHJvdnNreUBvcmFjbGUuY29t Pgo+PiBSZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgo+PiAtLS0K Pj4gQ2hhbmdlcyBpbiB2MjoKPj4gKiBNb3ZlZCBzcGluX3VubG9jaygpIGFmdGVyIGQtPmxhc3Rf YWxsb2Nfbm9kZSBhc3NpZ25tZW50Cj4+Cj4+ICB4ZW4vY29tbW9uL3BhZ2VfYWxsb2MuYyB8IDcg KysrKysrLQo+PiAgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigt KQo+Pgo+PiBkaWZmIC0tZ2l0IGEveGVuL2NvbW1vbi9wYWdlX2FsbG9jLmMgYi94ZW4vY29tbW9u L3BhZ2VfYWxsb2MuYwo+PiBpbmRleCA2YzA4OTgzLi44ZGY5MmFhIDEwMDY0NAo+PiAtLS0gYS94 ZW4vY29tbW9uL3BhZ2VfYWxsb2MuYwo+PiArKysgYi94ZW4vY29tbW9uL3BhZ2VfYWxsb2MuYwo+ PiBAQCAtODYwLDYgKzg2MCw3IEBAIHN0YXRpYyBzdHJ1Y3QgcGFnZV9pbmZvICphbGxvY19oZWFw X3BhZ2VzKAo+PiAgICAgIHN0cnVjdCBwYWdlX2luZm8gKnBnOwo+PiAgICAgIGJvb2wgbmVlZF90 bGJmbHVzaCA9IGZhbHNlOwo+PiAgICAgIHVpbnQzMl90IHRsYmZsdXNoX3RpbWVzdGFtcCA9IDA7 Cj4+ICsgICAgdW5zaWduZWQgaW50IGRpcnR5X2NudCA9IDA7Cj4+ICAKPj4gICAgICAvKiBNYWtl IHN1cmUgdGhlcmUgYXJlIGVub3VnaCBiaXRzIGluIG1lbWZsYWdzIGZvciBub2RlSUQuICovCj4+ ICAgICAgQlVJTERfQlVHX09OKChfTUVNRl9iaXRzIC0gX01FTUZfbm9kZSkgPCAoOCAqIHNpemVv Zihub2RlaWRfdCkpKTsKPj4gQEAgLTk0OCw2ICs5NDksOCBAQCBzdGF0aWMgc3RydWN0IHBhZ2Vf aW5mbyAqYWxsb2NfaGVhcF9wYWdlcygKPj4gICAgICBpZiAoIGQgIT0gTlVMTCApCj4+ICAgICAg ICAgIGQtPmxhc3RfYWxsb2Nfbm9kZSA9IG5vZGU7Cj4+ICAKPj4gKyAgICBzcGluX3VubG9jaygm aGVhcF9sb2NrKTsKPj4gKwo+PiAgICAgIGZvciAoIGkgPSAwOyBpIDwgKDEgPDwgb3JkZXIpOyBp KysgKQo+PiAgICAgIHsKPj4gICAgICAgICAgLyogUmVmZXJlbmNlIGNvdW50IG11c3QgY29udGlu dW91c2x5IGJlIHplcm8gZm9yIGZyZWUgcGFnZXMuICovCj4+IEBAIC05NTcsNyArOTYwLDcgQEAg c3RhdGljIHN0cnVjdCBwYWdlX2luZm8gKmFsbG9jX2hlYXBfcGFnZXMoCj4+ICAgICAgICAgIHsK Pj4gICAgICAgICAgICAgIGlmICggIShtZW1mbGFncyAmIE1FTUZfbm9fc2NydWIpICkKPj4gICAg ICAgICAgICAgICAgICBzY3J1Yl9vbmVfcGFnZSgmcGdbaV0pOwo+PiAtICAgICAgICAgICAgbm9k ZV9uZWVkX3NjcnViW25vZGVdLS07Cj4+ICsgICAgICAgICAgICBkaXJ0eV9jbnQrKzsKPj4gICAg ICAgICAgfQo+PiAgCj4+ICAgICAgICAgIHBnW2ldLmNvdW50X2luZm8gPSBQR0Nfc3RhdGVfaW51 c2U7Cj4+IEBAIC05NzksNiArOTgyLDggQEAgc3RhdGljIHN0cnVjdCBwYWdlX2luZm8gKmFsbG9j X2hlYXBfcGFnZXMoCj4+ICAgICAgICAgICAgICBjaGVja19vbmVfcGFnZSgmcGdbaV0pOwo+PiAg ICAgIH0KPj4gIAo+PiArICAgIHNwaW5fbG9jaygmaGVhcF9sb2NrKTsKPj4gKyAgICBub2RlX25l ZWRfc2NydWJbbm9kZV0gLT0gZGlydHlfY250Owo+PiAgICAgIHNwaW5fdW5sb2NrKCZoZWFwX2xv Y2spOwo+PiAgCj4+ICAgICAgaWYgKCBuZWVkX3RsYmZsdXNoICkKPiAKPiBUaGlzIHBhdGNoIGhh cyBiZWVuIGFwcGxpZWQgdG8gc3RhZ2luZywgYnV0IGl0cyBnb3QgcHJvYmxlbXMuICBUaGUKPiBm b2xsb3dpbmcgY3Jhc2ggaXMgcmF0aGVyIHRyaXZpYWwgdG8gcHJvdm9rZToKPiAKPiB+QW5kcmV3 Cj4gCj4gKGQxOSkgVGVzdCByZXN1bHQ6IFNVQ0NFU1MKPiAoWEVOKSAtLS0tWyBYZW4tNC4xMC11 bnN0YWJsZSAgeDg2XzY0ICBkZWJ1Zz15ICAgVGFpbnRlZDogICAgSCBdLS0tLQo+IChYRU4pIENQ VTogICAgNQo+IChYRU4pIFJJUDogICAgZTAwODpbPGZmZmY4MmQwODAyMjUyZmM+XSBwYWdlX2Fs bG9jLmMjZnJlZV9oZWFwX3BhZ2VzKzB4Nzg2LzB4N2ExCj4uLi4KPiAoWEVOKSBQYWdldGFibGUg d2FsayBmcm9tIGZmZmY4MmZmZmZmZmZmZTQ6Cj4gKFhFTikgIEw0WzB4MTA1XSA9IDAwMDAwMDAw YWJlNWIwNjMgZmZmZmZmZmZmZmZmZmZmZgo+IChYRU4pICBMM1sweDFmZl0gPSAwMDAwMDAwMDAw MDAwMDAwIGZmZmZmZmZmZmZmZmZmZmYKClNvbWUgbmVnYXRpdmUgb2Zmc2V0IGludG8gc29tZXdo ZXJlLCBpdCBzZWVtcy4gVXBvbiBzZWNvbmQKbG9vayBJIHRoaW5rIHRoZSBwYXRjaCBpcyBzaW1w bHkgd3JvbmcgaW4gaXRzIGN1cnJlbnQgc2hhcGU6CmZyZWVfaGVhcF9wYWdlcygpIGxvb2tzIGZv ciBwYWdlX3N0YXRlX2lzKC4uLiwgZnJlZSkgd2hlbgp0cnlpbmcgdG8gbWVyZ2UgY2h1bmtzLCB3 aGlsZSBhbGxvY19oZWFwX3BhZ2VzKCkgbm93IHNldHMKUEdDX3N0YXRlX2ludXNlIG91dHNpZGUg b2YgdGhlIGxvY2tlZCBhcmVhLiBJJ2xsIHJldmVydCBpdCByaWdodAphd2F5LgoKSmFuCgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1h aWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcv eGVuLWRldmVsCg==