From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1donJM-0004pg-0g for qemu-devel@nongnu.org; Mon, 04 Sep 2017 05:05:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1donJH-0002cp-TN for qemu-devel@nongnu.org; Mon, 04 Sep 2017 05:04:52 -0400 Received: from prv-mh.provo.novell.com ([137.65.248.74]:56795) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1donJH-0002bw-L9 for qemu-devel@nongnu.org; Mon, 04 Sep 2017 05:04:47 -0400 Message-Id: <59AD3349020000780017704A@prv-mh.provo.novell.com> Date: Mon, 04 Sep 2017 03:04:41 -0600 From: "Jan Beulich" References: <59A9A6260200007800176A6A@prv-mh.provo.novell.com> <59A9A6260200007800176A6A@prv-mh.provo.novell.com> <20170901182022.2m46ussfgiwo32c5@MacBook-Pro-de-Roger.local> In-Reply-To: <20170901182022.2m46ussfgiwo32c5@MacBook-Pro-de-Roger.local> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Subject: Re: [Qemu-devel] [Xen-devel] [PATCH] xen: use vMSI related #define-s from public interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Roger=20Pau=20Monn=C3=A9?= Cc: Stefano Stabellini , xen-devel , qemu-devel@nongnu.org >>> On 01.09.17 at 20:20, wrote: > On Fri, Sep 01, 2017 at 10:25:42AM -0600, Jan Beulich wrote: >> Xen and qemu having identical #define-s (with different names) is a >> strong hint that these should have been part of the public interface >> from the very start. Use them if they're available, falling back to >> privately defined values only when using older headers. >>=20 >> Signed-off-by: Jan Beulich >=20 > Reviewed-by: Roger Pau Monn=C3=A9 Thanks. >> --- a/hw/xen/xen_pt_msi.c >> +++ b/hw/xen/xen_pt_msi.c >> @@ -18,6 +18,11 @@ >> =20 >> #define XEN_PT_AUTO_ASSIGN -1 >> =20 >> +#ifndef XEN_DOMCTL_VMSI_X86_DEST_ID_MASK >> +#if XEN_DOMCTL_INTERFACE_VERSION >=3D 0x0000000e >=20 > XEN_DOMCTL_INTERFACE_VERSION is already 0xe (without you added > defines), I guess it doesn't matter much because we only care for > stable releases. Well, that's if you build qemu against master Xen. What about people building against older Xen versions/headers? Jan From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH] xen: use vMSI related #define-s from public interface Date: Mon, 04 Sep 2017 03:04:41 -0600 Message-ID: <59AD3349020000780017704A@prv-mh.provo.novell.com> References: <59A9A6260200007800176A6A@prv-mh.provo.novell.com> <59A9A6260200007800176A6A@prv-mh.provo.novell.com> <20170901182022.2m46ussfgiwo32c5@MacBook-Pro-de-Roger.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1donKn-0004aw-Kf for xen-devel@lists.xenproject.org; Mon, 04 Sep 2017 09:06:21 +0000 In-Reply-To: <20170901182022.2m46ussfgiwo32c5@MacBook-Pro-de-Roger.local> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: =?UTF-8?Q?Roger=20Pau=20Monn=C3=A9?= Cc: xen-devel , Stefano Stabellini , qemu-devel@nongnu.org List-Id: xen-devel@lists.xenproject.org Pj4+IE9uIDAxLjA5LjE3IGF0IDIwOjIwLCA8cm9nZXIucGF1QGNpdHJpeC5jb20+IHdyb3RlOgo+ IE9uIEZyaSwgU2VwIDAxLCAyMDE3IGF0IDEwOjI1OjQyQU0gLTA2MDAsIEphbiBCZXVsaWNoIHdy b3RlOgo+PiBYZW4gYW5kIHFlbXUgaGF2aW5nIGlkZW50aWNhbCAjZGVmaW5lLXMgKHdpdGggZGlm ZmVyZW50IG5hbWVzKSBpcyBhCj4+IHN0cm9uZyBoaW50IHRoYXQgdGhlc2Ugc2hvdWxkIGhhdmUg YmVlbiBwYXJ0IG9mIHRoZSBwdWJsaWMgaW50ZXJmYWNlCj4+IGZyb20gdGhlIHZlcnkgc3RhcnQu IFVzZSB0aGVtIGlmIHRoZXkncmUgYXZhaWxhYmxlLCBmYWxsaW5nIGJhY2sgdG8KPj4gcHJpdmF0 ZWx5IGRlZmluZWQgdmFsdWVzIG9ubHkgd2hlbiB1c2luZyBvbGRlciBoZWFkZXJzLgo+PiAKPj4g U2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgo+IAo+IFJldmll d2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4KClRoYW5rcy4K Cj4+IC0tLSBhL2h3L3hlbi94ZW5fcHRfbXNpLmMKPj4gKysrIGIvaHcveGVuL3hlbl9wdF9tc2ku Ywo+PiBAQCAtMTgsNiArMTgsMTEgQEAKPj4gIAo+PiAgI2RlZmluZSBYRU5fUFRfQVVUT19BU1NJ R04gLTEKPj4gIAo+PiArI2lmbmRlZiBYRU5fRE9NQ1RMX1ZNU0lfWDg2X0RFU1RfSURfTUFTSwo+ PiArI2lmIFhFTl9ET01DVExfSU5URVJGQUNFX1ZFUlNJT04gPj0gMHgwMDAwMDAwZQo+IAo+IFhF Tl9ET01DVExfSU5URVJGQUNFX1ZFUlNJT04gaXMgYWxyZWFkeSAweGUgKHdpdGhvdXQgeW91IGFk ZGVkCj4gZGVmaW5lcyksIEkgZ3Vlc3MgaXQgZG9lc24ndCBtYXR0ZXIgbXVjaCBiZWNhdXNlIHdl IG9ubHkgY2FyZSBmb3IKPiBzdGFibGUgcmVsZWFzZXMuCgpXZWxsLCB0aGF0J3MgaWYgeW91IGJ1 aWxkIHFlbXUgYWdhaW5zdCBtYXN0ZXIgWGVuLiBXaGF0IGFib3V0CnBlb3BsZSBidWlsZGluZyBh Z2FpbnN0IG9sZGVyIFhlbiB2ZXJzaW9ucy9oZWFkZXJzPwoKSmFuCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhl bi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK