Re: [PATCH 0/4] New library: rte_distributor

["Richardson, Bruce" <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> Sent: Tuesday, May 27, 2014 11:33 PM
> To: Richardson, Bruce
> Cc: dev-VfR2kkLFssw@public.gmane.org
> Subject: Re: [dpdk-dev] [PATCH 0/4] New library: rte_distributor
> 
> Hi Bruce,
> 
> As for rte_acl, I have some formatting comments.
> 
> 2014-05-20 11:00, Bruce Richardson:
> > This adds a new library to the Intel DPDK whereby a set of packets can be
> > distributed one-at-a-time to a set of worker cores, with dynamic load
> > balancing being done between those workers. Flows are identified by a tag
> > within the mbuf (currently the RSS hash field, 32-bit value), which is used
> > to ensure that no two packets of the same flow are processed in parallel,
> > thereby preserving ordering.
> >
> >  app/test/Makefile                              |   2 +
> >  app/test/commands.c                            |   7 +-
> >  app/test/test.h                                |   2 +
> >  app/test/test_distributor.c                    | 582 +++++++++++++++++++++++++
> >  app/test/test_distributor_perf.c               | 274 ++++++++++++
> >  config/defconfig_i686-default-linuxapp-gcc     |   5 +
> >  config/defconfig_i686-default-linuxapp-icc     |   5 +
> >  config/defconfig_x86_64-default-bsdapp-gcc     |   6 +
> >  config/defconfig_x86_64-default-linuxapp-gcc   |   5 +
> >  config/defconfig_x86_64-default-linuxapp-icc   |   5 +
> >  lib/Makefile                                   |   1 +
> >  lib/librte_distributor/Makefile                |  50 +++
> >  lib/librte_distributor/rte_distributor.c       | 417 ++++++++++++++++++
> >  lib/librte_distributor/rte_distributor.h       | 173 ++++++++
> >  lib/librte_eal/common/include/rte_tailq_elem.h |   2 +
> >  mk/rte.app.mk                                  |   4 +
> >  16 files changed, 1539 insertions(+), 1 deletion(-)
> 
> As you are introducing a new library, you need to update
> doxygen configuration and start page:
>         doc/doxy-api.conf
>         doc/doxy-api-index.md

Didn't know to update those, I'll add it in to the v2 patch set.

> 
> I've run checkpatch.pl from kernel.org on these distributor patches
> and it reports some code style issues.
> Could you have a look at it please?

Yep. I've downloaded and run that patch myself in preparation for a V2 patch set (due really soon), so hopefully all should be well second time round.