From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Richardson, Bruce" <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] Add an API to query enabled core index
Date: Wed, 11 Jun 2014 21:57:03 +0000
Message-ID: <59AF69C657FD0841A61C55336867B5B01AA35210@IRSMSX103.ger.corp.intel.com>
References: <1402519509-26653-1-git-send-email-Patrick.Lu@intel.com>
 <9007853.cgh6aaULN3@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
To: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>, "Lu, Patrick"
 <patrick.lu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <9007853.cgh6aaULN3@xps13>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>



> -----Original Message-----
> From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Thomas Monjalon
> Sent: Wednesday, June 11, 2014 2:51 PM
> To: Lu, Patrick
> Cc: dev-VfR2kkLFssw@public.gmane.org
> Subject: Re: [dpdk-dev] [PATCH] Add an API to query enabled core index
>=20
> Hi,
>=20
> 2014-06-11 13:45, Patrick Lu:
> > EAL -c option allows the user to enable any lcore in the system.
> > Oftentimes, the user app wants to know 1st enabled core, 2nd
> > enabled core, etc, rather than phyical core ID (rte_lcore_id().)
> >
> > The new API rte_lcore_id2() will return an index from enabled lcores
> > starting from zero.
>=20
> I think core_id2 is not a representative name.
> What do you think of renaming core_id as lcore_hwid and core_id2 as
> lcore_index?
>=20
> --
I like lcore_index as the name for the new function. However, I'm not sure =
in that case that we want/need to rename the old one.