From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Richardson, Bruce" Subject: Re: [PATCH 1/3] stringfns: remove rte_snprintf Date: Thu, 26 Jun 2014 15:09:01 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B02CEF87D2@IRSMSX103.ger.corp.intel.com> References: <20140624090253.140206a7@nehalam.linuxnetplumber.net> <59AF69C657FD0841A61C55336867B5B02CEE3359@IRSMSX103.ger.corp.intel.com> <12214985.ClK2CaJOyY@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev-VfR2kkLFssw@public.gmane.org" To: Thomas Monjalon Return-path: In-Reply-To: <12214985.ClK2CaJOyY@xps13> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org] > Sent: Wednesday, June 25, 2014 1:33 AM > To: Richardson, Bruce > Cc: dev-VfR2kkLFssw@public.gmane.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf >=20 > 2014-06-24 17:39, Richardson, Bruce: > > From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Stephen Hemminger > > > The function rte_snprintf serves no useful purpose. It is the > > > same as snprintf() for all valid inputs. Just remove it and > > > replace all uses in current code. > > > > NAK to this as is. > > Approve of replacing all instance of the rte_snprintf function with the > > standard version in all our code and libraries. However, rather than ju= st > > removing the function completely, I think we should just flag the funct= ion > > as deprecated initially, and then later on look to remove it completely= . >=20 > I agree we should try to use the "deprecated" attribute when possible. > So application porting effort will be smoother. >=20 > But in this case, there is something different: as Stephen wrote, rte_snp= rintf > is useless. It's useless inside the DPDK so it's even more useless for us= er > applications. > As it's really useless, it has no sense to keep it as deprecated. > Please, let's simply remove it. >=20 The reason to keep it as deprecated is so that those customers who don't wa= nt to do a huge amount of search-replace immediately can get things working= again temporarily using -Wno-deprecated. It provides a simple temporary fa= llback cushion, and then we can completely remove the function later.=20 So, I'd like to see us remove all our usage of the function internally in 1= .7, along with marking as deprecated, and then completely remove in 1.8, (i= .e. in a week's time or so) :-)