From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Richardson, Bruce" Subject: Re: [PATCH 1/1] app/test: create ring and ethdevs in pmd_ring_autotest Date: Tue, 24 Nov 2015 16:30:00 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B0359881D8@IRSMSX103.ger.corp.intel.com> References: <1448292046-22682-1-git-send-email-bernard.iremonger@intel.com> <20151124161417.GA21112@bricha3-MOBL3> <8CEF83825BEC744B83065625E567D7C219F8A77B@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: "Iremonger, Bernard" Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 7FB4A8E9F for ; Tue, 24 Nov 2015 17:30:06 +0100 (CET) In-Reply-To: <8CEF83825BEC744B83065625E567D7C219F8A77B@IRSMSX108.ger.corp.intel.com> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Iremonger, Bernard > Sent: Tuesday, November 24, 2015 4:29 PM > To: Richardson, Bruce > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 1/1] app/test: create ring and ethdevs in > pmd_ring_autotest >=20 > Hi Bruce, >=20 > > -----Original Message----- > > From: Richardson, Bruce > > Sent: Tuesday, November 24, 2015 4:14 PM > > To: Iremonger, Bernard > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 1/1] app/test: create ring and ethdevs > > in pmd_ring_autotest > > > > On Mon, Nov 23, 2015 at 03:20:46PM +0000, Bernard Iremonger wrote: > > > Use command line option --vdev=3Deth_ring0 to create port 0. > > > Create two rings and five ethdevs in test_pmd_ring for ports 1 to 5. > > > Improve test output by adding the port number to printf statements, > > > and adding a printf describing each test. > > > > > > revise ring-based PMD doc to match latest ring PMD code. > > > > > > Signed-off-by: Bernard Iremonger > > > > The doc changes are not relevant to the unit test fixes, so should be > > in a separate patch. The test changes themselves are good though, and > > actually makes the test runable without having to find a very specific > > command-line incantation to make things work right. > > > > Subject to this being split into two: > > Acked-by: Bruce Richardson >=20 > Will I keep your ack on both patches when I split them? >=20 > Regards, >=20 > Bernard. >=20 Sure, feel free to. /Bruce