From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [PATCH v8 05/13] telemetry: add client feature and
 sockets
Date: Thu, 25 Oct 2018 21:16:24 +0000
Message-ID: <59AF69C657FD0841A61C55336867B5B0726BFB95@IRSMSX103.ger.corp.intel.com>
References: <20181024132725.5142-1-kevin.laatz@intel.com>
 <3330387.zQnsHCFWfj@xps>
 <20181025204424.GA4552@bricha3-MOBL.ger.corp.intel.com>
 <1823463.pdHNGopkkG@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Laatz, Kevin" <kevin.laatz@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "Van Haaren, Harry" <harry.van.haaren@intel.com>,
 "stephen@networkplumber.org" <stephen@networkplumber.org>,
 "gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>, "shreyansh.jain@nxp.com"
 <shreyansh.jain@nxp.com>, "mattias.ronnblom@ericsson.com"
 <mattias.ronnblom@ericsson.com>, Ciara Power <ciara.power@intel.com>, "Brian
 Archbold" <brian.archbold@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 6FB4A4C95
 for <dev@dpdk.org>; Thu, 25 Oct 2018 23:16:29 +0200 (CEST)
In-Reply-To: <1823463.pdHNGopkkG@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Thursday, October 25, 2018 9:50 PM
> To: Richardson, Bruce <bruce.richardson@intel.com>
> Cc: Laatz, Kevin <kevin.laatz@intel.com>; dev@dpdk.org; Van Haaren, Harry
> <harry.van.haaren@intel.com>; stephen@networkplumber.org;
> gaetan.rivet@6wind.com; shreyansh.jain@nxp.com;
> mattias.ronnblom@ericsson.com; Ciara Power <ciara.power@intel.com>; Brian
> Archbold <brian.archbold@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v8 05/13] telemetry: add client feature an=
d
> sockets
>=20
> 25/10/2018 22:44, Bruce Richardson:
> > On Thu, Oct 25, 2018 at 10:41:53PM +0200, Thomas Monjalon wrote:
> > > 25/10/2018 22:29, Thomas Monjalon:
> > > > 24/10/2018 18:03, Kevin Laatz:
> > > > > --- a/lib/librte_telemetry/meson.build
> > > > > +++ b/lib/librte_telemetry/meson.build
> > > > > @@ -5,3 +5,5 @@ sources =3D files('rte_telemetry.c')  headers =3D
> > > > > files('rte_telemetry.h', 'rte_telemetry_internal.h')  deps +=3D
> > > > > ['metrics', 'ethdev']  cflags +=3D '-DALLOW_EXPERIMENTAL_API'
> > > > > +jansson =3D cc.find_library('jansson', required: true) ext_deps
> > > > > ++=3D jansson
> > > >
> > > > I just discovered an issue when trying to compile for arm64 (with
> > > > devtools/test-meson-builds.sh):
> > > >
> > > > /usr/lib/gcc/aarch64-linux-gnu/8.2.0/../../../../aarch64-linux-
> gnu/bin/ld:
> > > > 	cannot find -ljansson
> > > >
> > > > I am worried because it is a real blocker.
> > >
> > > The dependency must be optional.
> > > Should we disable the library if jansson is not found?
> > >
> > Yes, it should be.
> >
> > Needs:
> >
> > 	jansson =3D cc.find_library('jansson', required: false)
> > 	build =3D jansson.found()
>=20
> And for the makefile?
>=20
> It has been introduced (too early) in patch 3:
> 	LDLIBS +=3D -ljansson
> I think we must use pkg-config to check if jansson is found.
>=20

I didn't look at the makefile, because you never asked! :-)