From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kumar Gala Date: Thu, 10 Sep 2009 09:41:53 -0500 Subject: [U-Boot] [PATCH v3] TQM85xx: enable partition support, sort commands In-Reply-To: <20090910115528.7A803832E8DE@gemini.denx.de> References: <1251879636-9115-1-git-send-email-wd@denx.de> <1252441753-32600-1-git-send-email-wd@denx.de> <83723583-5E4B-4A14-BF3A-2CDD4478EEE0@kernel.crashing.org> <20090910075629.6E353832E8DE@gemini.denx.de> <20090910115528.7A803832E8DE@gemini.denx.de> Message-ID: <59C20CEA-A72F-4B6A-B8E2-089688EC84A4@kernel.crashing.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sep 10, 2009, at 6:55 AM, Wolfgang Denk wrote: > Dear Kumar Gala, > > In message A7E9-4042BCF63B37 at kernel.crashing.org> you wrote: >> >>> It's a problem that exists independent of this patch, you get the >>> same >>> errors before. The problems are caused by your commit ec79d33 >>> ("85xx: >>> Move to a common linker script"). >>> >>> I reported this problem before, but it seems you missed that, see: >>> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/65788/focus=67568 >>> >>> >>> I hoped you would fix this problem (or we can revert commit >>> ec79d33?) >> >> Ok. I think we are see two issues interact. >> >> I've just sent a pull request w/the RESET_VECTOR_ADDRESS fix that >> should address the linker script issue. These seems to build cleanly >> on all 85xx platforms w/ELDK4.2 for me. >> >> Now if you apply the TQM85xx.h on top of that you will see that the >> enabling of new features causes the size to increase beyond what is >> allocated for TQM8540. > > Maybe. But this is just another manifestation of the original problem: > without commit ec79d33 we didn't need the RESET_VECTOR_ADDRESS stuff > at all, and an image size of 256 kB was sufficient without and with > the "TQM85xx: enable partition suppor" patch applied. > > Now, after commit ec79d33 (which needed to be fixed by the > RESET_VECTOR_ADDRESS stuff in the first place), we suddenly need more > than 256 kB. > > This obviously means that commit ec79d33 introduced changes to the > image layout that make it bigger. > > I consider this a bug in commit ec79d33. I don't want to waste more > space than needed. I don't agree. If I revert both commits and apply the TQM config.h update I see build failures. I've posted a 'tqm-test' branch of the mpc85xx tree that does just that. I see the following: [galak at komodo u-boot-85xx]$ ./MAKEALL TQM8540 ... TQM8540 (MPC8540) Configuring for TQM85xx board... /opt/eldk/4.2/ppc-linux-x86/usr/bin/ppc_85xxDP-ld: section .bootpg [fffff000 -> fffff1df] overlaps section .data.rel.local [ffffe964 -> fffff6a7] /opt/eldk/4.2/ppc-linux-x86/usr/bin/ppc_85xxDP-ld: u-boot: section .bootpg lma 0xfffff000 overlaps previous sections /opt/eldk/4.2/ppc-linux-x86/usr/bin/ppc_85xxDP-ld: u-boot: section .data.rel.ro.local lma 0xfffff6a8 overlaps previous sections /opt/eldk/4.2/ppc-linux-x86/usr/bin/ppc_85xxDP-ld: u-boot: section .data.rel lma 0xfffff728 overlaps previous sections make: *** [u-boot] Error 1 /opt/eldk/4.2/ppc-linux-x86/usr/bin/ppc_85xxDP-size: './u-boot': No such file - k