From: "Jan Beulich" <JBeulich@suse.com>
To: Petre Pircalabu <ppircalabu@bitdefender.com>
Cc: tim@xen.org, kevin.tian@intel.com, sstabellini@kernel.org,
wei.liu2@citrix.com, rcojocaru@bitdefender.com,
George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
paul.durrant@citrix.com, tamas@tklengyel.com,
jun.nakajima@intel.com
Subject: Re: [PATCH v12 1/4] x86emul: New return code for unimplemented instruction
Date: Fri, 22 Sep 2017 03:10:54 -0600 [thread overview]
Message-ID: <59C4EFBE020000780017E6F1@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1505970726-5671-2-git-send-email-ppircalabu@bitdefender.com>
>>> On 21.09.17 at 07:12, <ppircalabu@bitdefender.com> wrote:
> Changed since v11:
> * Fixed double negative in the patch description.
> * Move assertion into the switch and use ASSERT_UNREACHABLE() when
> applicable.
> * Changed the description of X86EMUL_UNIMPLEMENTED / X86EMUL_UNRECOGNIZED
> to reflect the differences between those 2 return codes.
> * Changed the returned value to X86EMUL_UNRECOGNIZED in the
> following cases:
> X86EMUL_OPC(0x0f, 0x73): /* Group 14 */
> X86EMUL_OPC_66(0x0f, 0x73):
> X86EMUL_OPC_VEX_66(0x0f, 0x73):
> - All valid opcodes are defined, so it should return
> X86EMUL_UNRECOGNIZED if mod R/M bits are not matched.
>
> X86EMUL_OPC(0x0f, 0xc7) /* Group 9 */
> - For register type instructions all possible opcodes are
> defined, so it should return X86EMUL_UNRECOGNIZED if
> mod R/M bits are not matched.
This is not entirely correct, btw (and hence the code change isn't
either): The code there has a dependency on gas features, so
hypervisor builds may not include support for rdrand and/or rdseed.
You will want to add "#else" cases producing "unimplemented".
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-09-22 9:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 5:12 [PATCH v12 0/4] Notify monitor when emulating an unimplemented instruction Petre Pircalabu
2017-09-21 5:12 ` [PATCH v12 1/4] x86emul: New return code for " Petre Pircalabu
2017-09-21 8:53 ` Paul Durrant
2017-09-23 18:56 ` Petre Ovidiu PIRCALABU
2017-09-25 7:54 ` Paul Durrant
2017-09-21 12:42 ` Jan Beulich
2017-09-25 9:16 ` Petre Ovidiu PIRCALABU
2017-09-25 10:36 ` Jan Beulich
2017-09-22 9:10 ` Jan Beulich [this message]
2017-09-21 5:12 ` [PATCH v12 2/4] x86emul: Add return code information to error messages Petre Pircalabu
2017-09-21 5:12 ` [PATCH v12 3/4] x86/monitor: Notify monitor if an emulation fails Petre Pircalabu
2017-09-21 5:12 ` [PATCH v12 4/4] x86emul: Raise #UD when emulating an unrecognized instruction Petre Pircalabu
2017-09-21 8:57 ` Paul Durrant
2017-09-21 12:44 ` Jan Beulich
2017-09-25 6:22 ` Petre Ovidiu PIRCALABU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59C4EFBE020000780017E6F1@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=paul.durrant@citrix.com \
--cc=ppircalabu@bitdefender.com \
--cc=rcojocaru@bitdefender.com \
--cc=sstabellini@kernel.org \
--cc=tamas@tklengyel.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.