From mboxrd@z Thu Jan 1 00:00:00 1970 From: vathsala nagaraju Subject: Re: [PATCH 1/2] drm/dp: Add defines for latency in sink Date: Mon, 25 Sep 2017 14:31:38 +0530 Message-ID: <59C8C5F2.20806@intel.com> References: <1506126883-22800-1-git-send-email-vathsala.nagaraju@intel.com> <87efqv5gqp.fsf@nikula.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1242089106==" Return-path: In-Reply-To: <87efqv5gqp.fsf@nikula.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , rodrigo.vivi@intel.com, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: Puthikorn Voravootivat List-Id: dri-devel@lists.freedesktop.org This is a multi-part message in MIME format. --===============1242089106== Content-Type: multipart/alternative; boundary="------------050002070507030708020907" This is a multi-part message in MIME format. --------------050002070507030708020907 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On Monday 25 September 2017 01:53 PM, Jani Nikula wrote: > On Sat, 23 Sep 2017, vathsala nagaraju wrote: >> Add defines for dpcd register 2009 (synchronization latency >> in sink). >> >> Cc: Rodrigo Vivi >> CC: Puthikorn Voravootivat >> Reviewed-by: Rodrigo Vivi >> Signed-off-by: Vathsala Nagaraju >> --- >> include/drm/drm_dp_helper.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h >> index 11c39f1..846004e6 100644 >> --- a/include/drm/drm_dp_helper.h >> +++ b/include/drm/drm_dp_helper.h >> @@ -735,6 +735,9 @@ >> # define DP_PSR_SINK_INTERNAL_ERROR 7 >> # define DP_PSR_SINK_STATE_MASK 0x07 >> >> +#define DP_SINK_SYNCHRONIZATION_LATENCY 0x2009 >> +# define DP_MAX_RESYNC_FRAME_CNT_MASK 0xf > For the DP spec, please don't invent the names, use the ones from the > spec. At most drop excess stuff from the end. In edp 1.4b spec , the register name 2009 is "DEBUG 0 SYNCHRONIZATION LATENCY SINK " and bit 0:3 "MAX RE-SYNC FRAME COUNT" > > #define DP_SYNCHRONIZATION_LATENCY_IN_SINK > # define DP_MAX_RESYNC_FRAME_COUNT_SHIFT > # define DP_MAX_RESYNC_FRAME_COUNT_MASK > > And while at it, please add the full register contents. > > BR, > Jani. > >> + >> #define DP_RECEIVER_ALPM_STATUS 0x200b /* eDP 1.4 */ >> # define DP_ALPM_LOCK_TIMEOUT_ERROR (1 << 0) --------------050002070507030708020907 Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: 8bit
On Monday 25 September 2017 01:53 PM, Jani Nikula wrote:
On Sat, 23 Sep 2017, vathsala nagaraju <vathsala.nagaraju@intel.com> wrote:
Add defines for dpcd register 2009 (synchronization latency
in sink).

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
CC: Puthikorn Voravootivat <puthik@chromium.org>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
---
 include/drm/drm_dp_helper.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 11c39f1..846004e6 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -735,6 +735,9 @@
 # define DP_PSR_SINK_INTERNAL_ERROR         7
 # define DP_PSR_SINK_STATE_MASK             0x07
 
+#define DP_SINK_SYNCHRONIZATION_LATENCY	    0x2009
+# define DP_MAX_RESYNC_FRAME_CNT_MASK	    0xf
For the DP spec, please don't invent the names, use the ones from the
spec. At most drop excess stuff from the end.
In edp 1.4b spec , the register name 2009 is "DEBUG 0 SYNCHRONIZATION LATENCY SINK "  and bit 0:3 "MAX RE-SYNC FRAME COUNT"

#define DP_SYNCHRONIZATION_LATENCY_IN_SINK
# define DP_MAX_RESYNC_FRAME_COUNT_SHIFT
# define DP_MAX_RESYNC_FRAME_COUNT_MASK

And while at it, please add the full register contents.

BR,
Jani.

+
 #define DP_RECEIVER_ALPM_STATUS		    0x200b  /* eDP 1.4 */
 # define DP_ALPM_LOCK_TIMEOUT_ERROR	    (1 << 0)

    

--------------050002070507030708020907-- --===============1242089106== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============1242089106==--