From: "Jan Beulich" <JBeulich@suse.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
AndrewCooper <andrew.cooper3@citrix.com>,
IanJackson <ian.jackson@eu.citrix.com>,
Yi Sun <yi.y.sun@linux.intel.com>,
Chao Peng <chao.p.peng@linux.intel.com>,
xen-devel@lists.xenproject.org,
Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH v5 02/16] Rename PSR sysctl/domctl interfaces and xsm policy to make them be general
Date: Mon, 09 Oct 2017 02:12:56 -0600 [thread overview]
Message-ID: <59DB4BA80200007800183C61@prv-mh.provo.novell.com> (raw)
In-Reply-To: <20171006165355.6mk633k5ojlixfd2@MacBook-Pro-de-Roger.local>
>>> On 06.10.17 at 18:53, <roger.pau@citrix.com> wrote:
> On Sat, Sep 30, 2017 at 01:39:12AM +0000, Yi Sun wrote:
>> --- a/xen/arch/x86/domctl.c
>> +++ b/xen/arch/x86/domctl.c
>> @@ -37,6 +37,16 @@
>> #include <asm/psr.h>
>> #include <asm/cpuid.h>
>>
>> +#define domctl_psr_get_val(d, domctl, type, copyback) ({ \
>> + int r__; \
>> + uint32_t v__; \
>
> No '__' in variable names, and missing newline.
Why that? We're disallowing underscores as prefixes, but using
(normally single) trailing underscores for macro local variables is
quite usual, to avoid possible expansion conflicts.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-10-09 8:13 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-30 1:39 [PATCH v5 00/16] Enable Memory Bandwidth Allocation in Xen Yi Sun
2017-09-30 1:39 ` [PATCH v5 01/16] docs: create Memory Bandwidth Allocation (MBA) feature document Yi Sun
2017-10-06 14:59 ` Roger Pau Monné
2017-09-30 1:39 ` [PATCH v5 02/16] Rename PSR sysctl/domctl interfaces and xsm policy to make them be general Yi Sun
2017-10-05 11:36 ` Wei Liu
2017-10-06 16:53 ` Roger Pau Monné
2017-10-09 8:12 ` Jan Beulich [this message]
2017-09-30 1:39 ` [PATCH v5 03/16] x86: rename 'cbm_type' to 'psr_type' to make it general Yi Sun
2017-09-30 1:39 ` [PATCH v5 04/16] x86: a few optimizations to psr codes Yi Sun
2017-10-06 16:59 ` Roger Pau Monné
2017-09-30 1:39 ` [PATCH v5 05/16] x86: implement data structure and CPU init flow for MBA Yi Sun
2017-10-06 17:13 ` Roger Pau Monné
2017-09-30 1:39 ` [PATCH v5 06/16] x86: implement get hw info " Yi Sun
2017-10-06 17:16 ` Roger Pau Monné
2017-09-30 1:39 ` [PATCH v5 07/16] x86: implement get value interface " Yi Sun
2017-09-30 1:39 ` [PATCH v5 08/16] x86: implement set value flow " Yi Sun
2017-10-06 17:18 ` Roger Pau Monné
2017-09-30 1:39 ` [PATCH v5 09/16] tools: create general interfaces to support psr allocation features Yi Sun
2017-10-05 11:31 ` Wei Liu
2017-10-06 17:20 ` Roger Pau Monné
2017-09-30 1:39 ` [PATCH v5 10/16] tools: implement the new libxc get hw info interface Yi Sun
2017-10-05 11:31 ` Wei Liu
2017-10-06 17:25 ` Roger Pau Monné
2017-09-30 1:39 ` [PATCH v5 11/16] tools: implement the new libxl " Yi Sun
2017-10-05 11:31 ` Wei Liu
2017-09-30 1:39 ` [PATCH v5 12/16] tools: implement the new xl " Yi Sun
2017-10-05 11:31 ` Wei Liu
2017-09-30 1:39 ` [PATCH v5 13/16] tools: rename 'xc_psr_cat_type' to 'xc_psr_type' Yi Sun
2017-09-30 1:39 ` [PATCH v5 14/16] tools: implement new generic get value interface and MBA get value command Yi Sun
2017-10-06 17:30 ` Roger Pau Monné
2017-09-30 1:39 ` [PATCH v5 15/16] tools: implement new generic set value interface and MBA set " Yi Sun
2017-10-05 11:31 ` Wei Liu
2017-10-06 17:33 ` Roger Pau Monné
2017-09-30 1:39 ` [PATCH v5 16/16] docs: add MBA description in docs Yi Sun
2017-10-05 11:27 ` [PATCH v5 00/16] Enable Memory Bandwidth Allocation in Xen Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59DB4BA80200007800183C61@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=chao.p.peng@linux.intel.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
--cc=yi.y.sun@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.