From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1q5U-0004QV-L7 for qemu-devel@nongnu.org; Tue, 10 Oct 2017 04:40:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1q5K-00006L-Jh for qemu-devel@nongnu.org; Tue, 10 Oct 2017 04:40:28 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:2324) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1e1q5K-0008T8-04 for qemu-devel@nongnu.org; Tue, 10 Oct 2017 04:40:18 -0400 Message-ID: <59DC865F.3040307@huawei.com> Date: Tue, 10 Oct 2017 16:35:43 +0800 From: "Longpeng (Mike)" MIME-Version: 1.0 References: <1505092240-10864-1-git-send-email-longpeng2@huawei.com> <2d8ae3d3-438b-da84-4959-cf63f4f4ce99@linux.vnet.ibm.com> <59B9D439.10807@huawei.com> <7e490af1-9caa-c96d-5f62-308f1b5d8805@linux.vnet.ibm.com> <59BF1E9B.2030408@huawei.com> <64d90f78-a2ae-be37-672b-e47aa3d4ecb2@linux.vnet.ibm.com> <33183CC9F5247A488A2544077AF19020DA3FBCC5@DGGEMA505-MBX.china.huawei.com> <7eaac82c-0d8b-47f1-94dd-772b3abf31f9@linux.vnet.ibm.com> <33183CC9F5247A488A2544077AF19020DA3FBDD3@DGGEMA505-MBX.china.huawei.com> In-Reply-To: <33183CC9F5247A488A2544077AF19020DA3FBDD3@DGGEMA505-MBX.china.huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [RFC 0/8] virtio-crypto: add multiplexing mode support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gonglei (Arei)" , Halil Pasic Cc: "wangxin (U)" , "virtio-dev@lists.oasis-open.org" , "Ola.Liljedahl@arm.com" , "Huangweidong (C)" , "brian.a.keating@intel.com" , "mst@redhat.com" , "xin.zeng@intel.com" , "jasowang@redhat.com" , "cohuck@redhat.com" , Luonengjun , "qemu-devel@nongnu.org" , "john.griffin@intel.com" , "agraf@suse.de" , "liang.j.ma@intel.com" , "mike.caraman@nxp.com" , "stefanha@redhat.com" , "Varun.Sethi@freescale.com" , Jani Kokkonen , "vincent.jardin@6wind.com" , "denglingli@chinamobile.com" , "arei.gonglei@hotmail.com" On 2017/10/9 19:17, Gonglei (Arei) wrote: > >> -----Original Message----- >> From: Halil Pasic [mailto:pasic@linux.vnet.ibm.com] >> Sent: Monday, October 09, 2017 7:05 PM >> >> On 10/09/2017 11:22 AM, Gonglei (Arei) wrote: >>> The next patch refactors make sense to me, >>> but why do we need to decouple the virtio-crypto.h? >>> >>> >> >> I wanted to be able to freely change the host side and test with an unchanged >> guest side, that's why I've done that. It's just for testing. I had to do that >> because we don't have a mux capable linux driver. Neither of these patches is >> intended for inclusion. I'm just trying to make a point with them: we can >> make this substantially simpler (compared to this RFC). >> > I see. > >> So how do we proceed here? It would be nice to see a cleaned up version of > > Maybe Longpeng can apply your test patches in the following patch set when > he has time. @Longpeng > OK, I'll take Halil's approach in the following patch set. But I think the spec is more important in the current, hope Halil would give more useful suggestions. :) >> this series soon. If I recall correctly there were also other things which >> can be done in a less convoluted manner. >> > Oh? Which things? > >>>> The basic idea behind the whole thing is that tinging about the requests put >>>> on the virtqueues in terms of just complicates things unnecessarily. >>>> >>>> I could guess I will post the interesting part as a reply to this and the less >>>> interesting part (decoupling) as an attachment. You are supposed to apply >> first >>>> the attachment then the part after the scissors line. >>>> >>>> Of course should you could respin the series preferably with the test >>>> included I can rebase my stuff. >>>> >>>> Please let me know about your opinion. >>>> >>> Thanks for your work, Halil. What's your opinion about virtio crypto spec v20? >> >> I'm on it. I've already started witting on Friday but things turned out a bit more >> interesting that expected. So I've postponed to today. Of course the two things >> are >> connected. I will try to give some feedback today. >> > Sounds good. > > Thanks, > -Gonglei > -- Regards, Longpeng(Mike) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-2604-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [66.179.20.138]) by lists.oasis-open.org (Postfix) with ESMTP id C33B55818E63 for ; Tue, 10 Oct 2017 01:40:31 -0700 (PDT) Message-ID: <59DC865F.3040307@huawei.com> Date: Tue, 10 Oct 2017 16:35:43 +0800 From: "Longpeng (Mike)" MIME-Version: 1.0 References: <1505092240-10864-1-git-send-email-longpeng2@huawei.com> <2d8ae3d3-438b-da84-4959-cf63f4f4ce99@linux.vnet.ibm.com> <59B9D439.10807@huawei.com> <7e490af1-9caa-c96d-5f62-308f1b5d8805@linux.vnet.ibm.com> <59BF1E9B.2030408@huawei.com> <64d90f78-a2ae-be37-672b-e47aa3d4ecb2@linux.vnet.ibm.com> <33183CC9F5247A488A2544077AF19020DA3FBCC5@DGGEMA505-MBX.china.huawei.com> <7eaac82c-0d8b-47f1-94dd-772b3abf31f9@linux.vnet.ibm.com> <33183CC9F5247A488A2544077AF19020DA3FBDD3@DGGEMA505-MBX.china.huawei.com> In-Reply-To: <33183CC9F5247A488A2544077AF19020DA3FBDD3@DGGEMA505-MBX.china.huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: [virtio-dev] Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [RFC 0/8] virtio-crypto: add multiplexing mode support To: "Gonglei (Arei)" , Halil Pasic Cc: "wangxin (U)" , "virtio-dev@lists.oasis-open.org" , "Ola.Liljedahl@arm.com" , "Huangweidong (C)" , "brian.a.keating@intel.com" , "mst@redhat.com" , "xin.zeng@intel.com" , "jasowang@redhat.com" , "cohuck@redhat.com" , Luonengjun , "qemu-devel@nongnu.org" , "john.griffin@intel.com" , "agraf@suse.de" , "liang.j.ma@intel.com" , "mike.caraman@nxp.com" , "stefanha@redhat.com" , "Varun.Sethi@freescale.com" , Jani Kokkonen , "vincent.jardin@6wind.com" , "denglingli@chinamobile.com" , "arei.gonglei@hotmail.com" List-ID: On 2017/10/9 19:17, Gonglei (Arei) wrote: > >> -----Original Message----- >> From: Halil Pasic [mailto:pasic@linux.vnet.ibm.com] >> Sent: Monday, October 09, 2017 7:05 PM >> >> On 10/09/2017 11:22 AM, Gonglei (Arei) wrote: >>> The next patch refactors make sense to me, >>> but why do we need to decouple the virtio-crypto.h? >>> >>> >> >> I wanted to be able to freely change the host side and test with an unchanged >> guest side, that's why I've done that. It's just for testing. I had to do that >> because we don't have a mux capable linux driver. Neither of these patches is >> intended for inclusion. I'm just trying to make a point with them: we can >> make this substantially simpler (compared to this RFC). >> > I see. > >> So how do we proceed here? It would be nice to see a cleaned up version of > > Maybe Longpeng can apply your test patches in the following patch set when > he has time. @Longpeng > OK, I'll take Halil's approach in the following patch set. But I think the spec is more important in the current, hope Halil would give more useful suggestions. :) >> this series soon. If I recall correctly there were also other things which >> can be done in a less convoluted manner. >> > Oh? Which things? > >>>> The basic idea behind the whole thing is that tinging about the requests put >>>> on the virtqueues in terms of just complicates things unnecessarily. >>>> >>>> I could guess I will post the interesting part as a reply to this and the less >>>> interesting part (decoupling) as an attachment. You are supposed to apply >> first >>>> the attachment then the part after the scissors line. >>>> >>>> Of course should you could respin the series preferably with the test >>>> included I can rebase my stuff. >>>> >>>> Please let me know about your opinion. >>>> >>> Thanks for your work, Halil. What's your opinion about virtio crypto spec v20? >> >> I'm on it. I've already started witting on Friday but things turned out a bit more >> interesting that expected. So I've postponed to today. Of course the two things >> are >> connected. I will try to give some feedback today. >> > Sounds good. > > Thanks, > -Gonglei > -- Regards, Longpeng(Mike) --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org