From: Wols Lists <antlists@youngman.org.uk>
To: NeilBrown <neilb@suse.com>, Zhilong Liu <zlliu@suse.com>,
"jes.sorensen@gmail.com" <jes.sorensen@gmail.com>
Cc: Linux Raid <linux-raid@vger.kernel.org>
Subject: Re: [mdadm PATCH] mdopen: call "modprobe md_mod" if it might be needed.
Date: Thu, 12 Oct 2017 10:55:14 +0100 [thread overview]
Message-ID: <59DF3C02.6080104@youngman.org.uk> (raw)
In-Reply-To: <87h8v5nsa6.fsf@notabene.neil.brown.name>
On 12/10/17 01:06, NeilBrown wrote:
> Yes - exactly like that except that I wouldn't wrap the long string.
> Lines longer than 80 chars are good to avoid, but breaking string
> literals is worse than having long lines. e.g. it makes searching for
> the string hard.
Isn't that the kernel standard anyway?
"Wrap at 80 chars *unless* that would mean breaking a string literal".
Iirc an lwn story or something about how all subsystems tended to follow
this rule except one, so they were going to try and standardise across
everything.
Cheers,
Wol
prev parent reply other threads:[~2017-10-12 9:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 5:52 [mdadm PATCH] mdopen: call "modprobe md_mod" if it might be needed NeilBrown
2017-09-25 15:26 ` John Stoffel
2017-09-25 23:50 ` NeilBrown
2017-09-26 15:11 ` Jes Sorensen
2017-09-26 19:12 ` Wols Lists
2017-09-26 20:55 ` John Stoffel
2017-09-27 21:30 ` Jes Sorensen
[not found] ` <cba5f77f-d6de-7a6b-35b0-70b7c56eb3f7@suse.com>
2017-10-10 20:16 ` NeilBrown
2017-10-11 7:39 ` Zhilong Liu
2017-10-12 0:06 ` NeilBrown
2017-10-12 3:55 ` Zhilong Liu
2017-10-12 8:48 ` NeilBrown
2017-10-13 9:16 ` Zhilong Liu
2017-10-15 22:41 ` NeilBrown
2017-10-12 9:55 ` Wols Lists [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59DF3C02.6080104@youngman.org.uk \
--to=antlists@youngman.org.uk \
--cc=jes.sorensen@gmail.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=zlliu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.