From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH] libxc: don't fail domain creation when unpacking initrd fails Date: Fri, 20 Oct 2017 09:47:29 -0600 Message-ID: <59EA36B10200007800188D0F@prv-mh.provo.novell.com> References: <59E4EB5C0200007800186CF8@prv-mh.provo.novell.com> <23012.54320.887251.831620@mariner.uk.xensource.com> <59E4F8170200007800186DC8@prv-mh.provo.novell.com> <23012.57779.375772.549924@mariner.uk.xensource.com> <59E781DD0200007800187C0D@prv-mh.provo.novell.com> <23016.48995.657539.136790@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5ZWH-0001Zr-HG for xen-devel@lists.xenproject.org; Fri, 20 Oct 2017 15:47:33 +0000 In-Reply-To: <23016.48995.657539.136790@mariner.uk.xensource.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Ian Jackson Cc: xen-devel , Wei Liu List-Id: xen-devel@lists.xenproject.org Pj4+IE9uIDE5LjEwLjE3IGF0IDE3OjA2LCA8aWFuLmphY2tzb25AZXUuY2l0cml4LmNvbT4gd3Jv dGU6Cj4gSmFuIEJldWxpY2ggd3JpdGVzICgiUmU6IFtQQVRDSF0gbGlieGM6IGRvbid0IGZhaWwg ZG9tYWluIGNyZWF0aW9uIHdoZW4gCj4gdW5wYWNraW5nIGluaXRyZCBmYWlscyIpOgo+PiBPbiAx Ni4xMC4xNyBhdCAxODo0MywgPGlhbi5qYWNrc29uQGV1LmNpdHJpeC5jb20+IHdyb3RlOgo+PiA+ IEknbSBhZnJhaWQgSSBzdGlsbCBmaW5kIHRoZSBwYXRjaCBsZXNzIGNsZWFyIHRoYW4gaXQgY291 bGQgYmUuCj4+ID4gVGhlIG5ldyBzZW1hbnRpY3Mgb2YgeGNfZG9tX3JhbWRpc2tfY2hlY2tfc2l6 ZSBhcmUgYXdrd2FyZC4gIEFuZAo+PiA+IGxvb2tpbmcgYXQgaXQgYnJpZWZseSwgSSB0aGluayBp dCBtaWdodCBiZSBwb3NzaWJsZSB0byB0cnkgdGhlIHVuemlwCj4+ID4gZXZlbiBpZiB0aGUgc2l6 ZSBpcyB0b28gbGFyZ2UuCj4+IAo+PiBJIGRvbid0IHRoaW5rIHNvIC0geGNfZG9tX3JhbWRpc2tf Y2hlY2tfc2l6ZSgpIHJldHVybnMgMQo+PiB3aGVuZXZlciBkZWNvbXByZXNzZWQgc2l6ZSBpcyBh Ym92ZSB0aGUgbGltaXQuIFdoYXQgSSBkbwo+PiBhZG1pdCBpcyB0aGF0IGluIHRoZSBjYXNlIGNv bXByZXNzZWQgc2l6ZSBpcyBsYXJnZXIgdGhhbgo+PiB1bmNvbXByZXNzZWQgc2l6ZSwgd2l0aCB0 aGUgYm91bmRhcnkgYmVpbmcgaW4gYmV0d2VlbiwgYW5kCj4+IHdpdGggZGVjb21wcmVzc2lvbiBm YWlsaW5nLCB3ZSBtYXkgYWNjZXB0IHNvbWV0aGluZyB0aGF0J3MKPj4gYWJvdmUgdGhlIGxpbWl0 LiBOb3Qgc3VyZSBob3cgYmFkIHRoYXQgaXMgdGhvdWdoLCBhcyB0aGUgbGltaXQKPj4gaXMgcHJl dHR5IGFyYml0cmFyeSBhbnl3YXkuCj4gCj4gQ29uY2VwdHVhbGx5IHdoYXQgeW91IGFyZSB0cnlp bmcgdG8gZG8gaXMgaGF2ZSB0d28gYWx0ZXJuYXRpdmUKPiBzdHJhdGVnaWVzLiAgVGhvc2UgdHdv IHN0cmF0ZWdpZXMgaGF2ZSBkaWZmZXJlbnQgbGltaXRzLiAgU28gInRoZQo+IGxpbWl0IiBpcyBu b3QgYSBtZWFuaW5nZnVsIGNvbmNlcHQuCj4gCj4+ID4gV2hhdCB5b3UgYXJlIHJlYWxseSB0cnlp bmcgdG8gZG8gaGVyZSBpcyB0byBwdXJzdWUgdHdvIHN0cmF0ZWdpZXMgaW4KPj4gPiBwYXJhbGxl bC4gIEFuZCBpZGVhbGx5IHRoZXkgd291bGQgbm90IGJlIGVudGFuZ2xlZC4KPj4gCj4+IEkgd291 bGQgaGF2ZSB3YW50ZWQgdG8gZG8gdGhpbmdzIGluIHNlcXVlbmNlIHJhdGhlciB0aGFuIGluCj4+ IHBhcmFsbGVsLiBJIGNhbid0IHNlZSBob3cgdGhhdCBjb3VsZCB3b3JrIHRob3VnaCwgaW4gcGFy dGljdWxhcgo+PiB3aGVuIGNvbnNpZGVyaW5nIHRoZSBjYXNlIG1lbnRpb25lZCBhYm92ZSAodW5j b21wcmVzc2VkIHNpemUKPj4gc21hbGxlciB0aGFuIGNvbXByZXNzZWQpIC0gYXMgdGhlIHNwYWNl IGFsbG9jYXRpb24gaW4gdGhlIGd1ZXN0Cj4+IGNhbid0IGJlIHJldmVydGVkLCBJIG5lZWQgdG8g YWxsb2NhdGUgdGhlIGxhcmdlciBvZiB0aGUgdHdvIHNpemVzCj4+IGFueXdheS4KPiAKPiBJIGRv bid0IHRoaW5rIGl0IGNhbiB3b3JrLiAgSSB0aGluayB5b3UgdW5lZWQgdG8gcHVyc3VlIHRoZW0g aW4KPiBwYXJhbGxlbCBhbmQga2VlcCBzZXBhcmF0ZSByZWNvcmRzLCBmb3IgZWFjaCBvbmUsIG9m IHdoZXRoZXIgd2UgYXJlCj4gc3RpbGwgcHVyc3VpbmcgaXQgb3Igd2hldGhlciBpdCBoYXMgZmFp bGVkIChhbmQgb2YgY291cnNlIGl0cwo+IG5lY2Vzc2FyeSBsb2NhbHMpLgoKU28gYmVmb3JlIEkg ZG8gYW5vdGhlciBwb2ludGxlc3Mgcm91bmQgb2YgYmFja3BvcnRpbmcgKGZvciB0aGUKY2hhbmdl IHRvIGJlIHRlc3RlZCBpbiB0aGUgZW52aXJvbm1lbnQgd2hlcmUgaXQgaXMgbmVlZGVkKSwKZG9l cyB0aGUgYmVsb3cgbmV3IGZ1bmN0aW9uICh3aXRoIHhjX2RvbV9yYW1kaXNrX2NoZWNrX3NpemUo KQpkcm9wcGVkIGFsdG9nZXRoZXIpIGxvb2sgYW55IGJldHRlciB0byB5b3U/CgpUaGFua3MsIEph bgoKc3RhdGljIGludCB4Y19kb21fYnVpbGRfcmFtZGlzayhzdHJ1Y3QgeGNfZG9tX2ltYWdlICpk b20pCnsKICAgIHNpemVfdCB1bnppcGxlbiwgcmFtZGlza2xlbjsKICAgIHZvaWQgKnJhbWRpc2tt YXA7CgogICAgaWYgKCAhZG9tLT5yYW1kaXNrX3NlZy52c3RhcnQgKQogICAgICAgIHVuemlwbGVu ID0geGNfZG9tX2NoZWNrX2d6aXAoZG9tLT54Y2gsCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBkb20tPnJhbWRpc2tfYmxvYiwgZG9tLT5yYW1kaXNrX3NpemUpOwogICAgZWxz ZQogICAgICAgIHVuemlwbGVuID0gMDsKCiAgICByYW1kaXNrbGVuID0gbWF4KHVuemlwbGVuLCBk b20tPnJhbWRpc2tfc2l6ZSk7CiAgICBpZiAoIGRvbS0+bWF4X3JhbWRpc2tfc2l6ZSApCiAgICB7 CiAgICAgICAgaWYgKCB1bnppcGxlbiAmJiByYW1kaXNrbGVuID4gZG9tLT5tYXhfcmFtZGlza19z aXplICkKICAgICAgICB7CiAgICAgICAgICAgIHJhbWRpc2tsZW4gPSBtaW4odW56aXBsZW4sIGRv bS0+cmFtZGlza19zaXplKTsKICAgICAgICAgICAgaWYgKCB1bnppcGxlbiA+IHJhbWRpc2tsZW4p CiAgICAgICAgICAgICAgICB1bnppcGxlbiA9IDA7CiAgICAgICAgfQogICAgICAgIGlmICggcmFt ZGlza2xlbiA+IGRvbS0+bWF4X3JhbWRpc2tfc2l6ZSApCiAgICAgICAgewogICAgICAgICAgICB4 Y19kb21fcGFuaWMoZG9tLT54Y2gsIFhDX0lOVkFMSURfS0VSTkVMLAogICAgICAgICAgICAgICAg ICAgICAgICAgInJhbWRpc2sgaW1hZ2UgdG9vIGxhcmdlIik7CiAgICAgICAgICAgIGdvdG8gZXJy OwogICAgICAgIH0KICAgIH0KCiAgICBpZiAoIHhjX2RvbV9hbGxvY19zZWdtZW50KGRvbSwgJmRv bS0+cmFtZGlza19zZWcsICJyYW1kaXNrIiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ZG9tLT5yYW1kaXNrX3NlZy52c3RhcnQsIHJhbWRpc2tsZW4pICE9IDAgKQogICAgICAgIGdvdG8g ZXJyOwogICAgcmFtZGlza21hcCA9IHhjX2RvbV9zZWdfdG9fcHRyKGRvbSwgJmRvbS0+cmFtZGlz a19zZWcpOwogICAgaWYgKCByYW1kaXNrbWFwID09IE5VTEwgKQogICAgewogICAgICAgIERPTVBS SU5URigiJXM6IHhjX2RvbV9zZWdfdG9fcHRyKGRvbSwgJmRvbS0+cmFtZGlza19zZWcpID0+IE5V TEwiLAogICAgICAgICAgICAgICAgICBfX0ZVTkNUSU9OX18pOwogICAgICAgIGdvdG8gZXJyOwog ICAgfQogICAgaWYgKCB1bnppcGxlbiApCiAgICB7CiAgICAgICAgaWYgKCB4Y19kb21fZG9fZ3Vu emlwKGRvbS0+eGNoLCBkb20tPnJhbWRpc2tfYmxvYiwgZG9tLT5yYW1kaXNrX3NpemUsCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHJhbWRpc2ttYXAsIHVuemlwbGVuKSAhPSAtMSApCiAg ICAgICAgICAgIHJldHVybiAwOwogICAgICAgIGlmICggZG9tLT5yYW1kaXNrX3NpemUgPiByYW1k aXNrbGVuICkKICAgICAgICAgICAgZ290byBlcnI7CiAgICB9CgogICAgLyogRmFsbCBiYWNrIHRv IGhhbmRpbmcgb3ZlciB0aGUgcmF3IGJsb2IuICovCiAgICBtZW1jcHkocmFtZGlza21hcCwgZG9t LT5yYW1kaXNrX2Jsb2IsIGRvbS0+cmFtZGlza19zaXplKTsKICAgIC8qIElmIGFuIHVuemlwIGF0 dGVtcHQgd2FzIG1hZGUsIHRoZSBidWZmZXIgbWF5IG5vIGxvbmdlciBiZSBhbGwgemVyby4gKi8K ICAgIGlmICggdW56aXBsZW4gPiBkb20tPnJhbWRpc2tfc2l6ZSApCiAgICAgICAgbWVtc2V0KHJh bWRpc2ttYXAgKyBkb20tPnJhbWRpc2tfc2l6ZSwgMCwKICAgICAgICAgICAgICAgdW56aXBsZW4g LSBkb20tPnJhbWRpc2tfc2l6ZSk7CgogICAgcmV0dXJuIDA7CgogZXJyOgogICAgcmV0dXJuIC0x Owp9CgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhl bi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0 cy54ZW4ub3JnL3hlbi1kZXZlbAo=