From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Morse Subject: Re: [RFC/RFT PATCH 0/6] Switch GHES ioremap_page_range() to use fixmap Date: Wed, 01 Nov 2017 14:58:54 +0000 Message-ID: <59F9E12E.4030302@arm.com> References: <20171031153832.17746-1-james.morse@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from foss.arm.com ([217.140.101.70]:48090 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753119AbdKAPAl (ORCPT ); Wed, 1 Nov 2017 11:00:41 -0400 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Linus Torvalds Cc: Linux ACPI , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" , the arch/x86 maintainers , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Borislav Petkov , "Rafael J . Wysocki" , Len Brown , Tony Luck , Tyler Baicar , Dongjiu Geng , Xie XiuQi Hi Linus, On 31/10/17 15:52, Linus Torvalds wrote: > On Tue, Oct 31, 2017 at 8:38 AM, James Morse wrote: >> 7 files changed, 30 insertions(+), 85 deletions(-) > > Lovely. > > I obviously can't test it, but it looks fine. I *would* suggest just > making the "add fixmap entries" commits with the code that actually > uses them. There's no real reason to have two commits that just add > two entries that aren't used yet. > > If it was some meaningful helper function where a split of the commits > makes each commit easier to read, that would be one thing. As it is, > the split just makes it harder to look at the history of the code (ie > "I wonder where this was introduced - let's use 'git blame'. Oh, > that's not useful"). I will squash the first three patches together to fix this, and add something about HAVE_ACPI_APEI to the commit message. (I'm still holding out for someone to test this on an x86 system with NOTIFY_NMI) Thanks, James From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754757AbdKAPAn (ORCPT ); Wed, 1 Nov 2017 11:00:43 -0400 Received: from foss.arm.com ([217.140.101.70]:48090 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753119AbdKAPAl (ORCPT ); Wed, 1 Nov 2017 11:00:41 -0400 Message-ID: <59F9E12E.4030302@arm.com> Date: Wed, 01 Nov 2017 14:58:54 +0000 From: James Morse User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Linus Torvalds CC: Linux ACPI , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" , the arch/x86 maintainers , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Borislav Petkov , "Rafael J . Wysocki" , Len Brown , Tony Luck , Tyler Baicar , Dongjiu Geng , Xie XiuQi Subject: Re: [RFC/RFT PATCH 0/6] Switch GHES ioremap_page_range() to use fixmap References: <20171031153832.17746-1-james.morse@arm.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, On 31/10/17 15:52, Linus Torvalds wrote: > On Tue, Oct 31, 2017 at 8:38 AM, James Morse wrote: >> 7 files changed, 30 insertions(+), 85 deletions(-) > > Lovely. > > I obviously can't test it, but it looks fine. I *would* suggest just > making the "add fixmap entries" commits with the code that actually > uses them. There's no real reason to have two commits that just add > two entries that aren't used yet. > > If it was some meaningful helper function where a split of the commits > makes each commit easier to read, that would be one thing. As it is, > the split just makes it harder to look at the history of the code (ie > "I wonder where this was introduced - let's use 'git blame'. Oh, > that's not useful"). I will squash the first three patches together to fix this, and add something about HAVE_ACPI_APEI to the commit message. (I'm still holding out for someone to test this on an x86 system with NOTIFY_NMI) Thanks, James From mboxrd@z Thu Jan 1 00:00:00 1970 From: james.morse@arm.com (James Morse) Date: Wed, 01 Nov 2017 14:58:54 +0000 Subject: [RFC/RFT PATCH 0/6] Switch GHES ioremap_page_range() to use fixmap In-Reply-To: References: <20171031153832.17746-1-james.morse@arm.com> Message-ID: <59F9E12E.4030302@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Linus, On 31/10/17 15:52, Linus Torvalds wrote: > On Tue, Oct 31, 2017 at 8:38 AM, James Morse wrote: >> 7 files changed, 30 insertions(+), 85 deletions(-) > > Lovely. > > I obviously can't test it, but it looks fine. I *would* suggest just > making the "add fixmap entries" commits with the code that actually > uses them. There's no real reason to have two commits that just add > two entries that aren't used yet. > > If it was some meaningful helper function where a split of the commits > makes each commit easier to read, that would be one thing. As it is, > the split just makes it harder to look at the history of the code (ie > "I wonder where this was introduced - let's use 'git blame'. Oh, > that's not useful"). I will squash the first three patches together to fix this, and add something about HAVE_ACPI_APEI to the commit message. (I'm still holding out for someone to test this on an x86 system with NOTIFY_NMI) Thanks, James