From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QNbSx-0002KH-Ke for qemu-devel@nongnu.org; Fri, 20 May 2011 21:58:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QNbSw-0000HA-GK for qemu-devel@nongnu.org; Fri, 20 May 2011 21:58:55 -0400 Received: from cantor.suse.de ([195.135.220.2]:41169 helo=mx1.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QNbSw-0000H6-9J for qemu-devel@nongnu.org; Fri, 20 May 2011 21:58:54 -0400 References: <1305862499-12328-1-git-send-email-david@gibson.dropbear.id.au> <4645A3FE-8472-4688-9596-4EA973821BFF@web.de> In-Reply-To: <4645A3FE-8472-4688-9596-4EA973821BFF@web.de> Mime-Version: 1.0 (iPhone Mail 8G4) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Message-Id: <59FF36D6-4D4B-46BB-8906-27D4B87B1F37@suse.de> From: Alexander Graf Date: Sat, 21 May 2011 03:58:21 +0200 Subject: Re: [Qemu-devel] [PATCH] Fix a bug in mtsr/mtsrin emulation on ppc64 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?Q?Andreas_F=C3=A4rber?= Cc: Kenneth Salerno , "paulus@samba.org" , QEMU-devel Developers , David Gibson Am 21.05.2011 um 00:37 schrieb Andreas F=C3=A4rber := > Am 20.05.2011 um 09:40 schrieb Alexander Graf: >=20 >> On 20.05.2011, at 05:34, David Gibson wrote: >>=20 >>> Early ppc64 CPUs include a hack to partially simulate the ppc32 segment >>> registers, by translating writes to them into writes to the SLB. This i= s >>> not used by any current Linux kernel, but it is used by the openbios use= d >>> in the qemu mac99 model. >>>=20 >>> Commit 81762d6dd0d430d87024f2c83e9c4dcc4329fb7d, cleaning up the SLB >>> handling introduced a bug in this code, breaking the openbios currently i= n >>> qemu. Specifically, there was an off by one error bitshuffling the >>> register format used by mtsr into the format needed for the SLB load, >>> causing the flag bits to end up in the wrong place. This caused the >>> storage keys to be wrong under openbios, meaning that the translation co= de >>> incorrectly thought a legitimate access was a permission violation. >>>=20 >>> This patch fixes the bug, at the same time it fixes some build bug in th= e >>> MMU debugging code (only exposed when DEBUG_MMU is enabled). >>=20 >> Thanks, applied to ppc-next :) >=20 > Nack, this does not fix ppc64 for me! How did you test it, Alex??? I booted a ppc64 kernel on a ppc64 Linux system with tcg and it booted fine f= or me. Maybe you're hitting yet another issue? Alex >=20