All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [2/6] ath10k: refactor firmware crashdump code to coredump.c
Date: Thu, 17 Aug 2017 06:15:52 +0200	[thread overview]
Message-ID: <59aabd5bf8a143a1b0a281bdb694db75@euamsexm01a.eu.qualcomm.com> (raw)
In-Reply-To: <150278538298.22482.10986802411848917689.stgit@potku.adurom.net>

Kalle Valo <kvalo@qca.qualcomm.com> wrote:

> In preparation to add RAM dump support. No functional changes, only moving code
> and renaming function names.
> 
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>

With only this patch applied, and CONFIG_DEV_COREDUMP disabled, there's a build error:

drivers/net/wireless/ath/ath10k/coredump.c:24:30: error: redefinition of ‘ath10k_coredump_new’
 struct ath10k_fw_crash_data *ath10k_coredump_new(struct ath10k *ar)
                              ^
In file included from drivers/net/wireless/ath/ath10k/coredump.c:17:0:
drivers/net/wireless/ath/ath10k/coredump.h:114:108: note: previous definition of ‘ath10k_coredump_new’ was here
drivers/net/wireless/ath/ath10k/coredump.c:130:5: error: redefinition of ‘ath10k_coredump_submit’
 int ath10k_coredump_submit(struct ath10k *ar)
     ^
In file included from drivers/net/wireless/ath/ath10k/coredump.c:17:0:
drivers/net/wireless/ath/ath10k/coredump.h:109:83: note: previous definition of ‘ath10k_coredump_submit’ was here

-- 
https://patchwork.kernel.org/patch/9901243/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2017-08-17  4:16 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-15  8:22 [PATCH 0/6] ath10k: firmware ramdump support Kalle Valo
2017-08-15  8:22 ` Kalle Valo
2017-08-15  8:22 ` [PATCH 1/6] ath10k: remove deprecated fw_crash_dump debugfs file Kalle Valo
2017-08-15  8:22   ` Kalle Valo
2017-08-15  8:23 ` [PATCH 2/6] ath10k: refactor firmware crashdump code to coredump.c Kalle Valo
2017-08-15  8:23   ` Kalle Valo
2017-08-17  4:15   ` Kalle Valo [this message]
2017-08-17  4:20   ` [2/6] " Kalle Valo
2017-08-17  4:20     ` Kalle Valo
2017-08-17  6:49     ` Kalle Valo
2017-08-17  6:49       ` Kalle Valo
2017-08-15  8:23 ` [PATCH 3/6] ath10k: detach coredump.c from debug.c Kalle Valo
2017-08-15  8:23   ` Kalle Valo
2017-08-15  8:23 ` [PATCH 4/6] ath10k: add coredump_mask module parameter Kalle Valo
2017-08-15  8:23   ` Kalle Valo
2017-08-15  8:23 ` [PATCH 5/6] ath10k: add memory dump support for QCA6174/QCA9377 Kalle Valo
2017-08-15  8:23   ` Kalle Valo
2017-08-15 11:33   ` [5/6] " Kalle Valo
2017-08-15 11:33     ` Kalle Valo
2017-08-15 17:42   ` [PATCH 5/6] " Ben Greear
2017-08-15 17:42     ` Ben Greear
2017-11-01 10:49   ` Kalle Valo
2017-11-01 10:49     ` Kalle Valo
2017-08-15  8:23 ` [PATCH 6/6] ath10k: add memory dump support QCA988X Kalle Valo
2017-08-15  8:23   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59aabd5bf8a143a1b0a281bdb694db75@euamsexm01a.eu.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.