From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D747C432BE for ; Thu, 2 Sep 2021 07:08:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E407A60462 for ; Thu, 2 Sep 2021 07:08:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242634AbhIBHJ0 (ORCPT ); Thu, 2 Sep 2021 03:09:26 -0400 Received: from mga11.intel.com ([192.55.52.93]:9486 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240424AbhIBHJ0 (ORCPT ); Thu, 2 Sep 2021 03:09:26 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10094"; a="215863138" X-IronPort-AV: E=Sophos;i="5.84,371,1620716400"; d="scan'208";a="215863138" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2021 00:08:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,371,1620716400"; d="scan'208";a="532744376" Received: from linux.intel.com ([10.54.29.200]) by FMSMGA003.fm.intel.com with ESMTP; 02 Sep 2021 00:08:28 -0700 Received: from [10.213.25.121] (mtkaczyk-MOBL1.ger.corp.intel.com [10.213.25.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 406085802B1; Thu, 2 Sep 2021 00:08:27 -0700 (PDT) Subject: Re: [PATCH v2] Monitor: print message before quit for no array to monitor To: Coly Li , linux-raid@vger.kernel.org Cc: George Gkioulis , Jes Sorensen References: <20210902023644.509-1-colyli@suse.de> From: "Tkaczyk, Mariusz" Message-ID: <59b40b04-399a-a0cd-f8be-ebdebe9a458c@linux.intel.com> Date: Thu, 2 Sep 2021 09:08:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902023644.509-1-colyli@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org Hi Coly, On 02.09.2021 04:36, Coly Li wrote: > @@ -258,6 +258,7 @@ int Monitor(struct mddev_dev *devlist, > if (oneshot) > break; > else if (!anyredundant) { > + pr_err("Stop for no array to monitor\n"); > break; IMO the message is not precise enough. See that if there is only raid0 then it also stops. Something like: "No array with redundancy detected, stopping" is more detailed. Thanks, Mariusz