From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A577C433DB for ; Mon, 1 Feb 2021 09:53:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64F8064EA6 for ; Mon, 1 Feb 2021 09:53:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64F8064EA6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BFB366E0ED; Mon, 1 Feb 2021 09:53:27 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id F1A9D6E0ED; Mon, 1 Feb 2021 09:53:26 +0000 (UTC) IronPort-SDR: yjSpGqVnYxAFQYm7CTj3fXuzkWpw54uhqeatkxQpqqfgwfkvjk12K6V12fFcbeAOnXuaPSWZLY K7J4VOTuKWGQ== X-IronPort-AV: E=McAfee;i="6000,8403,9881"; a="177153618" X-IronPort-AV: E=Sophos;i="5.79,392,1602572400"; d="scan'208";a="177153618" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2021 01:53:24 -0800 IronPort-SDR: IMgRaggRVAORV4fwmMvoaVdq16pNxS7kx8jATM/jmcW5zBweiiNpm/SYlEZWUlghhP2+7UXKjB RDs1VajJPFeg== X-IronPort-AV: E=Sophos;i="5.79,392,1602572400"; d="scan'208";a="369759390" Received: from rmeir2x-mobl.ger.corp.intel.com (HELO [10.214.231.94]) ([10.214.231.94]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2021 01:53:22 -0800 To: Chris Wilson , intel-gfx@lists.freedesktop.org References: <20210201085358.3408367-1-chris@chris-wilson.co.uk> <20210201093123.3481855-1-chris@chris-wilson.co.uk> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: <59c9afb3-e4bd-b7f5-ffae-33f4e2077570@linux.intel.com> Date: Mon, 1 Feb 2021 09:53:20 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210201093123.3481855-1-chris@chris-wilson.co.uk> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH i-g-t v2] intel_gpu_top: Hide unused clients X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 01/02/2021 09:31, Chris Wilson wrote: > Hide inactive clients by pressing 'i' (toggle in interactive mode). > > v2: Fix location of filter_idle. > > Signed-off-by: Chris Wilson > Cc: Tvrtko Ursulin > Reviewed-by: Tvrtko Ursulin > --- > tools/intel_gpu_top.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c > index 60ff62d28..d88b6cc61 100644 > --- a/tools/intel_gpu_top.c > +++ b/tools/intel_gpu_top.c > @@ -1595,6 +1595,7 @@ print_imc(struct engines *engines, double t, int lines, int con_w, int con_h) > } > > static bool class_view; > +static bool filter_idle; > > static int > print_engines_header(struct engines *engines, double t, > @@ -2115,6 +2116,9 @@ static void process_stdin(unsigned int timeout_us) > case 'q': > stop_top = true; > break; > + case 'i': > + filter_idle ^= true; > + break; > case '1': > class_view ^= true; > break; > @@ -2323,9 +2327,14 @@ int main(int argc, char **argv) > > for_each_client(clients, c, j) { > assert(c->status != PROBE); > + > if (c->status != ALIVE) > break; /* Active clients are first in the array. */ > > + /* Active clients before idle */ > + if (filter_idle && !c->total_runtime) > + break; > + Break won't be correct for id sort. I don't see what did not work with v1? It should be effectively the same apart from the break. Regards, Tvrtko > if (lines >= con_h) > break; > > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <20210201085358.3408367-1-chris@chris-wilson.co.uk> <20210201093123.3481855-1-chris@chris-wilson.co.uk> From: Tvrtko Ursulin Message-ID: <59c9afb3-e4bd-b7f5-ffae-33f4e2077570@linux.intel.com> Date: Mon, 1 Feb 2021 09:53:20 +0000 MIME-Version: 1.0 In-Reply-To: <20210201093123.3481855-1-chris@chris-wilson.co.uk> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t v2] intel_gpu_top: Hide unused clients List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org List-ID: On 01/02/2021 09:31, Chris Wilson wrote: > Hide inactive clients by pressing 'i' (toggle in interactive mode). > > v2: Fix location of filter_idle. > > Signed-off-by: Chris Wilson > Cc: Tvrtko Ursulin > Reviewed-by: Tvrtko Ursulin > --- > tools/intel_gpu_top.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c > index 60ff62d28..d88b6cc61 100644 > --- a/tools/intel_gpu_top.c > +++ b/tools/intel_gpu_top.c > @@ -1595,6 +1595,7 @@ print_imc(struct engines *engines, double t, int lines, int con_w, int con_h) > } > > static bool class_view; > +static bool filter_idle; > > static int > print_engines_header(struct engines *engines, double t, > @@ -2115,6 +2116,9 @@ static void process_stdin(unsigned int timeout_us) > case 'q': > stop_top = true; > break; > + case 'i': > + filter_idle ^= true; > + break; > case '1': > class_view ^= true; > break; > @@ -2323,9 +2327,14 @@ int main(int argc, char **argv) > > for_each_client(clients, c, j) { > assert(c->status != PROBE); > + > if (c->status != ALIVE) > break; /* Active clients are first in the array. */ > > + /* Active clients before idle */ > + if (filter_idle && !c->total_runtime) > + break; > + Break won't be correct for id sort. I don't see what did not work with v1? It should be effectively the same apart from the break. Regards, Tvrtko > if (lines >= con_h) > break; > > _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev