From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1lHyFm-0004Vz-5E for mharc-grub-devel@gnu.org; Thu, 04 Mar 2021 19:23:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHyFZ-0004LM-M2 for grub-devel@gnu.org; Thu, 04 Mar 2021 19:23:25 -0500 Received: from mail-qk1-x72d.google.com ([2607:f8b0:4864:20::72d]:39079) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHyFM-0006P6-Th for grub-devel@gnu.org; Thu, 04 Mar 2021 19:23:25 -0500 Received: by mail-qk1-x72d.google.com with SMTP id g185so347177qkf.6 for ; Thu, 04 Mar 2021 16:23:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hCDWWwirCBY7iFrzo2z6HQUSHfn/UhwQs5oBhO1RbNQ=; b=gENtSSQkX3ggHfF2zu7iq10Nd8NjXOMWVwvp8lYS5HoypDmhfa6YwZTVQr73tG58Zw 3LGYiNECtxCtTSm8hYhyPewqhh0vKxNRmym8oxMCXAVfWkfh8VYK1gpySImIc1l5bTL8 70ZysJ73sFAJpUDqFoNzPUPbYBl5HXVo6uUKmWcXAWrODIGTd4V6PVP+NZdZ3yo1XYN1 i65qL3ccC0KqUuRwuW9npvxd+NRQWI18N4s4cb3B2psdWd6nkHYVonUowjhAj3NUhzvo AQfubCai7ux4CdxfrNInGmxVk54PrSoPB4XyfcmmBiMVWk4EdTUGmXBEx8/ymCsWfPaK jyxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hCDWWwirCBY7iFrzo2z6HQUSHfn/UhwQs5oBhO1RbNQ=; b=EmuY3YgDnO+9KkkPt6tJHAs4YyKYs2GpAAGXnRvm66mi5EixK79i4e+efqTFU9AERT KmrYB0wReqQTf8OYt76ZlOaPlh+WWDTPuT4q0/+Lp91apt3o8onXkRFb8o8NuBOaWNQB xG+sFXB1sxJHcEIVXc1txXEMaqkug+5++XHmkZodssEH4j++FMIKdF3k3/WGlOHkTP6z ioHNyA4VtvKomJHnV+JqGh9+nRj2uWNf7wreeUIY2nna8GLyAFrh1PTuKZUqDdafjXK1 vKheVTuH1zcFryVWUcHlVNvqhwRrUJRtdoywp26ua7SmhIax4feFopcUJjtSsCG9V1D7 azKQ== X-Gm-Message-State: AOAM531BHbUjJI9lcswWq4nXpyC1JvXY7UHmj5nsURIkHMXlBG/oH+Bn vR+KpHoFDsHQh82ZgsjPp8GCjF54DLWPrQ== X-Google-Smtp-Source: ABdhPJxslrZTrsGypV1fq60L702EXLKfVK+dD8NpdbJ46ivMxoaCLGaeHnawSlXLfBgXtXP12ZWTqQ== X-Received: by 2002:a05:620a:31c:: with SMTP id s28mr6796274qkm.342.1614903789929; Thu, 04 Mar 2021 16:23:09 -0800 (PST) Received: from localhost.localdomain ([2605:a601:aac5:3700:9763:81c2:19e4:8a8f]) by smtp.gmail.com with ESMTPSA id 75sm674558qkd.114.2021.03.04.16.23.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Mar 2021 16:23:09 -0800 (PST) From: Glenn Washburn To: grub-devel@gnu.org, Daniel Kiper Cc: Glenn Washburn Subject: [PATCH v6 04/14] dmraid_nvidia: Format string error in grub_error Date: Thu, 4 Mar 2021 18:22:35 -0600 Message-Id: <59cc6b545d9c9ccc3e0ad6ccc721764f3f50a9ae.1614903653.git.development@efficientek.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::72d; envelope-from=development@efficientek.com; helo=mail-qk1-x72d.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2021 00:23:26 -0000 The grub_error has a format string expecting two arguments, but only one provided. According to the comments in the struct grub_nv_super definition, the version field looks like a version number where major.minor is encoded as each a byte in the two-byte short. Signed-off-by: Glenn Washburn --- grub-core/disk/dmraid_nvidia.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/disk/dmraid_nvidia.c b/grub-core/disk/dmraid_nvidia.c index 4d2fb04d1..6372663e6 100644 --- a/grub-core/disk/dmraid_nvidia.c +++ b/grub-core/disk/dmraid_nvidia.c @@ -122,7 +122,7 @@ grub_dmraid_nv_detect (grub_disk_t disk, if (sb.version != NV_VERSION) { grub_error (GRUB_ERR_NOT_IMPLEMENTED_YET, - "unknown version: %d.%d", sb.version); + "unknown version: %d.%d", sb.version >> 8, sb.version & 0xFF); return NULL; } -- 2.27.0