From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A8C5C433E2 for ; Wed, 22 Jul 2020 00:05:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7728C20771 for ; Wed, 22 Jul 2020 00:05:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="oD8YLncu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727906AbgGVAFZ (ORCPT ); Tue, 21 Jul 2020 20:05:25 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:46604 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726652AbgGVAFZ (ORCPT ); Tue, 21 Jul 2020 20:05:25 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 06M05DNQ130836; Tue, 21 Jul 2020 19:05:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1595376313; bh=BaVl8BMz9uCrVtWj8q6K5EptiOMW/J/P4Io6v+g3r48=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=oD8YLncuwpqLVfP44aad7yVfnnIbBiWWZQDlL+0IbEHVFexNY88DyDBtIKnkoBuc3 B9iTHy/zDVPctK+VYwk96rpNScnZVcPiF3nf5lTInI81JWFnDsMWDOmC/LNt+3yNQx uKy7CNAlsmTxJqCJw0QMrYBMty7MFjOQhzzRJkmA= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 06M05D0m058564 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 21 Jul 2020 19:05:13 -0500 Received: from DLEE113.ent.ti.com (157.170.170.24) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 21 Jul 2020 19:05:13 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 21 Jul 2020 19:05:13 -0500 Received: from [10.250.35.192] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 06M05DVv046850; Tue, 21 Jul 2020 19:05:13 -0500 Subject: Re: [PATCH v31 03/12] leds: lp50xx: Add the LP50XX family of the RGB LED driver To: Pavel Machek CC: , , , , , , References: <20200716182007.18389-1-dmurphy@ti.com> <20200716182007.18389-4-dmurphy@ti.com> <20200721210724.GD5966@amd> From: Dan Murphy Message-ID: <59d0a02c-cfae-1170-728d-2ae332a81f6e@ti.com> Date: Tue, 21 Jul 2020 19:05:13 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200721210724.GD5966@amd> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Pavel On 7/21/20 4:07 PM, Pavel Machek wrote: > On Thu 2020-07-16 13:19:58, Dan Murphy wrote: >> Introduce the LP5036/30/24/18/12/9 RGB LED driver. >> The difference in these parts are the number of >> LED outputs where the: >> >> LP5036 can control 36 LEDs >> LP5030 can control 30 LEDs >> LP5024 can control 24 LEDs >> LP5018 can control 18 LEDs >> LP5012 can control 12 LEDs >> LP5009 can control 9 LEDs >> >> The device has the ability to group LED output into control banks >> so that multiple LED banks can be controlled with the same mixing and >> brightness. Inversely the LEDs can also be controlled independently. >> >> Acked-by: Jacek Anaszewski >> Signed-off-by: Dan Murphy >> +/* >> + * struct lp50xx_chip_info - >> + * @num_leds: number of LED outputs available on the device >> + * @led_brightness0_reg: first brightness register of the device >> + * @mix_out0_reg: first color mix register of the device >> + * @bank_brt_reg: bank brightness register >> + * @bank_mix_reg: color mix register >> + * @reset_reg: device reset register >> + */ > Should have /** if this is kerneldoc. > >> + init_data.fwnode = child; >> + num_colors = 0; >> + >> + /* There are only 3 LEDs per module otherwise they should be >> + * banked which also is presented as 3 LEDs >> + */ > This is not usual comment style for kernel. (And add . at end of > sentence). I will fix both. Dan > Best regards, > Pavel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAFCBC433DF for ; Wed, 22 Jul 2020 00:06:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4EB8206F2 for ; Wed, 22 Jul 2020 00:06:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N9skWu6S"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="oD8YLncu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4EB8206F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Z5bREuZ8umAMoPVFDqaCD1sMMKUoaXb1OlMnI3t4Eik=; b=N9skWu6SiV6DgdmiCIwYo8/Mf bHFDP0zt/OqlKItXz2ov+hjarYdooOlpAzLtvqi5/v0n3qz8EfKYCIhyWk61+eAkIfcdVqpK8YIcV +y1YYx1jEmeX5y2FxYX+dcnMK9jzDipvZNgM5QNPd/byYpVHyaGLNxtASBOu6uOc6ewsNRGOGGHIs 4BrN2f7OGobnOLJ1h/skFFvmn7p6n/HFYLCeewaZ01Ukr8KCQXKcqbFK8HxBTWEBpIjUX3w2OVZHO MKrsyMsqKLKbA/MhB1dJNbNymwS/vT5S/f5Andw9QBMEHuYAGnhfYRyH8bdST7SzAQjescyPrX/9/ hwawcRlLA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jy2G6-0002F9-HA; Wed, 22 Jul 2020 00:05:18 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jy2G3-0002Ea-UT for linux-arm-kernel@lists.infradead.org; Wed, 22 Jul 2020 00:05:16 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 06M05DNQ130836; Tue, 21 Jul 2020 19:05:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1595376313; bh=BaVl8BMz9uCrVtWj8q6K5EptiOMW/J/P4Io6v+g3r48=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=oD8YLncuwpqLVfP44aad7yVfnnIbBiWWZQDlL+0IbEHVFexNY88DyDBtIKnkoBuc3 B9iTHy/zDVPctK+VYwk96rpNScnZVcPiF3nf5lTInI81JWFnDsMWDOmC/LNt+3yNQx uKy7CNAlsmTxJqCJw0QMrYBMty7MFjOQhzzRJkmA= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 06M05D0m058564 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 21 Jul 2020 19:05:13 -0500 Received: from DLEE113.ent.ti.com (157.170.170.24) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 21 Jul 2020 19:05:13 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 21 Jul 2020 19:05:13 -0500 Received: from [10.250.35.192] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 06M05DVv046850; Tue, 21 Jul 2020 19:05:13 -0500 Subject: Re: [PATCH v31 03/12] leds: lp50xx: Add the LP50XX family of the RGB LED driver To: Pavel Machek References: <20200716182007.18389-1-dmurphy@ti.com> <20200716182007.18389-4-dmurphy@ti.com> <20200721210724.GD5966@amd> From: Dan Murphy Message-ID: <59d0a02c-cfae-1170-728d-2ae332a81f6e@ti.com> Date: Tue, 21 Jul 2020 19:05:13 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200721210724.GD5966@amd> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200721_200516_120180_9C16562D X-CRM114-Status: GOOD ( 14.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, robh@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, marek.behun@nic.cz, jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Pavel On 7/21/20 4:07 PM, Pavel Machek wrote: > On Thu 2020-07-16 13:19:58, Dan Murphy wrote: >> Introduce the LP5036/30/24/18/12/9 RGB LED driver. >> The difference in these parts are the number of >> LED outputs where the: >> >> LP5036 can control 36 LEDs >> LP5030 can control 30 LEDs >> LP5024 can control 24 LEDs >> LP5018 can control 18 LEDs >> LP5012 can control 12 LEDs >> LP5009 can control 9 LEDs >> >> The device has the ability to group LED output into control banks >> so that multiple LED banks can be controlled with the same mixing and >> brightness. Inversely the LEDs can also be controlled independently. >> >> Acked-by: Jacek Anaszewski >> Signed-off-by: Dan Murphy >> +/* >> + * struct lp50xx_chip_info - >> + * @num_leds: number of LED outputs available on the device >> + * @led_brightness0_reg: first brightness register of the device >> + * @mix_out0_reg: first color mix register of the device >> + * @bank_brt_reg: bank brightness register >> + * @bank_mix_reg: color mix register >> + * @reset_reg: device reset register >> + */ > Should have /** if this is kerneldoc. > >> + init_data.fwnode = child; >> + num_colors = 0; >> + >> + /* There are only 3 LEDs per module otherwise they should be >> + * banked which also is presented as 3 LEDs >> + */ > This is not usual comment style for kernel. (And add . at end of > sentence). I will fix both. Dan > Best regards, > Pavel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel