Re: [PATCH v2 2/7] scan: rework BSS ranking

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1326 bytes --]

Hi James,

On 5/7/21 3:26 PM, James Prestwood wrote:
> It was observed that IWD's ranking for BSS's did not always
> end up with the fastest being chosen. This was due to IWD's
> heavy weight on signal strength. This is a decent way of ranking
> but even better is calculating a theoretical data rate which
> was also done and factored in. The problem is the data rate
> factor was always outdone by the signal strength.
> 
> Intead remove signal strength entirely as this is already taken
> into account with the data rate calculation. This also removes
> the check for rate IEs. If no IEs are found the parser will
> base the data rate soley on RSSI.
> 
> There were a few other factors removed which will be added back
> when ranking *networks* rather than BSS's. WPA version (or open)
> was removed as well as the privacy capability. These values really
> should not differ between BSS's in the same SSID and as such
> should be used for network ranking instead.
> ---
>   src/scan.c | 63 ++++++++++++++----------------------------------------
>   1 file changed, 16 insertions(+), 47 deletions(-)
> 
> v2:
>   * Added support for BSS's that did not have any rate IEs by
>     using the same ie_parse_data_rates
> 

I went ahead and applied the rest of this series (2-4).

Regards,
-Denis