From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70D46C433F5 for ; Thu, 14 Apr 2022 18:17:24 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.305013.519808 (Exim 4.92) (envelope-from ) id 1nf41k-0005ct-6b; Thu, 14 Apr 2022 18:17:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 305013.519808; Thu, 14 Apr 2022 18:17:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nf41k-0005cm-3X; Thu, 14 Apr 2022 18:17:08 +0000 Received: by outflank-mailman (input) for mailman id 305013; Thu, 14 Apr 2022 18:17:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nf41i-0005cg-R0 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 18:17:06 +0000 Received: from ppsw-31.csi.cam.ac.uk (ppsw-31.csi.cam.ac.uk [131.111.8.131]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 162bfc9c-bc1f-11ec-a405-831a346695d4; Thu, 14 Apr 2022 20:17:05 +0200 (CEST) Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:42386) by ppsw-31.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25) with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1nf41g-000Tx9-Ja (Exim 4.95) (return-path ); Thu, 14 Apr 2022 19:17:04 +0100 Received: from [192.168.1.10] (host-92-26-109-251.as13285.net [92.26.109.251]) (Authenticated sender: amc96) by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id CD77A1FA77; Thu, 14 Apr 2022 19:17:03 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 162bfc9c-bc1f-11ec-a405-831a346695d4 X-Cam-AntiVirus: no malware found X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus Message-ID: <59eab45c-ea10-b7b6-d78d-5ea4b6213246@srcf.net> Date: Thu, 14 Apr 2022 19:17:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-GB To: Anthony PERARD , Andrew Cooper Cc: Xen-devel , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <20220414162348.4808-1-andrew.cooper3@citrix.com> From: Andrew Cooper Subject: Re: [PATCH] xen/build: Fix dependency for the MAP rule In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 14/04/2022 18:49, Anthony PERARD wrote: > On Thu, Apr 14, 2022 at 05:23:48PM +0100, Andrew Cooper wrote: >> diff --git a/xen/Makefile b/xen/Makefile >> index dd05672ff42d..02a274f56dc0 100644 >> --- a/xen/Makefile >> +++ b/xen/Makefile >> @@ -599,7 +599,7 @@ cscope: >> cscope -k -b -q >> >> .PHONY: _MAP >> -_MAP: >> +_MAP: $(TARGET)-syms > That's not going to work well as make isn't going to know how to build > $(TARGET)-syms. Huh... It appears to work for me, but it's parallel build so who knows. > I guess you want to have $(TARGET) as prerequisite or > add somewhere "$(TARGET)-syms: $(TARGET)". That becomes cyclic with arch/*/Makefile which has: $(TARGET): $(TARGET)-syms The _install rule does make the implication that a dependency on $(TARGET) builds $(TARGET)-syms so I guess that's good enough for _MAP too. ~Andrew