From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E2DBC433EF for ; Sat, 23 Oct 2021 08:41:04 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60E2D60FC1 for ; Sat, 23 Oct 2021 08:41:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 60E2D60FC1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3BC3283318; Sat, 23 Oct 2021 10:41:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="cah+dHwt"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8BC41833D4; Sat, 23 Oct 2021 10:40:58 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2C66F83303 for ; Sat, 23 Oct 2021 10:40:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1634978453; bh=qlCCJIk4P771XtsEpP3jYXt7kU9+MuJ0Wfd8BT07qiM=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=cah+dHwta0R9Gh05pvy5vdv6gTVSw4fyc7JWE0ReYI8miI6I1lmgGbYDh2BpDu+Co aGc4RpFgpmsJaTR5xRDGY0QsB3rToXrAK0fiR2RKMKs+Z3UWZcd1aNMubyv605uPQw Db/wXn52uN6maIe4mRsd+G38z7IZSnzgn40jBej8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.35] ([88.152.144.157]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MQMyf-1mHsVI1ycr-00MM6V; Sat, 23 Oct 2021 10:40:53 +0200 Message-ID: <59f7db9e-3c8e-2eba-f908-01d4822b4bcf@gmx.de> Date: Sat, 23 Oct 2021 10:40:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCH 1/2] efi_loader: add missing const qualifier Content-Language: en-US To: Masahisa Kojima , u-boot@lists.denx.de Cc: Ilias Apalodimas , Simon Glass , Alexander Graf References: <20211022112426.25009-1-masahisa.kojima@linaro.org> <20211022112426.25009-2-masahisa.kojima@linaro.org> From: Heinrich Schuchardt In-Reply-To: <20211022112426.25009-2-masahisa.kojima@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:odmyHyArlvLZbgCcSefrISjEzFHLX5uUpEtSVWVr2SjgZ8oJFYy 4Iaio7kAThpZG7yScMSql1pdgclXWvNOuEt7ZoP+YzyFHdyWOZcZA/k66whFfb5nhuibUgT SpYpa7GaoWil2cy36b8I1ekZFgs7bSZhpOryUaDgNPXDDW3OxhIm5wLGmCllgxNzSxoip7f fbx6+7qawb2GyTl3uI9zQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:NP1rltCbCBs=:2HtxSIOdfiix58xwWQHq5u GPfVbFMF+B+pMo8W7e1ifBfHtBrVzWW/WPZvIGS3XSfbwk+0DXMCv5zqW5nMS/8wY9M2JITNi QB9jgBrhauDRhwOTCjG6RRwJgOPHFQHUh8kcJv+HRjG1UjuBZpXrkuxGubwX8JvBvUekp+h7E UOpnADUTiVGGupbU+KbGhmsRyLz7eqClny7f3DVZzrE6d7uKX6Hjn7XYD3Ke/hh9XqcfQzelS Y0al/2+yxoRZ9XfTc+kqicpp6G6qOSk7XAVjB1xXFJ4Er2DYelF+E+E6G4d6njmcoCyyqCwGv 3kjN6aWY8ylgC1rZJHzZ22KnupXXXpvh3vMWJSxw5vPHs6nwecI0GJuYn1lK5+pUJQSYP6qq3 /Svk3q9nVomuNNeNqTDXGPIIiwGWmBPVs7VXAAHby75nCWbLEsffmcMLKnvUVQr7+sSiBAlBw dkLorChDaA17IQt2JGjHGfNLvX7ICBfvNKWYfzJ8aB9akqNpEds+e3ogb1kNfcoJvjLqoBqkr 7PT9Hj7ncZ3dfCxyxHcEYdZdF7+vLBIf0sX1elUwQ+CD/+h9qryM2AxSt/dtncqao5k9L1I4m LUwbC9tGQkluo0iYO2fu337V+k6FLOeHdYaGt9sCwgzv5aglNrKR3CZFANARMQYKfqmYRJ6Nw lq6H8DvStLvSj9y5QEkoOjCi58ohItN3IcXQoKYBihFnPW7K1b4nKQO/PbhMrPo2NAaVtaSm2 m28wRLDHKZOlUkwSbOzqbKIX49uTloVJZMqFv3AL8qKSZsie/qgMBG9GrVLtXjoX5SqjauXPj 4AHbtfXV6dXQ4Th1SGQtbq6gFN0ggh1GroA5VqajZ/I2njMDOUGMfp9TQvrYIGaCXz2PGB4aD 4LUadQjGY+Uz9oZX5Plejyy09ZJhhq7P3nnLY1oO6rO4MNcDGI4dFgvb3mWIQUX84zdGZ1/qf 5bVNXvhftBfr2blJ0uSsc07Ce0pUs7IdLlv9/ThFn9rUmIZSZsoPllbdZ+BAED2j1hX9NTcVK At6eCDKjgM2c9/gsEaIFY8rqu4GDulasXsiZ4RwjNUeQSyvu0swOFJsxDq7uwYH13vWBEjaen dsdnjsKKdyHhcE= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 10/22/21 13:24, Masahisa Kojima wrote: > This commit fixes the following compilation warning > of boottime->install_configuration_table() function. > > --- > lib/efi_selftest/efi_selftest_tcg2.c:475:46: > warning: passing argument 1 of =E2=80=98boottime->install_configuration_= table=E2=80=99 > discards =E2=80=98const=E2=80=99 qualifier from pointer target type [-Wd= iscarded-qualifiers] > ret =3D boottime->install_configuration_table(&smbios_guid, dmi); > --- > > Signed-off-by: Masahisa Kojima The first --- separates the commit message from the rest of the patch: $ scripts/checkpatch.pl 0001-efi_loader-add-missing-const-qualifier.patch ERROR: Missing Signed-off-by: line by nominal patch author 'Masahisa Kojima ' I will reformat the commit message when merging. Reviewed-by: Heinrich Schuchardt > --- > include/efi_api.h | 2 +- > lib/efi_loader/efi_boottime.c | 5 +++-- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/include/efi_api.h b/include/efi_api.h > index c8f959bb72..0accad08c8 100644 > --- a/include/efi_api.h > +++ b/include/efi_api.h > @@ -120,7 +120,7 @@ struct efi_boot_services { > struct efi_device_path **device_path, > efi_handle_t *device); > efi_status_t (EFIAPI *install_configuration_table)( > - efi_guid_t *guid, void *table); > + const efi_guid_t *guid, void *table); > > efi_status_t (EFIAPI *load_image)(bool boot_policiy, > efi_handle_t parent_image, > diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime= .c > index bf5661e1ee..1823990d9b 100644 > --- a/lib/efi_loader/efi_boottime.c > +++ b/lib/efi_loader/efi_boottime.c > @@ -1692,8 +1692,9 @@ out: > * > * Return: status code > */ > -static efi_status_t EFIAPI efi_install_configuration_table_ext(efi_guid= _t *guid, > - void *table) > +static efi_status_t > +EFIAPI efi_install_configuration_table_ext(const efi_guid_t *guid, > + void *table) > { > EFI_ENTRY("%pUl, %p", guid, table); > return EFI_EXIT(efi_install_configuration_table(guid, table)); >