Re: [Qemu-devel] [PATCH v2 2/6] s390x/vfio: ap: Use the APdevice as a child of the APBus

From: Pierre Morel <pmorel@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>, Tony Krowiak <akrowiak@linux.ibm.com>
Cc: borntraeger@de.ibm.com, agraf@suse.de, rth@twiddle.net,
	david@redhat.com, qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
	peter.maydell@linaro.org, pbonzini@redhat.com, mst@redhat.com,
	eric.auger@redhat.com, pasic@linux.ibm.com
Subject: Re: [Qemu-devel] [PATCH v2 2/6] s390x/vfio: ap: Use the APdevice as a child of the APBus
Date: Thu, 29 Nov 2018 17:26:21 +0100	[thread overview]
Message-ID: <59ff9eab-918c-9e5f-b21f-26885f296d1b@linux.ibm.com> (raw)
In-Reply-To: <20181129161044.5b153ab0.cohuck@redhat.com>

On 29/11/2018 16:11, Cornelia Huck wrote:
> On Thu, 29 Nov 2018 10:02:24 -0500
> Tony Krowiak <akrowiak@linux.ibm.com> wrote:
> 
>> On 11/29/18 6:45 AM, Cornelia Huck wrote:
>>> On Thu, 22 Nov 2018 17:35:51 +0100
>>> Pierre Morel <pmorel@linux.ibm.com> wrote:
> 
>>>> diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
>>>> index 65de952..94e5a1a 100644
>>>> --- a/hw/vfio/ap.c
>>>> +++ b/hw/vfio/ap.c
>>>> @@ -35,9 +35,6 @@ typedef struct VFIOAPDevice {
>>>>        VFIODevice vdev;
>>>>    } VFIOAPDevice;
>>>>    
>>>> -#define VFIO_AP_DEVICE(obj) \
>>>> -        OBJECT_CHECK(VFIOAPDevice, (obj), VFIO_AP_DEVICE_TYPE)
>>>
>>> Hm?
>>
>> I received a comment from Thomas Huth in Message ID
>> <2291104a-4cbf-e4fd-3496-fa0910beb96a@redhat.com>
>> that DO_UPCAST should be avoided in new code. This macro
>> should probably be restored and an AP_DEVICE() macro added.
> 
> Yes, that makes sense.
> 

Yes,
Thanks

Pierre

-- 
Pierre Morel
Linux/KVM/QEMU in Böblingen - Germany