Re: [PATCH for-next 3/9] gcov: rename sysctl and functions

From: "Jan Beulich" <JBeulich@suse.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH for-next 3/9] gcov: rename sysctl and functions
Date: Tue, 07 Nov 2017 10:13:37 -0700	[thread overview]
Message-ID: <5A01F7D1020000780018CFB7@prv-mh.provo.novell.com> (raw)
In-Reply-To: <20171026091938.59247-4-roger.pau@citrix.com>

>>> On 26.10.17 at 11:19, <roger.pau@citrix.com> wrote:
> --- a/xen/include/public/sysctl.h
> +++ b/xen/include/public/sysctl.h
> @@ -646,11 +646,11 @@ struct xen_sysctl_scheduler_op {
>  
>  #define XEN_GCOV_FORMAT_MAGIC    0x58434f56 /* XCOV */
>  
> -#define XEN_SYSCTL_GCOV_get_size 0 /* Get total size of output data */
> -#define XEN_SYSCTL_GCOV_read     1 /* Read output data */
> -#define XEN_SYSCTL_GCOV_reset    2 /* Reset all counters */
> +#define XEN_SYSCTL_COV_get_size 0 /* Get total size of output data */
> +#define XEN_SYSCTL_COV_read     1 /* Read output data */
> +#define XEN_SYSCTL_COV_reset    2 /* Reset all counters */
>  
> -struct xen_sysctl_gcov_op {
> +struct xen_sysctl_cov_op {
>      uint32_t cmd;
>      uint32_t size; /* IN/OUT: size of the buffer  */
>      XEN_GUEST_HANDLE_64(char) buffer; /* OUT */
> @@ -1065,7 +1065,7 @@ struct xen_sysctl {
>  #define XEN_SYSCTL_numainfo                      17
>  #define XEN_SYSCTL_cpupool_op                    18
>  #define XEN_SYSCTL_scheduler_op                  19
> -#define XEN_SYSCTL_gcov_op                       20
> +#define XEN_SYSCTL_cov_op                        20
>  #define XEN_SYSCTL_psr_cmt_op                    21
>  #define XEN_SYSCTL_pcitopoinfo                   22
>  #define XEN_SYSCTL_psr_cat_op                    23
> @@ -1095,7 +1095,7 @@ struct xen_sysctl {
>          struct xen_sysctl_lockprof_op       lockprof_op;
>          struct xen_sysctl_cpupool_op        cpupool_op;
>          struct xen_sysctl_scheduler_op      scheduler_op;
> -        struct xen_sysctl_gcov_op           gcov_op;
> +        struct xen_sysctl_cov_op            cov_op;
>          struct xen_sysctl_psr_cmt_op        psr_cmt_op;
>          struct xen_sysctl_psr_cat_op        psr_cat_op;
>          struct xen_sysctl_tmem_op           tmem_op;

While for internal things "cov" is probably fine for now, for the
public interface I think I would prefer it to be a little longer,
perhaps even fully spelled out "coverage".

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel