From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754101AbdKOHZn (ORCPT ); Wed, 15 Nov 2017 02:25:43 -0500 Received: from mga11.intel.com ([192.55.52.93]:36560 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753470AbdKOHZg (ORCPT ); Wed, 15 Nov 2017 02:25:36 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,398,1505804400"; d="scan'208";a="5134265" Subject: Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver To: Felipe Balbi , Mathias Nyman , Greg Kroah-Hartman References: <1504576740-11689-1-git-send-email-baolu.lu@linux.intel.com> <1504576740-11689-3-git-send-email-baolu.lu@linux.intel.com> <87shdhb9ou.fsf@linux.intel.com> Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Lu Baolu Message-ID: <5A0BEBEB.8030501@linux.intel.com> Date: Wed, 15 Nov 2017 15:25:31 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <87shdhb9ou.fsf@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 11/14/2017 03:28 PM, Felipe Balbi wrote: > Hi, > > Mathias Nyman writes: >>> +static int dbc_buf_alloc(struct dbc_buf *db, unsigned int size) >>> +{ >>> + db->buf_buf = kzalloc(size, GFP_KERNEL); >>> + if (!db->buf_buf) >>> + return -ENOMEM; >>> + >>> + db->buf_size = size; >>> + db->buf_put = db->buf_buf; >>> + db->buf_get = db->buf_buf; >>> + >>> + return 0; >>> +} > you may wanna have a look at kfifo. > Yeah! kfifo gives me exactly what I want here. I will replace it with kfifo. Thank you. Best regards, Lu Baolu