From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751307AbdKVFN4 (ORCPT ); Wed, 22 Nov 2017 00:13:56 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:25151 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003AbdKVFNy (ORCPT ); Wed, 22 Nov 2017 00:13:54 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20171122051351epoutp04bf7e47af4dceb953ef88592b1e3f18cc~5UHlRxY5L2195521955epoutp04B X-AuditID: b6c32a36-3d5ff7000000117d-9e-5a15078ff6bf MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="UTF-8" Message-id: <5A150792.6050104@samsung.com> Date: Wed, 22 Nov 2017 14:13:54 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Joe Perches , MyungJoo Ham , Kyungmin Park Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] rk3399_dmc: Fix line continuation format In-reply-to: <7d659960e45f66894126fba9e2d54cf25ae1185b.1510845910.git.joe@perches.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrKKsWRmVeSWpSXmKPExsWy7bCmvm4/u2iUwclf8haz7z9msTjb9Ibd 4vKuOWwWn3uPMFrcblzB5sDq8WXVNWaPvi2rGD0+b5ILYI5KtclITUxJLVJIzUvOT8nMS7dV 8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1y8wBWqmkUJaYUwoUCkgsLlbSt7Mpyi8tSVXI yC8usVWKNjQ00jM0MNczMjLSMzGOtTIyBSpJSM14sEe+oIezouvGZ8YGxg3sXYycHBICJhL7 9i5g62Lk4hAS2MEo8eBnNyuE851R4kNrGxtM1ac9c6GqNjBKPH4zgxkkwSsgKPFj8j2WLkYO DmYBeYkjl7JBwswCmhJbd69nh6i/xyhx4N0JFoh6LYnfVy8ygtgsAqoSV3ddBbPZgOL7X9wA W8YvoChx9cdjsLioQITEzvnf2EHmiwiUSyw56wUx30ri9cdusA+EBRwllj/8D1bOCVS+Y9sH FpC9EgIr2CT+nP4CdpuEgIvE90n2EL8IS7w6voUdIiwtcemoLUR5O6PE5jn3oHo7GCXur2xk hWgwljjV1cgEsZhP4t3XHlaIZl6JjjYhiBIPifZvf6Bh5Sixf/d7aFhdAgbinIMsExjlZiEF 1yxEcM1CCq4FjMyrGMVSC4pz01OLDQuM9IoTc4tL89L1kvNzNzGCk5iW2Q7GRed8DjEKcDAq 8fA6JIhECbEmlhVX5h5ilOBgVhLhdY8BCvGmJFZWpRblxxeV5qQWH2I0BYb2RGYp0eR8YILN K4k3NLE0MDEzAiYuS0NDJXFe0fXXIoQE0hNLUrNTUwtSi2D6mDg4pRoYTQKm8AnPYYn6pvPc /Gq9uHTOhnOvw53yUq+ucLc4meDzX9qeNd6UfU//xH0iy8OtNf1nf3z7sPn0qjCt5Oi7caEv F3IEzio4//mO2L6HCwoWZjzYdvTVxHcHQk9vXmE9SULUoZzL9KxRdZG1jQdr0nQDl5ir0UdN L37W7zh9MeTjtxXRUx+nKrEUZyQaajEXFScCAMgqEfx4AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJLMWRmVeSWpSXmKPExsVy+t9jQd1+dtEog9bFnBaz7z9msTjb9Ibd 4vKuOWwWn3uPMFrcblzB5sDq8WXVNWaPvi2rGD0+b5ILYI7isklJzcksSy3St0vgyniwR76g h7Oi68ZnxgbGDexdjJwcEgImEp/2zGXrYuTiEBJYxyixfetdFpAEr4CgxI/J94BsDg5mAXmJ I5eyQcLMAuoSk+YtYoaof8AocffsVjaIei2J31cvMoLYLAKqEld3XQWz2YDi+1/cAKvhF1CU uPrjMSPITFGBCInuE5UgYRGBconNR/eyQMy3knj9sRvsNmEBR4nlD/8zQuy6xCjR3boMrIgT qLdp8zumCYwCs5CcOgvh1FlITl3AyLyKUTK1oDg3PbfYqMAwL7Vcrzgxt7g0L10vOT93EyMw gLcd1urbwXh/SfwhRgEORiUe3hlJIlFCrIllxZW5hxglOJiVRHjdY4BCvCmJlVWpRfnxRaU5 qcWHGKU5WJTEeW/nHYsUEkhPLEnNTk0tSC2CyTJxcEo1MIY/r5dI5+pRshS9wv1hBdORK2bb wpP+KW/bfC1Yz6qp5vXkuRE3V/l/ZBWtaNjh8t7VfDKXBdd2a5uzsh93ztsV/XUPj9g3l3cz G/gmspc6/zUN6GbakH+kzUwuvP3FvTvtBibzfdm5zrLcW3umpb3t9NWdRSd23bvaFbArpduq k/XJ6RnzO5RYijMSDbWYi4oTAa3shaVcAgAA X-CMS-MailID: 20171122051351epcas1p1989aab69570dd446482b50594d678a3a X-Msg-Generator: CA CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171116152742epcas2p22b17887a4d7f2adcd3beb414988dbce3 X-RootMTR: 20171116152742epcas2p22b17887a4d7f2adcd3beb414988dbce3 References: <7d659960e45f66894126fba9e2d54cf25ae1185b.1510845910.git.joe@perches.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017년 11월 17일 00:27, Joe Perches wrote: > Line continuations with excess spacing causes unexpected output. > > Signed-off-by: Joe Perches > --- > drivers/devfreq/rk3399_dmc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c > index 5dfbfa3cc878..0938c97d46f0 100644 > --- a/drivers/devfreq/rk3399_dmc.c > +++ b/drivers/devfreq/rk3399_dmc.c > @@ -146,8 +146,8 @@ static int rk3399_dmcfreq_target(struct device *dev, unsigned long *freq, > > /* If get the incorrect rate, set voltage to old value. */ > if (dmcfreq->rate != target_rate) { > - dev_err(dev, "Get wrong ddr frequency, Request frequency %lu,\ > - Current frequency %lu\n", target_rate, dmcfreq->rate); > + dev_err(dev, "Get wrong ddr frequency, Request frequency %lu, Current frequency %lu\n", > + target_rate, dmcfreq->rate); IMO, I don't like over 80 char in the one line. > regulator_set_voltage(dmcfreq->vdd_center, dmcfreq->volt, > dmcfreq->volt); > goto out; > -- Best Regards, Chanwoo Choi Samsung Electronics