From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752239AbdKWCM2 (ORCPT ); Wed, 22 Nov 2017 21:12:28 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:27713 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751742AbdKWCM0 (ORCPT ); Wed, 22 Nov 2017 21:12:26 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20171123021224epoutp017a2700f4f4e85841d8f2c89d0474107a~5lSbmOdjF0271902719epoutp01k X-AuditID: b6c32a36-3d5ff7000000117d-7c-5a162e87033b MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="utf-8" Message-id: <5A162E8A.3040207@samsung.com> Date: Thu, 23 Nov 2017 11:12:26 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Joe Perches , myungjoo.ham@samsung.com, Kyungmin Park Cc: "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/4] rk3399_dmc: Fix line continuation format In-reply-to: <1511402826.2385.3.camel@perches.com> X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTcRjG+Xu245RWx3npj4LOE35QcO7MqVM0NKWEBE0JliF2mIdt6i6d s4n6QTTywiypjALvCpYbhfewFMwb3liQmmaRFkpKZCbaNBNq2yny23Oe/+89D8/Ly0MEn7m+ PLXWQNFaMh9H3TnPxoLDQitFPpni7sEYWf3qGkdmvfHVVTb/ogGV7d4eB7L3ZR1oPDd5z7KI JNf0WUDybo9/GpJJxaooMoeihZRWoctRa5Vx+MWM7MTsiEgxEUpEy6JwoZbUUHF4Ukpa6Hl1 vj0SFxaQ+Ua7lUYyDB52NpbWGQ2UUKVjDHH4VYKQiAhxlEgikYik4Vkxkgg7co1SrY3OoPom r8Kh+1tIKbBiJuDGg5gUHuyUc03AnSfABgC01T9FHQ8CbB/AreYwE+A5oWqzgGUGARxZanUy fMwDHtSucBwMggXA8bk8h41gwXBz7x6H5VcA/LjxgMvyIXC2dg1xaA4WBK2TU04ftfvDm2+d /zyFBcI3B2vAob0xOXzebHN1aC9MBQ/r+gEbUAxnX5uds55YAnz86bfTd8MksGlswVkGYk9Q uG7ZQdmWSXB604Sw2hN+mexzZYv5wbmJOJavBLC3YYXDflQBuGou47ID4XDGVObCJp+E337c 4rLDfFhVIWCRZFhpO/qblQCHB7dRtn09Atttja53gH/dsYXV/V9Y3bGFtQDEAnwoPaNRUgyh l4gYUsMYtUqRQqfpAc4bC4kcAG2vUkYBxgP4CX5Hg3emgEsWMEWaUQB5CO7Fz2ixW/wcsqiY onXZtDGfYkZBhH3fdxFfb4XOfrFaQzYhjRZLIyX264omCPw037tzUS7AlKSByqMoPUX/m3Ph ufmWAuE2rZ8IOIg2mZfapw73cnMjdx4pFw/P7KcmLt+ccOk0z49ELceiq8GpKbk59HpfyaXW jXNnLu9F9P4cutI3/PCCfLq6scsv/nt3YPzL0rEj//SwocWM8pGFoXcVWeMfdEH7UoUiKlTV 7yHbLrQFlcjbrHk9cFb8qytdXSP2u45zGBVJhCA0Q/4B9BdsZXkDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOLMWRmVeSWpSXmKPExsVy+t9jAd12PbEog1drFCxm33/MYnG26Q27 xeVdc9gsPvceYbS43biCzYHV48uqa8wefVtWMXp83iQXwBzFZZOSmpNZllqkb5fAlfH40Cm2 gnkiFXumvGVuYDwr0MXIwSEhYCLRvVKoi5GLQ0hgJ6NEx9UpbF2MnBy8AoISPybfYwGpYRaQ lzhyKRvCVJeYMiUXovwBo8SkRx/ZIcq1JE5PfswMYrMIqEqcPX6CFcRmA4rvf3EDbCS/gKLE 1R+PGUHmiApESHSfqAQJiwhkSHRfec8EYjMLVEns3r0JrFxYwFFi+cP/jBC7ZjNLdJ37C7aL U8BIYt7hK6wTGAVmIbl0FsKlsxAuXcDIvIpRMrWgODc9t9iowDAvtVyvODG3uDQvXS85P3cT IzB4tx3W6tvBeH9J/CFGAQ5GJR5ehvmiUUKsiWXFlbmHGCU4mJVEeIMXAIV4UxIrq1KL8uOL SnNSiw8xSnOwKInz3s47FikkkJ5YkpqdmlqQWgSTZeLglGpgbDhW8spSqyFjbrTOtPet+6a5 bd0699V22c0HctqzLlpaJiiK33+cxp9211pDrE/T612KQejPazOO/EiTebJB99nzLbK5Acqv ND917Q/gNXjO3v2t7vDeQ5ItXdzrjQz6L6d15YvGRc55/OXN/EVJqn0afFbLT2lpsR1Klc+4 uePO3feiv/XvK7EUZyQaajEXFScCALTtVZZaAgAA X-CMS-MailID: 20171123021223epcas1p3320d0be4d764f734db8384a8fa63f1e5 X-Msg-Generator: CA CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171116152742epcas2p22b17887a4d7f2adcd3beb414988dbce3 X-RootMTR: 20171116152742epcas2p22b17887a4d7f2adcd3beb414988dbce3 References: <1511347280.6989.81.camel@perches.com> <7d659960e45f66894126fba9e2d54cf25ae1185b.1510845910.git.joe@perches.com> <5A150792.6050104@samsung.com> <20171123012100epcms1p13f78950557de06dbbd65996c8b0645ee@epcms1p1> <5A162835.5050806@samsung.com> <1511402826.2385.3.camel@perches.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017년 11월 23일 11:07, Joe Perches wrote: > On Thu, 2017-11-23 at 10:45 +0900, Chanwoo Choi wrote: >> On 2017년 11월 23일 10:21, MyungJoo Ham wrote: >>>> On Wed, 2017-11-22 at 14:13 +0900, Chanwoo Choi wrote: >>>>> On 2017년 11월 17일 00:27, Joe Perches wrote: >>>>>> Line continuations with excess spacing causes unexpected output. >>>>>> >>>>>> Signed-off-by: Joe Perches >>>>>> --- >>>>>> drivers/devfreq/rk3399_dmc.c | 4 ++-- >>>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>>> >>>>>> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c >>>>>> index 5dfbfa3cc878..0938c97d46f0 100644 >>>>>> --- a/drivers/devfreq/rk3399_dmc.c >>>>>> +++ b/drivers/devfreq/rk3399_dmc.c >>>>>> @@ -146,8 +146,8 @@ static int rk3399_dmcfreq_target(struct device *dev, unsigned long *freq, >>>>>> >>>>>> /* If get the incorrect rate, set voltage to old value. */ >>>>>> if (dmcfreq->rate != target_rate) { >>>>>> - dev_err(dev, "Get wrong ddr frequency, Request frequency %lu,\ >>>>>> - Current frequency %lu\n", target_rate, dmcfreq->rate); >>>>>> + dev_err(dev, "Get wrong ddr frequency, Request frequency %lu, Current frequency %lu\n", >>>>>> + target_rate, dmcfreq->rate); >>>>> >>>>> IMO, I don't like over 80 char in the one line. >>>> >>>> Fix it as you chose, but the code I proposed >>>> is what is preferred by CodingStyle. >>>> >>>> The current code is unintentional. >>>> >>>> Right now there are 3 tabs between "Request frequency" >>>> and "Current frequency" in the output. >>> >>> Chanwoo, this is not a simple coding style issue. >>> I'm seeing these unintentional tabs as well. >>> >>> >>> If you want to keep it 80 cols with strings (which is r mandatory for strings in double quotes), >>> We'd better do: >>> >>> - dev_err(dev, "Get wrong ddr frequency, Request frequency %lu,\ >>> - Current frequency %lu\n", target_rate, dmcfreq->rate); >>> + dev_err(dev, "Get wrong ddr frequency, Request frequency %lu," >>> + " Current frequency %lu\n", target_rate, dmcfreq->rate); >> >> I agree with Myungjoo's opinion. >> I think the readability is important. So, I prefer to keep one line within 80 char. > > Read Documentation/process/coding-style.rst > > What I proposed is by far the common style. > I think you should get used to it. Read line.81 in the Documentation/process/coding-style.rst - "2) Breaking long lines and strings" Or, we better to modify the error message within 80 char. -- Best Regards, Chanwoo Choi Samsung Electronics