* [PATCH 1/1] Input: ims-pcu - fix typo in an error log
@ 2017-11-24 6:59 Zhen Lei
2017-11-24 7:17 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Zhen Lei @ 2017-11-24 6:59 UTC (permalink / raw)
To: Dmitry Torokhov, linux-input, linux-kernel
Cc: Hanjun Guo, Libin, Kefeng Wang, Zhen Lei
Tiny typo fixed in an error log.
I found this when I backported the CVE-2017-16645 patch:
ea04efee7635 ("Input: ims-psu - check if CDC union descriptor is sane")
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/input/misc/ims-pcu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c
index ae47312..253ae8e 100644
--- a/drivers/input/misc/ims-pcu.c
+++ b/drivers/input/misc/ims-pcu.c
@@ -1651,7 +1651,7 @@ static void ims_pcu_buffers_free(struct ims_pcu *pcu)
return union_desc;
dev_err(&intf->dev,
- "Union descriptor to short (%d vs %zd\n)",
+ "Union descriptor too short (%d vs %zd\n)",
union_desc->bLength, sizeof(*union_desc));
return NULL;
}
--
1.8.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] Input: ims-pcu - fix typo in an error log
2017-11-24 6:59 [PATCH 1/1] Input: ims-pcu - fix typo in an error log Zhen Lei
@ 2017-11-24 7:17 ` Joe Perches
2017-11-24 7:49 ` Leizhen (ThunderTown)
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2017-11-24 7:17 UTC (permalink / raw)
To: Zhen Lei, Dmitry Torokhov, linux-input, linux-kernel
Cc: Hanjun Guo, Libin, Kefeng Wang
On Fri, 2017-11-24 at 14:59 +0800, Zhen Lei wrote:
> Tiny typo fixed in an error log.
>
> I found this when I backported the CVE-2017-16645 patch:
> ea04efee7635 ("Input: ims-psu - check if CDC union descriptor is sane")
>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> drivers/input/misc/ims-pcu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c
[]
> @@ -1651,7 +1651,7 @@ static void ims_pcu_buffers_free(struct ims_pcu *pcu)
> return union_desc;
>
> dev_err(&intf->dev,
> - "Union descriptor to short (%d vs %zd\n)",
> + "Union descriptor too short (%d vs %zd\n)",
And this format is incorrect too. It should be:
+ "Union descriptor too short (%d vs %zd)\n",
with the close parenthesis before the newline, not after.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] Input: ims-pcu - fix typo in an error log
2017-11-24 7:17 ` Joe Perches
@ 2017-11-24 7:49 ` Leizhen (ThunderTown)
0 siblings, 0 replies; 3+ messages in thread
From: Leizhen (ThunderTown) @ 2017-11-24 7:49 UTC (permalink / raw)
To: Joe Perches, Dmitry Torokhov, linux-input, linux-kernel
Cc: Hanjun Guo, Libin, Kefeng Wang
On 2017/11/24 15:17, Joe Perches wrote:
> On Fri, 2017-11-24 at 14:59 +0800, Zhen Lei wrote:
>> Tiny typo fixed in an error log.
>>
>> I found this when I backported the CVE-2017-16645 patch:
>> ea04efee7635 ("Input: ims-psu - check if CDC union descriptor is sane")
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>> drivers/input/misc/ims-pcu.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c
> []
>> @@ -1651,7 +1651,7 @@ static void ims_pcu_buffers_free(struct ims_pcu *pcu)
>> return union_desc;
>>
>> dev_err(&intf->dev,
>> - "Union descriptor to short (%d vs %zd\n)",
>> + "Union descriptor too short (%d vs %zd\n)",
>
> And this format is incorrect too. It should be:
>
> + "Union descriptor too short (%d vs %zd)\n",
>
> with the close parenthesis before the newline, not after.
You are very observant. Do I need to post v2? It seems that we can simply modify it directly.
>
>
> .
>
--
Thanks!
BestRegards
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-24 7:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-24 6:59 [PATCH 1/1] Input: ims-pcu - fix typo in an error log Zhen Lei
2017-11-24 7:17 ` Joe Perches
2017-11-24 7:49 ` Leizhen (ThunderTown)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.