From: "Jan Beulich" <JBeulich@suse.com>
To: Yang Zhong <yang.zhong@intel.com>
Cc: andrew.cooper3@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v3 3/4] x86emul: Support vaes insns
Date: Mon, 27 Nov 2017 09:30:15 -0700 [thread overview]
Message-ID: <5A1C4BA7020000780019274C@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1510310196-6485-4-git-send-email-yang.zhong@intel.com>
>>> On 10.11.17 at 11:36, <yang.zhong@intel.com> wrote:
> --- a/xen/arch/x86/x86_emulate/x86_emulate.c
> +++ b/xen/arch/x86/x86_emulate/x86_emulate.c
> @@ -1626,6 +1626,7 @@ static bool vcpu_has(
> #define vcpu_has_clwb() vcpu_has( 7, EBX, 24, ctxt, ops)
> #define vcpu_has_sha() vcpu_has( 7, EBX, 29, ctxt, ops)
> #define vcpu_has_gfni() vcpu_has( 7, ECX, 8, ctxt, ops)
> +#define vcpu_has_vaes() vcpu_has( 7, ECX, 9, ctxt, ops)
> #define vcpu_has_vpclmulqdq() vcpu_has( 7, ECX, 10, ctxt, ops)
> #define vcpu_has_rdpid() vcpu_has( 7, ECX, 22, ctxt, ops)
> #define vcpu_has_clzero() vcpu_has(0x80000008, EBX, 0, ctxt, ops)
> @@ -7345,6 +7346,12 @@ x86_emulate(
> host_and_vcpu_must_have(aesni);
> if ( vex.opcx == vex_none )
> goto simd_0f38_common;
> + if ( vex.l )
> + {
> + host_and_vcpu_must_have(vaes);
> + goto simd_0f_avx;
> + }
> +
> /* fall through */
Please move out the block no longer wanting this fall-through.
That'll also take care of vaesimc not becoming 256-bit enabled as
per the current version of the spec.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2017-11-27 16:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 10:36 [PATCH v3 0/4] x86/cpuid: enable new cpu features Yang Zhong
2017-11-10 10:36 ` [PATCH v3 1/4] x86emul: Support GFNI insns Yang Zhong
2017-11-27 15:42 ` Jan Beulich
2017-12-14 13:57 ` Yang Zhong
2017-11-10 10:36 ` [PATCH v3 2/4] x86emul: Support vpclmulqdq Yang Zhong
2017-11-27 15:53 ` Jan Beulich
2017-12-14 13:49 ` Yang Zhong
2017-11-10 10:36 ` [PATCH v3 3/4] x86emul: Support vaes insns Yang Zhong
2017-11-27 16:30 ` Jan Beulich [this message]
2017-12-14 13:40 ` Yang Zhong
2017-11-10 10:36 ` [PATCH v3 4/4] x86/cpuid: Enable new SSE/AVX/AVX512 cpu features Yang Zhong
2017-11-10 10:46 ` Jan Beulich
2017-11-10 10:44 ` [PATCH v3 0/4] x86/cpuid: enable new " Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A1C4BA7020000780019274C@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.