From: "Gang He" <ghe@suse.com> To: <jlbec@evilplan.org>, <jiangqi903@gmail.com>, <hch@lst.de>, "Goldwyn Rodrigues" <RGoldwyn@suse.com>, <mfasheh@versity.com> Cc: <ocfs2-devel@oss.oracle.com>, <linux-kernel@vger.kernel.org> Subject: Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function Date: Tue, 28 Nov 2017 00:24:50 -0700 [thread overview] Message-ID: <5A1D7FC2020000F90009AD91@prv-mh.provo.novell.com> (raw) In-Reply-To: <805fb849-dcc7-cbbc-02af-1c6116a88957@gmail.com> Hello Joseph, >>> > > On 17/11/28 11:35, Gang He wrote: >> Hello Joseph, >> >> >>>>> >>> Hi Gang, >>> >>> On 17/11/27 17:46, Gang He wrote: >>>> Add ocfs2_overwrite_io function, which is used to judge if >>>> overwrite allocated blocks, otherwise, the write will bring extra >>>> block allocation overhead. >>>> >>>> Signed-off-by: Gang He <ghe@suse.com> >>>> --- >>>> fs/ocfs2/extent_map.c | 67 >>> +++++++++++++++++++++++++++++++++++++++++++++++++++ >>>> fs/ocfs2/extent_map.h | 3 +++ >>>> 2 files changed, 70 insertions(+) >>>> >>>> diff --git a/fs/ocfs2/extent_map.c b/fs/ocfs2/extent_map.c >>>> index e4719e0..98bf325 100644 >>>> --- a/fs/ocfs2/extent_map.c >>>> +++ b/fs/ocfs2/extent_map.c >>>> @@ -832,6 +832,73 @@ int ocfs2_fiemap(struct inode *inode, struct >>> fiemap_extent_info *fieinfo, >>>> return ret; >>>> } >>>> >>>> +/* Is IO overwriting allocated blocks? */ >>>> +int ocfs2_overwrite_io(struct inode *inode, u64 map_start, u64 map_len, >>>> + int wait) >>>> +{ >>>> + int ret = 0, is_last; >>>> + u32 mapping_end, cpos; >>>> + struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); >>>> + struct buffer_head *di_bh = NULL; >>>> + struct ocfs2_extent_rec rec; >>>> + >>>> + if (wait) >>>> + ret = ocfs2_inode_lock(inode, &di_bh, 0); >>>> + else >>>> + ret = ocfs2_try_inode_lock(inode, &di_bh, 0); >>>> + if (ret) >>>> + goto out; >>>> + >>>> + if (wait) >>>> + down_read(&OCFS2_I(inode)->ip_alloc_sem); >>>> + else { >>>> + if (!down_read_trylock(&OCFS2_I(inode)->ip_alloc_sem)) { >>>> + ret = -EAGAIN; >>>> + goto out_unlock1; >>>> + } >>>> + } >>>> + >>>> + if ((OCFS2_I(inode)->ip_dyn_features & OCFS2_INLINE_DATA_FL) && >>>> + ((map_start + map_len) <= i_size_read(inode))) >>>> + goto out_unlock2; >>>> + >>>> + cpos = map_start >> osb->s_clustersize_bits; >>>> + mapping_end = ocfs2_clusters_for_bytes(inode->i_sb, >>>> + map_start + map_len); >>>> + is_last = 0; >>>> + while (cpos < mapping_end && !is_last) { >>>> + ret = ocfs2_get_clusters_nocache(inode, di_bh, cpos, >>>> + NULL, &rec, &is_last); >>>> + if (ret) { >>>> + mlog_errno(ret); >>>> + goto out_unlock2; >>>> + } >>>> + >>>> + if (rec.e_blkno == 0ULL) >>>> + break; >>>> + >>>> + if (rec.e_flags & OCFS2_EXT_REFCOUNTED) >>>> + break; >>>> + >>>> + cpos = le32_to_cpu(rec.e_cpos) + >>>> + le16_to_cpu(rec.e_leaf_clusters); >>>> + } >>>> + >>>> + if (cpos < mapping_end) >>>> + ret = 1; >>>> + >>>> +out_unlock2: >>>> + brelse(di_bh); >>>> + >>>> + up_read(&OCFS2_I(inode)->ip_alloc_sem); >>>> + >>>> +out_unlock1: >>> Should brelse(di_bh) be here? >> If the code jumps to out_unlock1 directly, the di_bh pointer should be NULL, > it is not necessary to release. >> > Umm... No, once going out here, we have already taken inode lock. So > di_bh should be released. Sorry, you are right. > >>> >>>> + ocfs2_inode_unlock(inode, 0); >>>> + >>>> +out: >>>> + return (ret ? 0 : 1); >>> I don't think EAGAIN and other error code can be handled the same. We >>> have to distinguish them. >> Ok, I think we can add one line log to report the error in case the error is > not EAGAIN. >> > My point is, there is no need to try again in several cases, e.g. EROFS > returned by ocfs2_get_clusters_nocache. In this function ocfs2_overwrite_io() only can return True(1) or False(0), then I think we can only give a error print before return true/false. It is not necessary to return another value, but should let the user know any possible error message. Thanks Gang > >>> >>> Thanks, >>> Joseph >>> >>>> +} >>>> + >>>> int ocfs2_seek_data_hole_offset(struct file *file, loff_t *offset, int >>> whence) >>>> { >>>> struct inode *inode = file->f_mapping->host; >>>> diff --git a/fs/ocfs2/extent_map.h b/fs/ocfs2/extent_map.h >>>> index 67ea57d..fd9e86a 100644 >>>> --- a/fs/ocfs2/extent_map.h >>>> +++ b/fs/ocfs2/extent_map.h >>>> @@ -53,6 +53,9 @@ int ocfs2_extent_map_get_blocks(struct inode *inode, u64 >>> v_blkno, u64 *p_blkno, >>>> int ocfs2_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, >>>> u64 map_start, u64 map_len); >>>> >>>> +int ocfs2_overwrite_io(struct inode *inode, u64 map_start, u64 map_len, >>>> + int wait); >>>> + >>>> int ocfs2_seek_data_hole_offset(struct file *file, loff_t *offset, int >>> origin); >>>> >>>> int ocfs2_xattr_get_clusters(struct inode *inode, u32 v_cluster, >>>> >>
WARNING: multiple messages have this Message-ID (diff)
From: Gang He <ghe@suse.com> To: jlbec@evilplan.org, jiangqi903@gmail.com, hch@lst.de, Goldwyn Rodrigues <RGoldwyn@suse.com>, mfasheh@versity.com Cc: ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org Subject: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function Date: Tue, 28 Nov 2017 00:24:50 -0700 [thread overview] Message-ID: <5A1D7FC2020000F90009AD91@prv-mh.provo.novell.com> (raw) In-Reply-To: <805fb849-dcc7-cbbc-02af-1c6116a88957@gmail.com> Hello Joseph, >>> > > On 17/11/28 11:35, Gang He wrote: >> Hello Joseph, >> >> >>>>> >>> Hi Gang, >>> >>> On 17/11/27 17:46, Gang He wrote: >>>> Add ocfs2_overwrite_io function, which is used to judge if >>>> overwrite allocated blocks, otherwise, the write will bring extra >>>> block allocation overhead. >>>> >>>> Signed-off-by: Gang He <ghe@suse.com> >>>> --- >>>> fs/ocfs2/extent_map.c | 67 >>> +++++++++++++++++++++++++++++++++++++++++++++++++++ >>>> fs/ocfs2/extent_map.h | 3 +++ >>>> 2 files changed, 70 insertions(+) >>>> >>>> diff --git a/fs/ocfs2/extent_map.c b/fs/ocfs2/extent_map.c >>>> index e4719e0..98bf325 100644 >>>> --- a/fs/ocfs2/extent_map.c >>>> +++ b/fs/ocfs2/extent_map.c >>>> @@ -832,6 +832,73 @@ int ocfs2_fiemap(struct inode *inode, struct >>> fiemap_extent_info *fieinfo, >>>> return ret; >>>> } >>>> >>>> +/* Is IO overwriting allocated blocks? */ >>>> +int ocfs2_overwrite_io(struct inode *inode, u64 map_start, u64 map_len, >>>> + int wait) >>>> +{ >>>> + int ret = 0, is_last; >>>> + u32 mapping_end, cpos; >>>> + struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); >>>> + struct buffer_head *di_bh = NULL; >>>> + struct ocfs2_extent_rec rec; >>>> + >>>> + if (wait) >>>> + ret = ocfs2_inode_lock(inode, &di_bh, 0); >>>> + else >>>> + ret = ocfs2_try_inode_lock(inode, &di_bh, 0); >>>> + if (ret) >>>> + goto out; >>>> + >>>> + if (wait) >>>> + down_read(&OCFS2_I(inode)->ip_alloc_sem); >>>> + else { >>>> + if (!down_read_trylock(&OCFS2_I(inode)->ip_alloc_sem)) { >>>> + ret = -EAGAIN; >>>> + goto out_unlock1; >>>> + } >>>> + } >>>> + >>>> + if ((OCFS2_I(inode)->ip_dyn_features & OCFS2_INLINE_DATA_FL) && >>>> + ((map_start + map_len) <= i_size_read(inode))) >>>> + goto out_unlock2; >>>> + >>>> + cpos = map_start >> osb->s_clustersize_bits; >>>> + mapping_end = ocfs2_clusters_for_bytes(inode->i_sb, >>>> + map_start + map_len); >>>> + is_last = 0; >>>> + while (cpos < mapping_end && !is_last) { >>>> + ret = ocfs2_get_clusters_nocache(inode, di_bh, cpos, >>>> + NULL, &rec, &is_last); >>>> + if (ret) { >>>> + mlog_errno(ret); >>>> + goto out_unlock2; >>>> + } >>>> + >>>> + if (rec.e_blkno == 0ULL) >>>> + break; >>>> + >>>> + if (rec.e_flags & OCFS2_EXT_REFCOUNTED) >>>> + break; >>>> + >>>> + cpos = le32_to_cpu(rec.e_cpos) + >>>> + le16_to_cpu(rec.e_leaf_clusters); >>>> + } >>>> + >>>> + if (cpos < mapping_end) >>>> + ret = 1; >>>> + >>>> +out_unlock2: >>>> + brelse(di_bh); >>>> + >>>> + up_read(&OCFS2_I(inode)->ip_alloc_sem); >>>> + >>>> +out_unlock1: >>> Should brelse(di_bh) be here? >> If the code jumps to out_unlock1 directly, the di_bh pointer should be NULL, > it is not necessary to release. >> > Umm... No, once going out here, we have already taken inode lock. So > di_bh should be released. Sorry, you are right. > >>> >>>> + ocfs2_inode_unlock(inode, 0); >>>> + >>>> +out: >>>> + return (ret ? 0 : 1); >>> I don't think EAGAIN and other error code can be handled the same. We >>> have to distinguish them. >> Ok, I think we can add one line log to report the error in case the error is > not EAGAIN. >> > My point is, there is no need to try again in several cases, e.g. EROFS > returned by ocfs2_get_clusters_nocache. In this function ocfs2_overwrite_io() only can return True(1) or False(0), then I think we can only give a error print before return true/false. It is not necessary to return another value, but should let the user know any possible error message. Thanks Gang > >>> >>> Thanks, >>> Joseph >>> >>>> +} >>>> + >>>> int ocfs2_seek_data_hole_offset(struct file *file, loff_t *offset, int >>> whence) >>>> { >>>> struct inode *inode = file->f_mapping->host; >>>> diff --git a/fs/ocfs2/extent_map.h b/fs/ocfs2/extent_map.h >>>> index 67ea57d..fd9e86a 100644 >>>> --- a/fs/ocfs2/extent_map.h >>>> +++ b/fs/ocfs2/extent_map.h >>>> @@ -53,6 +53,9 @@ int ocfs2_extent_map_get_blocks(struct inode *inode, u64 >>> v_blkno, u64 *p_blkno, >>>> int ocfs2_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, >>>> u64 map_start, u64 map_len); >>>> >>>> +int ocfs2_overwrite_io(struct inode *inode, u64 map_start, u64 map_len, >>>> + int wait); >>>> + >>>> int ocfs2_seek_data_hole_offset(struct file *file, loff_t *offset, int >>> origin); >>>> >>>> int ocfs2_xattr_get_clusters(struct inode *inode, u32 v_cluster, >>>> >>
next prev parent reply other threads:[~2017-11-28 7:25 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-27 9:46 [PATCH 0/3] ocfs2: add nowait aio support Gang He 2017-11-27 9:46 ` [Ocfs2-devel] " Gang He 2017-11-27 9:46 ` [PATCH 1/3] ocfs2: add ocfs2_try_rw_lock and ocfs2_try_inode_lock Gang He 2017-11-27 9:46 ` [Ocfs2-devel] " Gang He 2017-11-28 1:32 ` piaojun 2017-11-28 1:32 ` piaojun 2017-11-28 5:05 ` Gang He 2017-11-28 5:05 ` Gang He 2017-11-28 1:52 ` Changwei Ge 2017-11-28 1:52 ` Changwei Ge 2017-11-28 5:26 ` Gang He 2017-11-28 5:26 ` Gang He 2017-11-27 9:46 ` [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function Gang He 2017-11-27 9:46 ` [Ocfs2-devel] " Gang He 2017-11-28 1:13 ` Joseph Qi 2017-11-28 1:13 ` Joseph Qi 2017-11-28 3:35 ` Gang He 2017-11-28 3:35 ` Gang He 2017-11-28 6:51 ` Joseph Qi 2017-11-28 6:51 ` Joseph Qi 2017-11-28 7:24 ` Gang He [this message] 2017-11-28 7:24 ` Gang He 2017-11-28 8:40 ` Joseph Qi 2017-11-28 8:40 ` Joseph Qi 2017-11-28 8:54 ` Gang He 2017-11-28 8:54 ` Gang He 2017-11-28 9:03 ` Joseph Qi 2017-11-28 9:03 ` Joseph Qi 2017-11-28 1:50 ` piaojun 2017-11-28 1:50 ` piaojun 2017-11-28 2:10 ` Changwei Ge 2017-11-28 2:10 ` Changwei Ge 2017-11-28 5:27 ` Gang He 2017-11-28 5:27 ` Gang He 2017-11-28 5:07 ` Gang He 2017-11-28 5:07 ` Gang He 2017-11-28 2:19 ` alex chen 2017-11-28 2:19 ` alex chen 2017-11-28 5:33 ` Gang He 2017-11-28 5:33 ` Gang He 2017-11-28 6:19 ` alex chen 2017-11-28 6:19 ` alex chen 2017-11-28 7:38 ` Gang He 2017-11-28 7:38 ` Gang He 2017-11-28 8:11 ` alex chen 2017-11-28 8:11 ` alex chen 2017-11-28 8:32 ` Gang He 2017-11-28 8:32 ` Gang He 2017-11-28 13:22 ` alex chen 2017-11-28 13:22 ` alex chen 2017-11-28 2:48 ` Changwei Ge 2017-11-28 2:48 ` Changwei Ge 2017-11-28 5:40 ` Gang He 2017-11-28 5:40 ` Gang He 2017-11-28 5:48 ` Changwei Ge 2017-11-28 5:48 ` Changwei Ge 2017-11-27 9:46 ` [PATCH 3/3] ocfs2: nowait aio support Gang He 2017-11-27 9:46 ` [Ocfs2-devel] " Gang He 2017-11-28 2:51 ` alex chen 2017-11-28 2:51 ` alex chen 2017-11-28 5:59 ` Gang He 2017-11-28 5:59 ` Gang He
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5A1D7FC2020000F90009AD91@prv-mh.provo.novell.com \ --to=ghe@suse.com \ --cc=RGoldwyn@suse.com \ --cc=hch@lst.de \ --cc=jiangqi903@gmail.com \ --cc=jlbec@evilplan.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mfasheh@versity.com \ --cc=ocfs2-devel@oss.oracle.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.