All of lore.kernel.org
 help / color / mirror / Atom feed
From: piaojun <piaojun@huawei.com>
To: <linux-ext4@vger.kernel.org>, <tytso@mit.edu>
Subject: Re: [PATCH] ext4: no need flush workqueue before destroying it
Date: Mon, 4 Dec 2017 08:43:13 +0800	[thread overview]
Message-ID: <5A249A21.7090305@huawei.com> (raw)
In-Reply-To: <5A210840.1020807@huawei.com>

Hi Ted,

Could you help reviewing my patch?

thanks,
Jun

On 2017/12/1 15:44, piaojun wrote:
> destroy_workqueue() will do flushing work for us.
> 
> Signed-off-by: Jun Piao <piaojun@huawei.com>
> ---
>  fs/ext4/super.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 0556cd0..2f46b0b 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -870,7 +870,6 @@ static void ext4_put_super(struct super_block *sb)
>  	ext4_unregister_li_request(sb);
>  	ext4_quota_off_umount(sb);
> 
> -	flush_workqueue(sbi->rsv_conversion_wq);
>  	destroy_workqueue(sbi->rsv_conversion_wq);
> 
>  	if (sbi->s_journal) {
> 

  reply	other threads:[~2017-12-04  0:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01  7:44 [PATCH] ext4: no need flush workqueue before destroying it piaojun
2017-12-04  0:43 ` piaojun [this message]
2018-01-09 12:37 piaojun
2018-01-09 15:07 ` Jan Kara
2018-01-10  0:16   ` piaojun
2018-01-10  2:42     ` Theodore Ts'o
2018-01-10  0:19 piaojun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A249A21.7090305@huawei.com \
    --to=piaojun@huawei.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.