From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: [PATCH 3/3] x86/p2m: force return value checking of p2m_set_entry() Date: Mon, 04 Dec 2017 04:07:21 -0700 Message-ID: <5A253A79020000780019451D@prv-mh.provo.novell.com> References: <5A25364E0200007800194503@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLoay-0003oA-5k for xen-devel@lists.xenproject.org; Mon, 04 Dec 2017 11:07:32 +0000 In-Reply-To: <5A25364E0200007800194503@prv-mh.provo.novell.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: xen-devel Cc: George Dunlap , Andrew Cooper , Kevin Tian , Jun Nakajima List-Id: xen-devel@lists.xenproject.org QXMgWFNBcyAyNDYgYW5kIDI0NyBoYXZlIHNob3duLCBub3QgZG9pbmcgc28gaXMgcmF0aGVyIGRh bmdlcm91cy4KClNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4K Ci0tLSBhL3hlbi9hcmNoL3g4Ni9tbS9wMm0uYworKysgYi94ZW4vYXJjaC94ODYvbW0vcDJtLmMK QEAgLTE1NTAsOSArMTU1MCwxMSBAQCB2b2lkIHAybV9tZW1fcGFnaW5nX3BvcHVsYXRlKHN0cnVj dCBkb21hCiAgICAgICAgIGlmICggcDJtdCA9PSBwMm1fcmFtX3BhZ2luZ19vdXQgKQogICAgICAg ICAgICAgcmVxLnUubWVtX3BhZ2luZy5mbGFncyB8PSBNRU1fUEFHSU5HX0VWSUNUX0ZBSUw7CiAK LSAgICAgICAgcDJtX3NldF9lbnRyeShwMm0sIGdmbiwgbWZuLCBQQUdFX09SREVSXzRLLCBwMm1f cmFtX3BhZ2luZ19pbiwgYSk7CisgICAgICAgIHJjID0gcDJtX3NldF9lbnRyeShwMm0sIGdmbiwg bWZuLCBQQUdFX09SREVSXzRLLCBwMm1fcmFtX3BhZ2luZ19pbiwgYSk7CiAgICAgfQogICAgIGdm bl91bmxvY2socDJtLCBnZm4sIDApOworICAgIGlmICggcmMgPCAwICkKKyAgICAgICAgcmV0dXJu OwogCiAgICAgLyogUGF1c2UgZG9tYWluIGlmIHJlcXVlc3QgY2FtZSBmcm9tIGd1ZXN0IGFuZCBn Zm4gaGFzIHBhZ2luZyB0eXBlICovCiAgICAgaWYgKCBwMm1faXNfcGFnaW5nKHAybXQpICYmIHYt PmRvbWFpbiA9PSBkICkKQEAgLTE3MDAsMTAgKzE3MDIsMTIgQEAgdm9pZCBwMm1fbWVtX3BhZ2lu Z19yZXN1bWUoc3RydWN0IGRvbWFpbgogICAgICAgICAgKi8KICAgICAgICAgaWYgKCBtZm5fdmFs aWQobWZuKSAmJiAocDJtdCA9PSBwMm1fcmFtX3BhZ2luZ19pbikgKQogICAgICAgICB7Ci0gICAg ICAgICAgICBwMm1fc2V0X2VudHJ5KHAybSwgZ2ZuLCBtZm4sIFBBR0VfT1JERVJfNEssCi0gICAg ICAgICAgICAgICAgICAgICAgICAgIHBhZ2luZ19tb2RlX2xvZ19kaXJ0eShkKSA/IHAybV9yYW1f bG9nZGlydHkgOgotICAgICAgICAgICAgICAgICAgICAgICAgICBwMm1fcmFtX3J3LCBhKTsKLSAg ICAgICAgICAgIHNldF9ncGZuX2Zyb21fbWZuKG1mbl94KG1mbiksIGdmbl94KGdmbikpOworICAg ICAgICAgICAgaW50IHJjID0gcDJtX3NldF9lbnRyeShwMm0sIGdmbiwgbWZuLCBQQUdFX09SREVS XzRLLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYWdpbmdfbW9kZV9sb2df ZGlydHkoZCkgPyBwMm1fcmFtX2xvZ2RpcnR5IDoKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgcDJtX3JhbV9ydywgYSk7CisKKyAgICAgICAgICAgIGlmICggIXJjICkKKyAgICAg ICAgICAgICAgICBzZXRfZ3Bmbl9mcm9tX21mbihtZm5feChtZm4pLCBnZm5feChnZm4pKTsKICAg ICAgICAgfQogICAgICAgICBnZm5fdW5sb2NrKHAybSwgZ2ZuLCAwKTsKICAgICB9CkBAIC0yNDYz LDkgKzI0NjcsOSBAQCBzdGF0aWMgdm9pZCBwMm1fcmVzZXRfYWx0cDJtKHN0cnVjdCBwMm1fCiAg ICAgcDJtLT5tYXhfcmVtYXBwZWRfZ2ZuID0gMDsKIH0KIAotdm9pZCBwMm1fYWx0cDJtX3Byb3Bh Z2F0ZV9jaGFuZ2Uoc3RydWN0IGRvbWFpbiAqZCwgZ2ZuX3QgZ2ZuLAotICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgbWZuX3QgbWZuLCB1bnNpZ25lZCBpbnQgcGFnZV9vcmRlciwKLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHAybV90eXBlX3QgcDJtdCwgcDJtX2FjY2Vz c190IHAybWEpCitpbnQgcDJtX2FsdHAybV9wcm9wYWdhdGVfY2hhbmdlKHN0cnVjdCBkb21haW4g KmQsIGdmbl90IGdmbiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbWZuX3QgbWZu LCB1bnNpZ25lZCBpbnQgcGFnZV9vcmRlciwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgcDJtX3R5cGVfdCBwMm10LCBwMm1fYWNjZXNzX3QgcDJtYSkKIHsKICAgICBzdHJ1Y3QgcDJt X2RvbWFpbiAqcDJtOwogICAgIHAybV9hY2Nlc3NfdCBhOwpAQCAtMjQ3NCw5ICsyNDc4LDEwIEBA IHZvaWQgcDJtX2FsdHAybV9wcm9wYWdhdGVfY2hhbmdlKHN0cnVjdAogICAgIHVuc2lnbmVkIGlu dCBpOwogICAgIHVuc2lnbmVkIGludCByZXNldF9jb3VudCA9IDA7CiAgICAgdW5zaWduZWQgaW50 IGxhc3RfcmVzZXRfaWR4ID0gfjA7CisgICAgaW50IHJldCA9IDA7CiAKICAgICBpZiAoICFhbHRw Mm1fYWN0aXZlKGQpICkKLSAgICAgICAgcmV0dXJuOworICAgICAgICByZXR1cm4gMDsKIAogICAg IGFsdHAybV9saXN0X2xvY2soZCk7CiAKQEAgLTI1MTUsMTcgKzI1MjAsMjUgQEAgdm9pZCBwMm1f YWx0cDJtX3Byb3BhZ2F0ZV9jaGFuZ2Uoc3RydWN0CiAgICAgICAgICAgICAgICAgICAgIHAybV91 bmxvY2socDJtKTsKICAgICAgICAgICAgICAgICB9CiAKLSAgICAgICAgICAgICAgICBnb3RvIG91 dDsKKyAgICAgICAgICAgICAgICByZXQgPSAwOworICAgICAgICAgICAgICAgIGJyZWFrOwogICAg ICAgICAgICAgfQogICAgICAgICB9CiAgICAgICAgIGVsc2UgaWYgKCAhbWZuX2VxKG0sIElOVkFM SURfTUZOKSApCi0gICAgICAgICAgICBwMm1fc2V0X2VudHJ5KHAybSwgZ2ZuLCBtZm4sIHBhZ2Vf b3JkZXIsIHAybXQsIHAybWEpOworICAgICAgICB7CisgICAgICAgICAgICBpbnQgcmMgPSBwMm1f c2V0X2VudHJ5KHAybSwgZ2ZuLCBtZm4sIHBhZ2Vfb3JkZXIsIHAybXQsIHAybWEpOworCisgICAg ICAgICAgICAvKiBCZXN0IGVmZm9ydDogRG9uJ3QgYmFpbCBvbiBlcnJvci4gKi8KKyAgICAgICAg ICAgIGlmICggIXJldCApCisgICAgICAgICAgICAgICAgcmV0ID0gcmM7CisgICAgICAgIH0KIAog ICAgICAgICBfX3B1dF9nZm4ocDJtLCBnZm5feChnZm4pKTsKICAgICB9CiAKLSBvdXQ6CiAgICAg YWx0cDJtX2xpc3RfdW5sb2NrKGQpOworCisgICAgcmV0dXJuIHJldDsKIH0KIAogLyoqKiBBdWRp dCAqKiovCi0tLSBhL3hlbi9hcmNoL3g4Ni9tbS9wMm0tZXB0LmMKKysrIGIveGVuL2FyY2gveDg2 L21tL3AybS1lcHQuYwpAQCAtOTA0LDcgKzkwNCwxMSBAQCBvdXQ6CiAgICAgICAgIGVwdF9mcmVl X2VudHJ5KHAybSwgJm9sZF9lbnRyeSwgdGFyZ2V0KTsKIAogICAgIGlmICggZW50cnlfd3JpdHRl biAmJiBwMm1faXNfaG9zdHAybShwMm0pICkKLSAgICAgICAgcDJtX2FsdHAybV9wcm9wYWdhdGVf Y2hhbmdlKGQsIF9nZm4oZ2ZuKSwgbWZuLCBvcmRlciwgcDJtdCwgcDJtYSk7CisgICAgeworICAg ICAgICByZXQgPSBwMm1fYWx0cDJtX3Byb3BhZ2F0ZV9jaGFuZ2UoZCwgX2dmbihnZm4pLCBtZm4s IG9yZGVyLCBwMm10LCBwMm1hKTsKKyAgICAgICAgaWYgKCAhcmMgKQorICAgICAgICAgICAgcmMg PSByZXQ7CisgICAgfQogCiAgICAgcmV0dXJuIHJjOwogfQotLS0gYS94ZW4vaW5jbHVkZS9hc20t eDg2L3AybS5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvcDJtLmgKQEAgLTY4OSw4ICs2ODks OSBAQCB2b2lkIHAybV9mcmVlX3B0cChzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtCiAKIC8qIERpcmVj dGx5IHNldCBhIHAybSBlbnRyeTogb25seSBmb3IgdXNlIGJ5IHAybSBjb2RlLiBEb2VzIG5vdCBu ZWVkCiAgKiBhIGNhbGwgdG8gcHV0X2dmbiBhZnRlcndhcmRzLyAqLwotaW50IHAybV9zZXRfZW50 cnkoc3RydWN0IHAybV9kb21haW4gKnAybSwgZ2ZuX3QgZ2ZuLCBtZm5fdCBtZm4sCi0gICAgICAg ICAgICAgICAgICB1bnNpZ25lZCBpbnQgcGFnZV9vcmRlciwgcDJtX3R5cGVfdCBwMm10LCBwMm1f YWNjZXNzX3QgcDJtYSk7CitpbnQgX19tdXN0X2NoZWNrIHAybV9zZXRfZW50cnkoc3RydWN0IHAy bV9kb21haW4gKnAybSwgZ2ZuX3QgZ2ZuLCBtZm5fdCBtZm4sCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgdW5zaWduZWQgaW50IHBhZ2Vfb3JkZXIsIHAybV90eXBlX3QgcDJtdCwKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwMm1fYWNjZXNzX3QgcDJtYSk7CiAKIC8qIFNl dCB1cCBmdW5jdGlvbiBwb2ludGVycyBmb3IgUFQgaW1wbGVtZW50YXRpb246IG9ubHkgZm9yIHVz ZSBieSBwMm0gY29kZSAqLwogZXh0ZXJuIHZvaWQgcDJtX3B0X2luaXQoc3RydWN0IHAybV9kb21h aW4gKnAybSk7CkBAIC04MzAsOSArODMxLDkgQEAgaW50IHAybV9jaGFuZ2VfYWx0cDJtX2dmbihz dHJ1Y3QgZG9tYWluCiAgICAgICAgICAgICAgICAgICAgICAgICAgIGdmbl90IG9sZF9nZm4sIGdm bl90IG5ld19nZm4pOwogCiAvKiBQcm9wYWdhdGUgYSBob3N0IHAybSBjaGFuZ2UgdG8gYWxsIGFs dGVybmF0ZSBwMm0ncyAqLwotdm9pZCBwMm1fYWx0cDJtX3Byb3BhZ2F0ZV9jaGFuZ2Uoc3RydWN0 IGRvbWFpbiAqZCwgZ2ZuX3QgZ2ZuLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg bWZuX3QgbWZuLCB1bnNpZ25lZCBpbnQgcGFnZV9vcmRlciwKLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHAybV90eXBlX3QgcDJtdCwgcDJtX2FjY2Vzc190IHAybWEpOworaW50IHAy bV9hbHRwMm1fcHJvcGFnYXRlX2NoYW5nZShzdHJ1Y3QgZG9tYWluICpkLCBnZm5fdCBnZm4sCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1mbl90IG1mbiwgdW5zaWduZWQgaW50IHBh Z2Vfb3JkZXIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHAybV90eXBlX3QgcDJt dCwgcDJtX2FjY2Vzc190IHAybWEpOwogCiAvKgogICogcDJtIHR5cGUgdG8gSU9NTVUgZmxhZ3MK CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRl dmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9s aXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==