From: "Jan Beulich" <JBeulich@suse.com>
To: xen-devel <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Jun Nakajima <jun.nakajima@intel.com>
Subject: [PATCH] VMX: drop bogus gpa parameter from __invept()
Date: Wed, 06 Dec 2017 09:28:34 -0700 [thread overview]
Message-ID: <5A2828C202000078001952A2@prv-mh.provo.novell.com> (raw)
Perhaps there once was a plan to have a flush type requiring this, but
the current SDM has no mention of such and all callers pass zero anyway.
Take the opportunity and also change involved types to uint64_t.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -4281,9 +4281,9 @@ bool vmx_vmenter_helper(const struct cpu
{
cpumask_clear_cpu(cpu, ept->invalidate);
if ( nestedhvm_enabled(curr->domain) )
- __invept(INVEPT_ALL_CONTEXT, 0, 0);
+ __invept(INVEPT_ALL_CONTEXT, 0);
else
- __invept(INVEPT_SINGLE_CONTEXT, ept->eptp, 0);
+ __invept(INVEPT_SINGLE_CONTEXT, ept->eptp);
}
}
--- a/xen/arch/x86/hvm/vmx/vvmx.c
+++ b/xen/arch/x86/hvm/vmx/vvmx.c
@@ -1941,7 +1941,7 @@ int nvmx_handle_invept(struct cpu_user_r
}
case INVEPT_ALL_CONTEXT:
p2m_flush_nestedp2m(current->domain);
- __invept(INVEPT_ALL_CONTEXT, 0, 0);
+ __invept(INVEPT_ALL_CONTEXT, 0);
break;
default:
vmfail_invalid(regs);
--- a/xen/include/asm-x86/hvm/vmx/vmx.h
+++ b/xen/include/asm-x86/hvm/vmx/vmx.h
@@ -452,11 +452,11 @@ static inline enum vmx_insn_errno vmwrit
return ret;
}
-static always_inline void __invept(unsigned long type, u64 eptp, u64 gpa)
+static always_inline void __invept(unsigned long type, uint64_t eptp)
{
struct {
- u64 eptp, gpa;
- } operand = {eptp, gpa};
+ uint64_t eptp, rsvd;
+ } operand = { eptp };
/*
* If single context invalidation is not supported, we escalate to
@@ -519,7 +519,7 @@ static always_inline void __invvpid(unsi
static inline void ept_sync_all(void)
{
- __invept(INVEPT_ALL_CONTEXT, 0, 0);
+ __invept(INVEPT_ALL_CONTEXT, 0);
}
void ept_sync_domain(struct p2m_domain *p2m);
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next reply other threads:[~2017-12-06 16:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 16:28 Jan Beulich [this message]
2017-12-06 16:45 ` [PATCH] VMX: drop bogus gpa parameter from __invept() Andrew Cooper
2017-12-13 8:07 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A2828C202000078001952A2@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.